> On Jan. 24, 2017, 6:14 p.m., András Piros wrote: > > core/src/test/java/org/apache/oozie/command/coord/TestCoordCommandUtils.java, > > line 521 > > <https://reviews.apache.org/r/51029/diff/3-4/?file=1612950#file1612950line521> > > > > > > `testCoord_endOfMonthTillMiddleOfNext_differenceIsCalculatedCorrectly()` > > would be a better name.
Throughout Oozie code camel caseing is used for naming test case methods. I updated the the method names to elaborate more. > On Jan. 24, 2017, 6:14 p.m., András Piros wrote: > > core/src/test/java/org/apache/oozie/command/coord/TestCoordCommandUtils.java, > > line 553 > > <https://reviews.apache.org/r/51029/diff/3-4/?file=1612950#file1612950line553> > > > > > > `testCoord_middleOfMonth_tillEndOfNext_differenceIsCalculatedCorrectly()` > > would be a better name. Throughout Oozie code camel caseing is used for naming test case methods. I updated the the method names to elaborate more. > On Jan. 24, 2017, 6:14 p.m., András Piros wrote: > > core/src/test/java/org/apache/oozie/command/coord/TestCoordCommandUtils.java, > > line 590 > > <https://reviews.apache.org/r/51029/diff/3-4/?file=1612950#file1612950line590> > > > > `testCoord_startIsAfterEnd_throw()` would be a better name. Throughout Oozie code camel caseing is used for naming test case methods. I updated the the method names to elaborate more. > On Jan. 24, 2017, 6:14 p.m., András Piros wrote: > > core/src/test/java/org/apache/oozie/command/coord/TestCoordCommandUtils.java, > > line 609 > > <https://reviews.apache.org/r/51029/diff/3-4/?file=1612950#file1612950line609> > > > > `testCoord_latestEnd_notSupported()` would be a better name. Throughout Oozie code camel caseing is used for naming test case methods. I updated the the method names to elaborate more. > On Jan. 24, 2017, 6:14 p.m., András Piros wrote: > > core/src/test/java/org/apache/oozie/command/coord/TestCoordCommandUtils.java, > > line 630 > > <https://reviews.apache.org/r/51029/diff/3-4/?file=1612950#file1612950line630> > > > > `testCoord_endOfWeeksTillCurrent_correct()` would be a better name. Throughout Oozie code camel caseing is used for naming test case methods. I updated the the method names to elaborate more. - Satish ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51029/#review162866 ----------------------------------------------------------- On Jan. 24, 2017, 2:49 p.m., Satish Saley wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51029/ > ----------------------------------------------------------- > > (Updated Jan. 24, 2017, 2:49 p.m.) > > > Review request for oozie. > > > Bugs: OOZIE-2630 > https://issues.apache.org/jira/browse/OOZIE-2630 > > > Repository: oozie-git > > > Description > ------- > > Oozie Coordinator EL Functions to get first day of the week/month > > > Diffs > ----- > > core/src/main/java/org/apache/oozie/command/coord/CoordCommandUtils.java > 0af7edc > core/src/main/java/org/apache/oozie/command/coord/CoordSubmitXCommand.java > 969336d > core/src/main/java/org/apache/oozie/coord/CoordELFunctions.java 925a7aa > core/src/main/java/org/apache/oozie/coord/TimeUnit.java 5b37639 > core/src/main/java/org/apache/oozie/util/DateUtils.java 3caf0a2 > core/src/main/resources/oozie-default.xml ad10386 > > core/src/test/java/org/apache/oozie/command/coord/TestCoordCommandUtils.java > 7062e69 > > core/src/test/java/org/apache/oozie/command/coord/TestCoordMaterializeTransitionXCommand.java > 29e7ca1 > core/src/test/java/org/apache/oozie/coord/TestCoordELFunctions.java be60133 > core/src/test/resources/coord-dataset-endOfDays.xml PRE-CREATION > core/src/test/resources/coord-dataset-endOfMonths.xml PRE-CREATION > core/src/test/resources/coord-dataset-endOfWeeks.xml PRE-CREATION > docs/src/site/twiki/CoordinatorFunctionalSpec.twiki e3ac514 > > Diff: https://reviews.apache.org/r/51029/diff/ > > > Testing > ------- > > Tested locally > > > Thanks, > > Satish Saley > >
