----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55963/#review163095 -----------------------------------------------------------
core/src/main/java/org/apache/oozie/dependency/hcat/SimpleHCatDependencyCache.java (line 427) <https://reviews.apache.org/r/55963/#comment234544> Just use getHostName(). Normalization is unrelated to getting canonical host name. You can refer to uri.normalize() to understand what normalize does. core/src/main/java/org/apache/oozie/dependency/hcat/SimpleHCatDependencyCache.java (lines 436 - 437) <https://reviews.apache.org/r/55963/#comment234542> This host/port splitting is unnecessary. Add a getHost method to HCatURI and use that to just get uri.getHost(). In fact you can add HCatURI.getCanonicalHost() method and use that as well. i.e String getHostName(HCatURI hcatURI) { if (useCanonicalHostName) { return hcatURI.getCanonicalHost(); } else { return hcatURI.getHost(); } } core/src/main/resources/oozie-default.xml (line 216) <https://reviews.apache.org/r/55963/#comment234546> We don't use camel case in property names. oozie.service.HCatAccessorService.cache.use.canonical.hostname core/src/main/resources/oozie-default.xml (lines 218 - 221) <https://reviews.apache.org/r/55963/#comment234548> The jms messages published from a hcat server usually contains the canonical hostname of the hcat server in standalone mode or the canonical name of the VIP in case of multiple nodes in a HA setup. This setting is used to translate the hcat server hostname or its aliases specified by the user in the hcat URIs of the coordinator dependencies to its canonical name, so that they can be exactly matched with the JMS dependency availability notifications. Please copy the current description you have which explains the internal code issues in detail to the description of the OOZIE-2781 jira which is currently empty. - Rohini Palaniswamy On Jan. 25, 2017, 11:52 p.m., Purshotam Shah wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55963/ > ----------------------------------------------------------- > > (Updated Jan. 25, 2017, 11:52 p.m.) > > > Review request for oozie. > > > Bugs: OOZIE-2781 > https://issues.apache.org/jira/browse/OOZIE-2781 > > > Repository: oozie-git > > > Description > ------- > > OOZIE-2781 HCat partition available notification is not sent to coordinator > actions if coordinator job is using a different hostname (cname, IP address, > etc. ) for HCat URL. > > > Diffs > ----- > > > core/src/main/java/org/apache/oozie/dependency/hcat/EhcacheHCatDependencyCache.java > 3bc467535202e13387b1d29ac678573f4154c522 > > core/src/main/java/org/apache/oozie/dependency/hcat/SimpleHCatDependencyCache.java > 9e24c9aa5f10821bf76029c51bb49e0728376caa > core/src/main/resources/oozie-default.xml > ad103864d7631e9d3678a828bf297ca1c80f09ca > > core/src/test/java/org/apache/oozie/service/TestPartitionDependencyManagerService.java > a5d2ed92ffe9db77e2c8914b66c7806275dcc592 > > Diff: https://reviews.apache.org/r/55963/diff/ > > > Testing > ------- > > > Thanks, > > Purshotam Shah > >
