See <https://builds.apache.org/job/oozie-trunk-precommit-build/3605/>
------------------------------------------
[...truncated 13856 lines...]
Path continues at HadoopAccessorService.java:[line 434]: Path continues at
HadoopAccessorService.java:[line 433]
org.apache.oozie.service.InstrumentationService.instrumentation should be
package protected: Path continues at HadoopAccessorService.java:[line 440]
Write to static field
org.apache.oozie.service.InstrumentationService.instrumentation from instance
method org.apache.oozie.service.InstrumentationService.destroy(): At
InstrumentationService.java:[line 42]
Write to static field
org.apache.oozie.service.InstrumentationService.isEnabled from instance method
org.apache.oozie.service.InstrumentationService.destroy(): At
InstrumentationService.java:[line 122]
Write to static field
org.apache.oozie.service.InstrumentationService.instrumentation from instance
method org.apache.oozie.service.InstrumentationService.init(Services): At
InstrumentationService.java:[line 121]
Write to static field
org.apache.oozie.service.InstrumentationService.isEnabled from instance method
org.apache.oozie.service.InstrumentationService.init(Services): At
InstrumentationService.java:[line 74]
Inconsistent synchronization of
org.apache.oozie.service.JMSAccessorService.jmsProducerConnContext; locked 42%
of time: At InstrumentationService.java:[line 75]
Unsynchronized access at JMSAccessorService.java:[line 332]: Unsynchronized
access at JMSAccessorService.java:[line 331]
Unsynchronized access at JMSAccessorService.java:[line 278]: Unsynchronized
access at JMSAccessorService.java:[line 278]
Unsynchronized access at JMSAccessorService.java:[line 298]: Unsynchronized
access at JMSAccessorService.java:[line 279]
Synchronized access at JMSAccessorService.java:[line 283]: Synchronized
access at JMSAccessorService.java:[line 283]
Synchronized access at JMSAccessorService.java:[line 286]: Synchronized
access at JMSAccessorService.java:[line 285]
Synchronized access at JMSAccessorService.java:[line 287]: Synchronized
access at JMSAccessorService.java:[line 287]
At JMSAccessorService.java:[line 85]: Write to static field
org.apache.oozie.service.JMSAccessorService.LOG from instance method
org.apache.oozie.service.JMSAccessorService.init(Services)
At JMSTopicService.java:[line 99]: Write to static field
org.apache.oozie.service.JMSTopicService.LOG from instance method
org.apache.oozie.service.JMSTopicService.init(Services)
At JPAService.java:[line 141]: Write to static field
org.apache.oozie.service.JPAService.LOG from instance method
org.apache.oozie.service.JPAService.init(Services)
At JobsConcurrencyService.java:[line 47]: Write to static field
org.apache.oozie.service.JobsConcurrencyService.urls from instance method
org.apache.oozie.service.JobsConcurrencyService.init(Services)
At MetricsInstrumentationService.java:[line 54]: Write to static field
org.apache.oozie.service.MetricsInstrumentationService.isEnabled from instance
method org.apache.oozie.service.MetricsInstrumentationService.destroy()
At MetricsInstrumentationService.java:[line 45]: Write to static field
org.apache.oozie.service.InstrumentationService.instrumentation from instance
method org.apache.oozie.service.MetricsInstrumentationService.init(Services)
At MetricsInstrumentationService.java:[line 46]: Write to static field
org.apache.oozie.service.MetricsInstrumentationService.isEnabled from instance
method org.apache.oozie.service.MetricsInstrumentationService.init(Services)
At PartitionDependencyManagerService.java:[line 96]: Unread field:
org.apache.oozie.service.PartitionDependencyManagerService$CachePurgeWorker.cache
Dereferenced at RecoveryService.java:[line 213]: Possible null pointer
dereference of bundleJob in
org.apache.oozie.service.RecoveryService$RecoveryRunnable.runBundleRecovery()
Known null at RecoveryService.java:[line 209]: Null value at
RecoveryService.java:[line 208]
At Service.java:[line 56]: Initialization of
org.apache.oozie.service.Service accesses class
org.apache.oozie.service.ConfigurationService, which isn't initialized yet
At Services.java:[lines 105-109]: Incorrect lazy initialization of static
field org.apache.oozie.service.Services.SERVICES in new
org.apache.oozie.service.Services()
At Services.java:[line 132]: Exceptional return value of
java.io.File.delete() ignored in
org.apache.oozie.service.Services.createRuntimeDir()
At Services.java:[line 109]: Write to static field
org.apache.oozie.service.Services.SERVICES from instance method new
org.apache.oozie.service.Services()
At Services.java:[line 349]: Write to static field
org.apache.oozie.service.Services.SERVICES from instance method
org.apache.oozie.service.Services.destroy()
At Services.java:[line 211]: Write to static field
org.apache.oozie.service.Services.SERVICES from instance method
org.apache.oozie.service.Services.init()
org.apache.oozie.service.Services.getSystemMode() is unsynchronized,
org.apache.oozie.service.Services.setSystemMode(OozieClient$SYSTEM_MODE) is
synchronized: Another occurrence at Services.java:[line 221]
Result of integer multiplication cast to long in new
org.apache.oozie.service.ShareLibService(): At Services.java:[line 155]
Result of integer multiplication cast to long in
org.apache.oozie.service.ShareLibService.init(Services): At
ShareLibService.java:[line 113]
org.apache.oozie.service.ShareLibService.SHARE_LIB_CONF_PREFIX isn't final
but should be: At ShareLibService.java:[line 162]
Call to method of static java.text.DateFormat in
org.apache.oozie.service.ShareLibService.getLatestLibPath(Path, String): At
ShareLibService.java:[line 103]
Call to method of static java.text.DateFormat in
org.apache.oozie.service.ShareLibService.getLauncherlibPath(): At
ShareLibService.java:[line 692]
org.apache.oozie.service.ShareLibService.dateFormat is a static field of
type java.text.DateFormat, which isn't thread safe: At
ShareLibService.java:[line 662]
Call to method of static java.text.DateFormat in
org.apache.oozie.service.ShareLibService$2.accept(Path): In ShareLibService.java
Found reliance on default encoding in
org.apache.oozie.service.SparkConfigurationService.loadSparkConfigs(): new
java.io.FileReader(File): At ShareLibService.java:[line 479]
org.apache.oozie.service.StatusTransitService.lastInstanceStartTime should
be package protected: At SparkConfigurationService.java:[line 85]
org.apache.oozie.service.StatusTransitService.limit isn't final but should
be: At StatusTransitService.java:[line 59]
org.apache.oozie.service.URIHandlerService.getAuthorityWithScheme(String)
invokes substring(0), which returns the original value: At
StatusTransitService.java:[line 58]
Found reliance on default encoding in
org.apache.oozie.service.WorkflowAppService.readDefinition(String, String,
Configuration): new java.io.InputStreamReader(InputStream): At
URIHandlerService.java:[line 210]
Should org.apache.oozie.service.WorkflowAppService$NoPathFilter be a
_static_ inner class?: At WorkflowAppService.java:[line 133]
org.apache.oozie.service.XLogService.init(Services) may fail to clean up
java.io.InputStream: At WorkflowAppService.java:[lines 320-323]
Path continues at XLogService.java:[line 203]: Obligation to clean up
resource created at XLogService.java:[line 202] is not discharged
Path continues at XLogService.java:[line 208]: Path continues at
XLogService.java:[line 207]
At XLogUtil.java:[line 34]: org.apache.oozie.service.XLogUtil.log isn't
final but should be
At ZKJobsConcurrencyService.java:[line 73]: Write to static field
org.apache.oozie.service.ZKJobsConcurrencyService.leaderLatch from instance
method org.apache.oozie.service.ZKJobsConcurrencyService.init(Services)
At ZKLocksService.java:[lines 174-201]: Should
org.apache.oozie.service.ZKLocksService$ZKLockToken be a _static_ inner class?
At ZKXLogStreamingService.java:[line 208]: Dead store to xLogService in
org.apache.oozie.service.ZKXLogStreamingService.collateLogs(XLogFilter, Date,
Date, Writer, Map, String, String, int, String)
At BaseAdminServlet.java:[line 194]:
org.apache.oozie.servlet.BaseAdminServlet.getShareLib(String) makes inefficient
use of keySet iterator instead of entrySet iterator
At BaseJobServlet.java:[line 239]: Load of known null value in
org.apache.oozie.servlet.BaseJobServlet.checkAuthorizationForApp(Configuration)
Redundant null check at CallbackServlet.java:[line 76]: Redundant nullcheck
of actionId, which is known to be non-null in
org.apache.oozie.servlet.CallbackServlet.doGet(HttpServletRequest,
HttpServletResponse)
Redundant null check at CallbackServlet.java:[line 107]: Redundant
nullcheck of actionId, which is known to be non-null in
org.apache.oozie.servlet.CallbackServlet.doPost(HttpServletRequest,
HttpServletResponse)
In CallbackServlet.java: Class org.apache.oozie.servlet.CallbackServlet
defines non-transient non-serializable instance field log
At CallbackServlet.java:[line 60]: Write to static field
org.apache.oozie.servlet.CallbackServlet.maxDataLen from instance method
org.apache.oozie.servlet.CallbackServlet.init()
In JVMInfo.java: Class org.apache.oozie.servlet.JVMInfo defines
non-transient non-serializable instance field jThreadInfos
In JVMInfo.java: Class org.apache.oozie.servlet.JVMInfo defines
non-transient non-serializable instance field classLoadingMXBean
In JVMInfo.java: Class org.apache.oozie.servlet.JVMInfo defines
non-transient non-serializable instance field memoryMXBean
In JVMInfo.java: Class org.apache.oozie.servlet.JVMInfo defines
non-transient non-serializable instance field threadMXBean
At JVMInfo.java:[lines 224-271]:
org.apache.oozie.servlet.JVMInfo$ThreadComparator implements Comparator but not
Serializable
At SLAServlet.java:[line 80]: Dead store to eResponse in
org.apache.oozie.servlet.SLAServlet.doGet(HttpServletRequest,
HttpServletResponse)
At ServicesLoader.java:[line 59]:
org.apache.oozie.servlet.ServicesLoader.contextInitialized(ServletContextEvent)
invokes System.exit(...), which shuts down the entire virtual machine
At ServicesLoader.java:[line 45]: Write to static field
org.apache.oozie.servlet.ServicesLoader.services from instance method
org.apache.oozie.servlet.ServicesLoader.contextInitialized(ServletContextEvent)
At ServicesLoader.java:[line 42]: Write to static field
org.apache.oozie.servlet.ServicesLoader.sslEnabled from instance method
org.apache.oozie.servlet.ServicesLoader.contextInitialized(ServletContextEvent)
At ServletUtilities.java:[lines 36-46]: The method name
org.apache.oozie.servlet.ServletUtilities.ValidateAppPath(String, String)
doesn't start with a lower case letter
At ServletUtilities.java:[lines 59-80]: The method name
org.apache.oozie.servlet.ServletUtilities.ValidateAppPath(String, String,
String) doesn't start with a lower case letter
At ServletUtilities.java:[lines 89-92]: The method name
org.apache.oozie.servlet.ServletUtilities.ValidateLibPath(String) doesn't start
with a lower case letter
At V1JobServlet.java:[line 628]: Dead store to json in
org.apache.oozie.servlet.V1JobServlet.rerunBundleJob(HttpServletRequest,
HttpServletResponse, Configuration)
At V1JobServlet.java:[line 223]: Found reliance on default encoding in
org.apache.oozie.servlet.V1JobServlet.getJob(HttpServletRequest,
HttpServletResponse): new String(byte[])
Dereferenced at V1JobsServlet.java:[line 606]: Possible null pointer
dereference of jobs in
org.apache.oozie.servlet.V1JobsServlet.bulkModifyJobs(HttpServletRequest,
HttpServletResponse)
Known null at V1JobsServlet.java:[line 597]: Null value at
V1JobsServlet.java:[line 578]
At V2AdminServlet.java:[line 59]: Write to static field
org.apache.oozie.servlet.V2AdminServlet.metricsInstrumentation from instance
method new org.apache.oozie.servlet.V2AdminServlet()
Dead store to coordActions in
org.apache.oozie.servlet.V2JobServlet.ignoreCoordinatorJob(HttpServletRequest,
HttpServletResponse): Another occurrence at V2AdminServlet.java:[line 61]
Redundant nullcheck of json, which is known to be non-null in
org.apache.oozie.servlet.V2SLAServlet.doGet(HttpServletRequest,
HttpServletResponse): At V2JobServlet.java:[line 222]
Found reliance on default encoding in
org.apache.oozie.servlet.V2ValidateServlet.doPost(HttpServletRequest,
HttpServletResponse): new java.io.InputStreamReader(InputStream): Redundant
null check at V2SLAServlet.java:[line 98]
Another occurrence at V2ValidateServlet.java:[line 92]: At
V2ValidateServlet.java:[line 84]
At V2ValidateServlet.java:[line 86]: Exception is caught when Exception is
not thrown in
org.apache.oozie.servlet.V2ValidateServlet.doPost(HttpServletRequest,
HttpServletResponse)
At SLACalcStatus.java:[line 139]:
org.apache.oozie.sla.SLACalcStatus.getActualEnd() may expose internal
representation by returning SLACalcStatus.actualEnd
At SLACalcStatus.java:[line 130]:
org.apache.oozie.sla.SLACalcStatus.getActualStart() may expose internal
representation by returning SLACalcStatus.actualStart
At SLACalcStatus.java:[line 284]:
org.apache.oozie.sla.SLACalcStatus.getLastModifiedTime() may expose internal
representation by returning SLACalcStatus.lastModifiedTime
At SLACalcStatus.java:[line 143]:
org.apache.oozie.sla.SLACalcStatus.setActualEnd(Date) may expose internal
representation by storing an externally mutable object into
SLACalcStatus.actualEnd
At SLACalcStatus.java:[line 134]:
org.apache.oozie.sla.SLACalcStatus.setActualStart(Date) may expose internal
representation by storing an externally mutable object into
SLACalcStatus.actualStart
At SLACalcStatus.java:[line 183]:
org.apache.oozie.sla.SLACalcStatus.setLastModifiedTime(Date) may expose
internal representation by storing an externally mutable object into
SLACalcStatus.lastModifiedTime
At SLACalcStatus.java:[line 37]:
org.apache.oozie.sla.SLACalcStatus.SLA_ENTITYKEY_PREFIX isn't final but should
be
At SLACalculatorMemory.java:[line 85]: Write to static field
org.apache.oozie.sla.SLACalculatorMemory.capacity from instance method
org.apache.oozie.sla.SLACalculatorMemory.init(Configuration)
At SLACalculatorMemory.java:[line 86]: Write to static field
org.apache.oozie.sla.SLACalculatorMemory.jobEventLatency from instance method
org.apache.oozie.sla.SLACalculatorMemory.init(Configuration)
At SLACalculatorMemory.java:[line 89]: Write to static field
org.apache.oozie.sla.SLACalculatorMemory.jpaService from instance method
org.apache.oozie.sla.SLACalculatorMemory.init(Configuration)
At SLACalculatorMemory.java:[line 92]: Write to static field
org.apache.oozie.sla.SLACalculatorMemory.modifiedAfter from instance method
org.apache.oozie.sla.SLACalculatorMemory.init(Configuration)
At SLAOperations.java:[line 89]: Invocation of toString on
org.apache.oozie.client.event.SLAEvent$EventStatus.values() in
org.apache.oozie.sla.SLAOperations.createSlaRegistrationEvent(Element, String,
String, AppType, String, String, XLog, boolean, boolean)
At SLAOperations.java:[line 50]: org.apache.oozie.sla.SLAOperations.LOG
isn't final but should be
In SLARegistrationBean.java:
org.apache.oozie.sla.SLARegistrationBean.pcIsDetached() has Boolean return type
and returns explicit null
At SLASummaryBean.java:[line 447]:
org.apache.oozie.sla.SLASummaryBean.getTimeOnTimeZone(Timestamp, String)
invokes inefficient new Long(String) constructor; use Long.valueOf(String)
instead
In SLASummaryBean.java: org.apache.oozie.sla.SLASummaryBean.pcIsDetached()
has Boolean return type and returns explicit null
At SLAEmailEventListener.java:[line 115]: Boxing/unboxing to parse a
primitive
org.apache.oozie.sla.listener.SLAEmailEventListener.init(Configuration)
org.apache.oozie.sla.listener.SLAEmailEventListener.EMAIL_BODY_FIELD_INDENT
isn't final but should be: Another occurrence at
SLAEmailEventListener.java:[line 116]
org.apache.oozie.sla.listener.SLAEmailEventListener.EMAIL_BODY_FIELD_SEPARATER
isn't final but should be: At SLAEmailEventListener.java:[line 80]
org.apache.oozie.sla.listener.SLAEmailEventListener.EMAIL_BODY_HEADER_SEPARATER
isn't final but should be: At SLAEmailEventListener.java:[line 79]
org.apache.oozie.sla.service.SLAService.LOG should be package protected: At
SLAEmailEventListener.java:[line 81]
Write to static field org.apache.oozie.sla.service.SLAService.slaEnabled
from instance method org.apache.oozie.sla.service.SLAService.destroy(): In
SLAService.java
Write to static field org.apache.oozie.sla.service.SLAService.LOG from
instance method org.apache.oozie.sla.service.SLAService.init(Services): At
SLAService.java:[line 96]
Write to static field org.apache.oozie.sla.service.SLAService.calcImpl from
instance method org.apache.oozie.sla.service.SLAService.init(Services): At
SLAService.java:[line 74]
Write to static field org.apache.oozie.sla.service.SLAService.slaEnabled
from instance method org.apache.oozie.sla.service.SLAService.init(Services): At
SLAService.java:[line 67]
Should org.apache.oozie.sla.service.SLAService$SLAWorker be a _static_
inner class?: At SLAService.java:[line 85]
Dead store to schema in new org.apache.oozie.store.WorkflowStore(boolean):
At SLAService.java:[lines 121-136]
Dead store to oq in org.apache.oozie.store.WorkflowStore$11.call(): At
WorkflowStore.java:[line 91]
Dead store to actions in org.apache.oozie.store.WorkflowStore$13.call(): At
WorkflowStore.java:[line 378]
Possible null pointer dereference of q in
org.apache.oozie.store.WorkflowStore$15.call(): At WorkflowStore.java:[line 434]
Null value at WorkflowStore.java:[line 642]: Dereferenced at
WorkflowStore.java:[line 672]
Possible null pointer dereference of qTotal in
org.apache.oozie.store.WorkflowStore$15.call(): Known null at
WorkflowStore.java:[line 651]
Null value at WorkflowStore.java:[line 643]: Dereferenced at
WorkflowStore.java:[line 681]
org.apache.oozie.util.AuthUrlClient.getQueryParamString(Map) makes
inefficient use of keySet iterator instead of entrySet iterator: Known null at
WorkflowStore.java:[line 651]
Found reliance on default encoding in
org.apache.oozie.util.AuthUrlClient$1.run(): new
java.io.InputStreamReader(InputStream): At AuthUrlClient.java:[line 153]
org.apache.oozie.util.ConfigUtils.BOOLEAN_DEFAULT isn't final but should
be: At AuthUrlClient.java:[line 135]
org.apache.oozie.util.ConfigUtils.FLOAT_DEFAULT isn't final but should be:
At ConfigUtils.java:[line 36]
org.apache.oozie.util.ConfigUtils.INT_DEFAULT isn't final but should be: At
ConfigUtils.java:[line 39]
org.apache.oozie.util.ConfigUtils.LONG_DEFAULT isn't final but should be:
At ConfigUtils.java:[line 38]
org.apache.oozie.util.ConfigUtils.STRING_DEFAULT isn't final but should be:
At ConfigUtils.java:[line 40]
Load of known null value in
org.apache.oozie.util.DateUtils.getTimeZone(String): At ConfigUtils.java:[line
37]
Redundant nullcheck of d, which is known to be non-null in
org.apache.oozie.util.DateUtils.parseDateOozieTZ(String): At
DateUtils.java:[line 140]
org.apache.oozie.util.GraphGenerator.finalize() is public; should be
protected: Redundant null check at DateUtils.java:[line 177]
Unread field: org.apache.oozie.util.GraphGenerator.actionsLimit; should
this field be static?: At GraphGenerator.java:[line 95]
Switch statement found in
org.apache.oozie.util.GraphGenerator$XMLParser.endDocument() where default case
is missing: At GraphGenerator.java:[line 62]
Found reliance on default encoding in
org.apache.oozie.util.IOUtils.getResourceAsReader(String, int): new
java.io.InputStreamReader(InputStream): At GraphGenerator.java:[lines 160-165]
Found reliance on default encoding in
org.apache.oozie.util.IOUtils.getResourceAsString(String, int): new
java.io.InputStreamReader(InputStream): At IOUtils.java:[line 119]
org.apache.oozie.util.IOUtils.zipDir(File, String, ZipOutputStream,
boolean) may fail to clean up java.io.InputStream on checked exception: At
IOUtils.java:[line 136]
Path continues at IOUtils.java:[line 210]: Obligation to clean up resource
created at IOUtils.java:[line 209] is not discharged
Integral division result cast to double or float in
org.apache.oozie.util.Instrumentation$Timer.evalStdDev(long, long, long): Path
continues at IOUtils.java:[line 211]
Found reliance on default encoding in
org.apache.oozie.util.MultiFileReader.openNextReader(): new
java.io.FileReader(File): At Instrumentation.java:[line 437]
Found reliance on default encoding in
org.apache.oozie.util.MultiFileReader.openNextReader(): new
java.io.InputStreamReader(InputStream): At MultiFileReader.java:[line 86]
Exceptional return value of java.io.File.delete() ignored in
org.apache.oozie.util.OozieRollingPolicy.deleteOldFiles(): At
MultiFileReader.java:[line 82]
org.apache.oozie.util.OozieRollingPolicy$FileInfo defines
compareTo(OozieRollingPolicy$FileInfo) and uses Object.equals(): At
OozieRollingPolicy.java:[line 162]
Should org.apache.oozie.util.OozieRollingPolicy$FileInfo be a _static_
inner class?: At OozieRollingPolicy.java:[lines 203-211]
key must be nonnull but is marked as nullable: At
OozieRollingPolicy.java:[lines 184-211]
value must be nonnull but is marked as nullable: At
PasswordMasker.java:[lines 74-85]
org.apache.oozie.util.PriorityDelayQueue$QueueElement defines
compareTo(Object) and uses Object.equals(): At PasswordMasker.java:[lines 74-85]
Dead store to conf in
org.apache.oozie.util.StatusUtils.isV1CoordjobKillable(CoordinatorJobBean): At
PriorityDelayQueue.java:[line 63]
Load of known null value in
org.apache.oozie.util.StringSerializationUtil.writeString(DataOutput, String):
At StatusUtils.java:[line 134]
Found reliance on default encoding in
org.apache.oozie.util.XConfiguration.toXmlString(boolean): new String(byte[]):
At StringSerializationUtil.java:[line 48]
org.apache.oozie.util.XLogFilter.getEndDate() may expose internal
representation by returning XLogFilter.endDate: At XConfiguration.java:[line
368]
org.apache.oozie.util.XLogFilter.getStartDate() may expose internal
representation by returning XLogFilter.startDate: At XLogFilter.java:[line 207]
org.apache.oozie.util.XLogFilter.MAX_ACTIONLIST_SCAN_DURATION isn't final
but should be: At XLogFilter.java:[line 219]
org.apache.oozie.util.XLogFilter.MAX_SCAN_DURATION isn't final but should
be: At XLogFilter.java:[line 43]
org.apache.oozie.util.XLogStreamer$FileInfo defines
compareTo(XLogStreamer$FileInfo) and uses Object.equals(): At
XLogFilter.java:[line 44]
Should org.apache.oozie.util.XLogStreamer$FileInfo be a _static_ inner
class?: At XLogStreamer.java:[lines 139-147]
org.apache.oozie.util.XLogUserFilterParam.getEndDate() may expose internal
representation by returning XLogUserFilterParam.endTime: At
XLogStreamer.java:[lines 121-147]
org.apache.oozie.util.XLogUserFilterParam.getEndTime() may expose internal
representation by returning XLogUserFilterParam.endTime: At
XLogUserFilterParam.java:[line 183]
org.apache.oozie.util.XLogUserFilterParam.getStartDate() may expose
internal representation by returning XLogUserFilterParam.startTime: At
XLogUserFilterParam.java:[line 251]
Found reliance on default encoding in
org.apache.oozie.util.XmlUtils.validateXml(Schema, String): String.getBytes():
At XLogUserFilterParam.java:[line 174]
Should org.apache.oozie.util.ZKUtils$ZKMetadataKeys be a _static_ inner
class?: At XmlUtils.java:[line 284]
Result of integer multiplication cast to long in
org.apache.oozie.util.db.SLADbOperations.createSlaRegistrationEvent(Element,
String, SLAEvent$SlaAppType, String, String, XLog): At ZKUtils.java:[line 389]
Another occurrence at SLADbOperations.java:[line 148]: At
SLADbOperations.java:[line 131]
At SLADbOperations.java:[line 63]: Result of integer multiplication cast to
long in
org.apache.oozie.util.db.SLADbOperations.createSlaRegistrationEvent(Element,
Store, String, SLAEvent$SlaAppType, String, String)
Result of integer multiplication cast to long in
org.apache.oozie.util.db.SLADbXOperations.createSlaRegistrationEvent(Element,
String, SLAEvent$SlaAppType, String, String): Another occurrence at
SLADbOperations.java:[line 80]
Another occurrence at SLADbXOperations.java:[line 89]: At
SLADbXOperations.java:[line 71]
At SqlStatement.java:[line 897]: Dead store to stmt in
org.apache.oozie.util.db.SqlStatement.prepareForBatch(Connection, List,
PreparedStatement)
Dereferenced at SqlStatement.java:[line 971]: Possible null pointer
dereference of retVal in org.apache.oozie.util.db.SqlStatement.create(ArrayList)
Known null at SqlStatement.java:[line 965]: Null value at
SqlStatement.java:[line 952]
Obligation to clean up resource created at SqlStatement.java:[line 842] is
not discharged:
org.apache.oozie.util.db.SqlStatement.prepareAndSetValues(Connection) may fail
to clean up java.sql.Statement on checked exception
Path continues at SqlStatement.java:[line 844]: Path continues at
SqlStatement.java:[line 843]
org.apache.oozie.util.db.SqlStatement$ResultSetReader.getByteArray(Schema$Column)
may fail to close stream: Path continues at SqlStatement.java:[line 845]
Unwritten field:
org.apache.oozie.util.db.ValidateConnectionBean.pcPCSuperclass: At
SqlStatement.java:[line 116]
org.apache.oozie.workflow.lite.LiteWorkflowApp defines
equals(LiteWorkflowApp) method and uses Object.equals(Object): In
ValidateConnectionBean.java
Should
org.apache.oozie.workflow.lite.LiteWorkflowAppParser$GlobalSectionData be a
_static_ inner class?: At LiteWorkflowApp.java:[line 58]
Inconsistent synchronization of
org.apache.oozie.workflow.lite.LiteWorkflowInstance.log; locked 86% of time: At
LiteWorkflowAppParser.java:[lines 368-413]
Unsynchronized access at LiteWorkflowInstance.java:[line 324]:
Unsynchronized access at LiteWorkflowInstance.java:[line 543]
Synchronized access at LiteWorkflowInstance.java:[line 472]: Unsynchronized
access at LiteWorkflowInstance.java:[line 329]
Synchronized access at LiteWorkflowInstance.java:[line 381]: Synchronized
access at LiteWorkflowInstance.java:[line 173]
Synchronized access at LiteWorkflowInstance.java:[line 194]: Synchronized
access at LiteWorkflowInstance.java:[line 190]
Synchronized access at LiteWorkflowInstance.java:[line 299]: Synchronized
access at LiteWorkflowInstance.java:[line 202]
Synchronized access at LiteWorkflowInstance.java:[line 221]: Synchronized
access at LiteWorkflowInstance.java:[line 306]
Synchronized access at LiteWorkflowInstance.java:[line 255]: Synchronized
access at LiteWorkflowInstance.java:[line 252]
Synchronized access at LiteWorkflowInstance.java:[line 265]: Synchronized
access at LiteWorkflowInstance.java:[line 258]
Synchronized access at LiteWorkflowInstance.java:[line 493]: Synchronized
access at LiteWorkflowInstance.java:[line 449]
Synchronized access at LiteWorkflowInstance.java:[line 360]: Synchronized
access at LiteWorkflowInstance.java:[line 357]
Synchronized access at LiteWorkflowInstance.java:[line 348]: Synchronized
access at LiteWorkflowInstance.java:[line 341]
Inconsistent synchronization of
org.apache.oozie.workflow.lite.LiteWorkflowInstance.status; locked 81% of time:
Synchronized access at LiteWorkflowInstance.java:[line 369]
Unsynchronized access at LiteWorkflowInstance.java:[line 547]:
Unsynchronized access at LiteWorkflowInstance.java:[line 568]
Unsynchronized access at LiteWorkflowInstance.java:[line 595]:
Unsynchronized access at LiteWorkflowInstance.java:[line 551]
Unsynchronized access at LiteWorkflowInstance.java:[line 427]:
Unsynchronized access at LiteWorkflowInstance.java:[line 374]
Synchronized access at LiteWorkflowInstance.java:[line 174]: Synchronized
access at LiteWorkflowInstance.java:[line 170]
Synchronized access at LiteWorkflowInstance.java:[line 382]: Synchronized
access at LiteWorkflowInstance.java:[line 378]
Synchronized access at LiteWorkflowInstance.java:[line 198]: Synchronized
access at LiteWorkflowInstance.java:[line 185]
Synchronized access at LiteWorkflowInstance.java:[line 206]: Synchronized
access at LiteWorkflowInstance.java:[line 193]
Synchronized access at LiteWorkflowInstance.java:[line 201]: Synchronized
access at LiteWorkflowInstance.java:[line 296]
Synchronized access at LiteWorkflowInstance.java:[line 297]: Synchronized
access at LiteWorkflowInstance.java:[line 312]
Synchronized access at LiteWorkflowInstance.java:[line 218]: Synchronized
access at LiteWorkflowInstance.java:[line 298]
Synchronized access at LiteWorkflowInstance.java:[line 299]: Synchronized
access at LiteWorkflowInstance.java:[line 246]
Synchronized access at LiteWorkflowInstance.java:[line 251]: Synchronized
access at LiteWorkflowInstance.java:[line 306]
Synchronized access at LiteWorkflowInstance.java:[line 254]: Synchronized
access at LiteWorkflowInstance.java:[line 221]
Synchronized access at LiteWorkflowInstance.java:[line 354]: Synchronized
access at LiteWorkflowInstance.java:[line 257]
Synchronized access at LiteWorkflowInstance.java:[line 336]: Synchronized
access at LiteWorkflowInstance.java:[line 362]
Synchronized access at LiteWorkflowInstance.java:[line 366]: Synchronized
access at LiteWorkflowInstance.java:[line 350]
Should org.apache.oozie.workflow.lite.LiteWorkflowValidator$ForkJoinCount
be a _static_ inner class?: Synchronized access at
LiteWorkflowInstance.java:[line 370]
org.apache.oozie.workflow.lite.NodeDef defines equals(NodeDef) method and
uses Object.equals(Object): At LiteWorkflowValidator.java:[lines 347-349]
At NodeDef.java:[line 81]
+1 There are no new bugs found in [core].
+1 There are no new bugs found in [docs].
-1 There are [19] new bugs found below threshold in
[hadooplibs/hadoop-utils-2] that must be fixed.
You can find the FindBugs diff here (look for the red and orange ones):
hadooplibs/hadoop-utils-2/findbugs-new.html
The most important FindBugs errors are:
At LauncherMain.java:[line 69]: Found reliance on default encoding in
org.apache.oozie.action.hadoop.LauncherMain.getHadoopJobIds(String, Pattern[]):
new java.io.FileReader(String)
At LauncherMain.java:[line 99]: Found reliance on default encoding in
org.apache.oozie.action.hadoop.LauncherMain.writeExternalChildIDs(String,
Pattern[], String): String.getBytes()
At LauncherMain.java:[line 55]:
org.apache.oozie.action.hadoop.LauncherMain.HADOOP_SITE_FILES should be both
final and package protected
At LauncherMain.java:[line 266]: Exceptional return value of
java.io.File.mkdirs() ignored in
org.apache.oozie.action.hadoop.LauncherMain.writeHadoopConfig(String, File)
At LauncherMapper.java:[line 407]: Found reliance on default encoding in
org.apache.oozie.action.hadoop.LauncherMapper.getLocalFileContentStr(File,
String, int): new java.io.FileReader(File)
At LauncherMapper.java:[line 355]: Found reliance on default encoding in
org.apache.oozie.action.hadoop.LauncherMapper.propagateToHadoopConf(): new
java.io.FileWriter(String)
At LauncherMapper.java:[line 356]: Found reliance on default encoding in
org.apache.oozie.action.hadoop.LauncherMapper.propagateToHadoopConf(): new
java.io.OutputStreamWriter(OutputStream)
At LauncherMapper.java:[line 105]: Found reliance on default encoding in
org.apache.oozie.action.hadoop.LauncherMapper.setRecoveryId(Configuration,
Path, String): new java.io.InputStreamReader(InputStream)
At LauncherMapper.java:[line 95]: Found reliance on default encoding in
org.apache.oozie.action.hadoop.LauncherMapper.setRecoveryId(Configuration,
Path, String): new java.io.OutputStreamWriter(OutputStream)
Obligation to clean up resource created at LauncherMapper.java:[line 407]
is not discharged:
org.apache.oozie.action.hadoop.LauncherMapper.getLocalFileContentStr(File,
String, int) may fail to clean up java.io.Reader on checked exception
Path continues at LauncherMapper.java:[line 410]: Path continues at
LauncherMapper.java:[line 408]
org.apache.oozie.action.hadoop.LauncherMapper.propagateToHadoopConf() may
fail to clean up java.io.Writer on checked exception: Path continues at
LauncherMapper.java:[line 411]
Write to static field
org.apache.oozie.action.hadoop.LauncherSecurityManager.exitCode from instance
method org.apache.oozie.action.hadoop.LauncherSecurityManager.checkExit(int):
Obligation to clean up resource created at LauncherMapper.java:[line 355] is
not discharged
Write to static field
org.apache.oozie.action.hadoop.LauncherSecurityManager.exitInvoked from
instance method
org.apache.oozie.action.hadoop.LauncherSecurityManager.checkExit(int): At
LauncherMapper.java:[line 679]
Found reliance on default encoding in
org.apache.oozie.action.hadoop.MapReduceMain.writeJobIdFile(File, String):
String.getBytes(): At LauncherMapper.java:[line 678]
org.apache.oozie.action.hadoop.MapReduceMain.writeJobIdFile(File, String)
may fail to clean up java.io.OutputStream on checked exception: At
MapReduceMain.java:[line 76]
Path continues at MapReduceMain.java:[line 76]: Obligation to clean up
resource created at MapReduceMain.java:[line 75] is not discharged
At ShellMain.java:[line 228]: Found reliance on default encoding in
org.apache.oozie.action.hadoop.ShellMain.handleShellOutput(Process, boolean):
new java.io.InputStreamReader(InputStream)
Found reliance on default encoding in
org.apache.oozie.action.hadoop.ShellMain.writeLoggerProperties(Configuration,
File): new java.io.PrintWriter(OutputStream): Another occurrence at
ShellMain.java:[line 229]
Found reliance on default encoding in
org.apache.oozie.action.hadoop.ShellMain$OutputWriteThread.run(): new
java.io.FileWriter(File): At ShellMain.java:[line 172]
Should org.apache.oozie.action.hadoop.ShellMain$OutputWriteThread be a
_static_ inner class?: At ShellMain.java:[line 265]
At ShellMain.java:[lines 247-305]
+1 There are no new bugs found in [tools].
+1 BACKWARDS_COMPATIBILITY
+1 the patch does not change any JPA Entity/Colum/Basic/Lob/Transient
annotations
+1 the patch does not modify JPA files
+1 TESTS
Tests run: 1868
+1 DISTRO
+1 distro tarball builds with the patch
----------------------------
-1 Overall result, please check the reported -1(s)
The full output of the test-patch run is available at
https://builds.apache.org/job/oozie-trunk-precommit-build/3605/
Adding comment to JIRA
Comment added.
test-patch exit code: 1
Build step 'Execute shell' marked build as failure
Archiving artifacts
Compressed 1.77 MB of artifacts by 17.7% relative to #3598
Recording test results