> On Feb. 1, 2017, 1:02 a.m., Purshotam Shah wrote:
> > core/src/main/java/org/apache/oozie/command/coord/CoordCommandUtils.java,
> > line 410
> > <https://reviews.apache.org/r/56158/diff/3/?file=1621110#file1621110line410>
> >
> > End of functions calculation should not include initial instance
> > calculation.
> > It's purely on nominal time. Endof functions at dataset frequency and
> > at datasets instance should return the same value.
I am using dataset initial instance to get the hour:minute of it. Otherwise we
might end up with the extra instances if nominal time is not in phase with the
dataset time.
Consider a dataset with initial instance -
<dataset name='test' frequency='30' initial-instance='2009-08-01T00:06Z'
timezone='UTC' freq_timeunit='MINUTE' end_of_duration='NONE'>
...
<start-instance>${coord:endOfDays(0)}</start-instance>
<end-instance>${coord:current(0)}</end-instance>
And nominal time of 2009-08-20T18:00Z. The instances should start anytime after
(endOfDays(0)), 2009-08-20T00:00Z. But without above adjustment, it calculates
one instance from previous day 2009-08-19.
To solve this problem
1. Either, we have to ask users to make their timings in phase to avoid extra
instance. In this case, we don't need amend patch.
2. Or, we can look at dataset initial instance hour:minute, and adjust the time.
- Satish
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56158/#review163796
-----------------------------------------------------------
On Feb. 1, 2017, 12:44 a.m., Satish Saley wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56158/
> -----------------------------------------------------------
>
> (Updated Feb. 1, 2017, 12:44 a.m.)
>
>
> Review request for oozie.
>
>
> Bugs: OOZIE-2630
> https://issues.apache.org/jira/browse/OOZIE-2630
>
>
> Repository: oozie-git
>
>
> Description
> -------
>
> [OOZIE-2630] Amend patch for OOZIE-2630
>
>
> Diffs
> -----
>
> core/src/main/java/org/apache/oozie/command/coord/CoordCommandUtils.java
> 3a7a930
> core/src/main/java/org/apache/oozie/coord/CoordELFunctions.java bc18f4d
>
> core/src/test/java/org/apache/oozie/command/coord/TestCoordCommandUtils.java
> 22d1f61
> core/src/test/resources/coord-dataset-endOfDays.xml 6aa3f00
> core/src/test/resources/coord-dataset-endOfMonths.xml 0ea5cac
> core/src/test/resources/coord-dataset-endOfWeeks.xml 7879bf4
>
> Diff: https://reviews.apache.org/r/56158/diff/
>
>
> Testing
> -------
>
> Tested locally
>
>
> Thanks,
>
> Satish Saley
>
>
