> On March 4, 2017, 7:06 a.m., Peter Cseh wrote: > > core/src/main/resources/oozie-default.xml > > Lines 2884-2891 (original), 2884-2892 (patched) > > <https://reviews.apache.org/r/57305/diff/1/?file=1655694#file1655694line2884> > > > > Should I remove this property instead of adding this comment? We can > > still check it's value in SparkConfigurationService.
I would leave it. I think it will be confusing to users if we remove it from here, and it's suddenly an undocumented property. - Robert ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57305/#review167932 ----------------------------------------------------------- On March 5, 2017, 9:53 p.m., Peter Cseh wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57305/ > ----------------------------------------------------------- > > (Updated March 5, 2017, 9:53 p.m.) > > > Review request for oozie. > > > Bugs: OOZIE-2811 > https://issues.apache.org/jira/browse/OOZIE-2811 > > > Repository: oozie-git > > > Description > ------- > > OOZIE-2811 > Add support for filtering out properties from SparkConfigurationService > > > Diffs > ----- > > core/src/main/java/org/apache/oozie/action/hadoop/SparkActionExecutor.java > e2e023e6d9a14fa1feb8abb2028dfbd67a163090 > core/src/main/java/org/apache/oozie/service/SparkConfigurationService.java > b29ab8d80b7d900603b4697e54a03365fc2e8634 > core/src/main/resources/oozie-default.xml > 95e0c36e1b2f5aef18637f6f956a990ba36166f2 > > core/src/test/java/org/apache/oozie/service/TestSparkConfigurationService.java > 9d82fdc1a75be5c17da36f1cc2189246e2be0859 > > > Diff: https://reviews.apache.org/r/57305/diff/3/ > > > Testing > ------- > > Existing tests passed and added some more. > > > Thanks, > > Peter Cseh > >
