[
https://issues.apache.org/jira/browse/OOZIE-2816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15928178#comment-15928178
]
Peter Cseh commented on OOZIE-2816:
-----------------------------------
Good catch, I've missed the <arg> part also...
This solution contains duplicated code-like parts, but with different type of
lists. Can you create a method like {{removeSqoopCommandIfPresent}} and call
that in both cases? It would need some refactoring, but having the removal
logic at one place would be nice. Maybe we could create a List<String> from the
List<Element> before processing it further.
> Strip out the first command word from Sqoop action if its "sqoop"
> -----------------------------------------------------------------
>
> Key: OOZIE-2816
> URL: https://issues.apache.org/jira/browse/OOZIE-2816
> Project: Oozie
> Issue Type: Bug
> Components: action
> Affects Versions: 4.3.0
> Reporter: Harsh J
> Assignee: Harsh J
> Priority: Trivial
> Attachments: OOZIE-2816.000.patch, OOZIE-2816.001.patch,
> OOZIE-2816.002.patch
>
>
> A [sorta
> popular|https://www.google.com/search?q=%22No+such+sqoop+tool:+sqoop%22+oozie&*]
> user error is to specify the command part of the sqoop action in the style
> of the CLI: "sqoop import …" instead of just the required "import …". This
> causes the Sqoop action to predictably fail with:
> {code}
> No such sqoop tool: sqoop. See 'sqoop help'.
> Intercepting System.exit(1)
> {code}
> A simple enhancement can prevent this burden on user. We can skip the first
> command token if its "sqoop".
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
