[ 
https://issues.apache.org/jira/browse/OOZIE-2701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15940232#comment-15940232
 ] 

Peter Cseh edited comment on OOZIE-2701 at 3/24/17 12:25 PM:
-------------------------------------------------------------

We should make sure that the regex in the {{oozie-default.xml}} and in 
{{TestHCatURIParser}} are the same.
They are not quite the same in patch-07.
This is the one in {{oozie-default.xml}} and in the test after removing the 
escaping characters:
{noformat}
([a-z]+://[\w\.\-]+:\d+[,]*)+/\w+/\w+[/\w+=;\-]*
([a-z]+://[\w\.\-]+:\d+[,]*)+/\w+/\w+/[\w+=;\-]*
{noformat}
Notice the extra "/" before the last pair of brackets. [~abhishekbafna], could 
you check which one is correct?
Also, I think moving the test to core would worth it to ensure the tested regex 
is the same everywhere.



was (Author: gezapeti):
We should make sure that the regex in the {{oozie-default.xml}} and in 
{{TestHCatURIParser}} are the same.
They are not quite the same in patch-07.
This is the one in {{oozie-default.xml}} and in the test after removing the 
escaping characters:
([a-z]+://[\w\.\-]+:\d+[,]*)+/\w+/\w+[/\w+=;\-]*
([a-z]+://[\w\.\-]+:\d+[,]*)+/\w+/\w+/[\w+=;\-]*

Notice the extra "/" before the last pair of brackets. [~abhishekbafna], could 
you check which one is correct?
Also, I think moving the test to core would worth it to ensure the tested regex 
is the same everywhere.


> Oozie to support Multiple HCatalog URIs
> ---------------------------------------
>
>                 Key: OOZIE-2701
>                 URL: https://issues.apache.org/jira/browse/OOZIE-2701
>             Project: Oozie
>          Issue Type: New Feature
>          Components: core
>            Reporter: Abhishek Bafna
>            Assignee: Abhishek Bafna
>             Fix For: 5.0.0
>
>         Attachments: OOZIE-2701-00.patch, OOZIE-2701-01.patch, 
> OOZIE-2701-02.patch, OOZIE-2701-03.patch, OOZIE-2701-04.patch, 
> OOZIE-2701-05.patch, OOZIE-2701-06.patch, OOZIE-2701-07.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to