----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54705/#review170061 -----------------------------------------------------------
Reviews for Pages 1-3 except JavaActionExecutor Note: On a time crunch and doing review of couple of pages at a time to avoid postponing this for too long. Have also not had time to go through history of previous review comments from others. So there might be duplicates. core/src/main/java/org/apache/oozie/action/hadoop/CredentialsProviderFactory.java Lines 34 (patched) <https://reviews.apache.org/r/54705/#comment242833> If you are calling this a factory, you should look into removing the constructor by type and making it a true Factory. Cache the credential type and the corresponding Class. createCredentialsProvider() will then become createCredentialsProvider(String type) which will just look up the cache and return a new instance of the Class. Parsing ConfigurationService.getStrings(CRED_KEY) and loading the class everytime is a lot of waste. core/src/main/java/org/apache/oozie/action/hadoop/LauncherMapperHelper.java Lines 54 (patched) <https://reviews.apache.org/r/54705/#comment242898> You could just call it LauncherHelper. core/src/main/java/org/apache/oozie/action/hadoop/MapReduceActionExecutor.java Lines 319 (patched) <https://reviews.apache.org/r/54705/#comment242899> Typo. original core/src/main/java/org/apache/oozie/action/hadoop/MapReduceActionExecutor.java Lines 370 (patched) <https://reviews.apache.org/r/54705/#comment242900> Remove this warn and add e to the next warning logging. core/src/main/java/org/apache/oozie/action/hadoop/MapReduceActionExecutor.java Lines 406-407 (patched) <https://reviews.apache.org/r/54705/#comment242902> 1) Can we kill directly if externalChild id is not empty (MR job already launched) else call LauncherMainHadoopUtils.killChildYarnJobs? If it is empty we have to call killChildYarnJobs as the launcher AM could have just launched the mapreduce job before kill reached it. 2) Why are we duplicating the killChildYarnJobs code here? core/src/main/java/org/apache/oozie/action/hadoop/SparkActionExecutor.java Lines 112-114 (original) <https://reviews.apache.org/r/54705/#comment242903> You can't remove this. Will breaking existing users. Since it starts with oozie.launcher, config deprecation will not handle it. Basically any oozie.launcher hadoop 1.x settings cannot be removed because of that. core/src/main/java/org/apache/oozie/action/hadoop/SqoopActionExecutor.java Line 89 (original), 87 (patched) <https://reviews.apache.org/r/54705/#comment242904> Revert back to old code. Just remove the final instead of creating another temporary list. core/src/main/java/org/apache/oozie/action/hadoop/SqoopActionExecutor.java Lines 109-111 (original) <https://reviews.apache.org/r/54705/#comment242905> Why is this condition not necessary any more? core/src/main/java/org/apache/oozie/action/ssh/SshActionExecutor.java Line 69 (original), 69 (patched) <https://reviews.apache.org/r/54705/#comment242906> Revert. UNKNOWN_ERROR is correct core/src/main/java/org/apache/oozie/command/PurgeXCommand.java Line 410 (original), 410 (patched) <https://reviews.apache.org/r/54705/#comment242907> Why remove entity key? core/src/main/java/org/apache/oozie/command/PurgeXCommand.java Line 418 (original), 418 (patched) <https://reviews.apache.org/r/54705/#comment242908> Why is lock not required anymore? core/src/main/java/org/apache/oozie/dependency/HCatURIHandler.java Line 182 (original) <https://reviews.apache.org/r/54705/#comment242835> Why is support for dropping table being removed? core/src/main/java/org/apache/oozie/dependency/HCatURIHandler.java Line 345 (original) <https://reviews.apache.org/r/54705/#comment242836> Why is support for checking exists on a table being removed? core/src/main/java/org/apache/oozie/service/HadoopAccessorService.java Lines 776-777 (patched) <https://reviews.apache.org/r/54705/#comment242893> This is going to fill up the temp disk space pretty quickly. Please avoid creating the local file and write directly to the FSDataOutputStream after creating the file in HDFS. core/src/main/java/org/apache/oozie/service/Services.java Lines 308-309 (patched) <https://reviews.apache.org/r/54705/#comment242894> log.fatal("Runtime Exception during Services Load. Check your list of '{0}' or '{1}'", CONF_SERVICE_CLASSES, CONF_SERVICE_EXT_CLASSES, rex); core/src/main/java/org/apache/oozie/servlet/BaseAdminServlet.java Lines 86-87 (original), 71 (patched) <https://reviews.apache.org/r/54705/#comment242895> You should retain the code of checking the resource name and throwing error here which is currently commented out instead of doing it in setOozieMode() core/src/main/java/org/apache/oozie/servlet/JVMInfo.java Line 123 (original), 123 (patched) <https://reviews.apache.org/r/54705/#comment242896> Revert. The original spelling of Daemon is correct. core/src/main/java/org/apache/oozie/sla/listener/SLAEmailEventListener.java Line 386 (original), 386 (patched) <https://reviews.apache.org/r/54705/#comment242897> Revert. threw exception is correct. - Rohini Palaniswamy On March 22, 2017, 8:34 p.m., Peter Cseh wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54705/ > ----------------------------------------------------------- > > (Updated March 22, 2017, 8:34 p.m.) > > > Review request for oozie, Purshotam Shah, Robert Kanter, and Rohini > Palaniswamy. > > > Bugs: OOZIE-1779 > https://issues.apache.org/jira/browse/OOZIE-1779 > > > Repository: oozie-git > > > Description > ------- > > Replacing the launcher MR job with a launcher AM > > > Diffs > ----- > > bin/test-patch-20-tests 22f472c07e80fdb38c632329a5707998ab352172 > client/pom.xml f99366c90887a5a45f3942291c90e1cdbfd84b3f > client/src/main/java/org/apache/oozie/cli/OozieCLI.java > 38fb84e8a8918aee6ae57d19a29cdf181aba1955 > client/src/main/java/org/apache/oozie/cli/ValidationUtil.java > b1da2af070970add01031d6208a395520cd7055c > client/src/main/java/org/apache/oozie/client/OozieClient.java > 73708080e624e775f7d058cd3377ad69d8399264 > client/src/main/java/org/apache/oozie/client/XOozieClient.java > 8538ec7c742cc013f7c18eaff3ecf61c2835cc8a > client/src/main/java/org/apache/oozie/client/rest/JsonTags.java > ca168e084998b5dd564536078a7a69efd7291828 > client/src/main/java/org/apache/oozie/client/rest/RestConstants.java > 8ddb1f873f0c69aadf5f4a5161d8b21f7392fa1e > core/pom.xml 1dd104581ccab7976d788b674d2200e48a70c27f > core/src/main/java/org/apache/oozie/WorkflowJobBean.java > 55d79a5d5e5e4efab9eb832e9341a16bcf8959cc > core/src/main/java/org/apache/oozie/action/ActionExecutor.java > 1d6456b236bf9e27c0f55d9f9e3b4bd94517c797 > core/src/main/java/org/apache/oozie/action/hadoop/Credentials.java > eadb47b07d157f45f086517ab41c4b9826f003f0 > core/src/main/java/org/apache/oozie/action/hadoop/CredentialsProvider.java > 6fe22fbd2fca5d873d58ece60f20d0f131371475 > > core/src/main/java/org/apache/oozie/action/hadoop/CredentialsProviderFactory.java > PRE-CREATION > core/src/main/java/org/apache/oozie/action/hadoop/DistcpActionExecutor.java > 78cd257a836707c1efeac13566d6285d42970545 > core/src/main/java/org/apache/oozie/action/hadoop/FsActionExecutor.java > 27654741101d2056b25626fbbe345183eafd612d > core/src/main/java/org/apache/oozie/action/hadoop/FsELFunctions.java > 801bfe6eb212b549888f0e9fb7df7b65bcf59393 > core/src/main/java/org/apache/oozie/action/hadoop/HCatCredentialHelper.java > 36ad1df727e869b8051481ad969771e91bc6ae07 > core/src/main/java/org/apache/oozie/action/hadoop/HCatCredentials.java > d7689a924059e553abaeed374eed4072933292cb > core/src/main/java/org/apache/oozie/action/hadoop/HadoopELFunctions.java > ad2a71d641caa71efc098ad00bfbab3cec4d9506 > core/src/main/java/org/apache/oozie/action/hadoop/HbaseCredentials.java > 307f565786ad77f5a35b5790bd5b052b04c6eac8 > core/src/main/java/org/apache/oozie/action/hadoop/Hive2ActionExecutor.java > 2aed936af75da38c433be5d202bdc01c2f612c76 > core/src/main/java/org/apache/oozie/action/hadoop/Hive2Credentials.java > bd2f1f768c5b04bef4a33613baede9202144c747 > core/src/main/java/org/apache/oozie/action/hadoop/HiveActionExecutor.java > 8e2453ef4f78f4a5f1f95b1ca2793f5d7e07ad81 > core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java > 39daca7b3050c259a36d54710b4c1279f3acdeac > core/src/main/java/org/apache/oozie/action/hadoop/LauncherMapperHelper.java > 9609fdc2f3440fb176b659ef16c2a23451724cf9 > > core/src/main/java/org/apache/oozie/action/hadoop/MapReduceActionExecutor.java > 55c937249ac35e14bd63dd0c1fa962ea636afa3a > core/src/main/java/org/apache/oozie/action/hadoop/OozieJobInfo.java > 581d3b3219eff882f961c8e495611e873c6a5a52 > core/src/main/java/org/apache/oozie/action/hadoop/PigActionExecutor.java > 8b2dc16db80ad602911f1f64e60cfad41b198922 > > core/src/main/java/org/apache/oozie/action/hadoop/ScriptLanguageActionExecutor.java > 92e149d5cac6509893c8507b776263a38312a53b > core/src/main/java/org/apache/oozie/action/hadoop/ShellActionExecutor.java > b9ffa7ab7ec87db8a76a3653c74974d296c8cd17 > core/src/main/java/org/apache/oozie/action/hadoop/SparkActionExecutor.java > 1a3197abb52f80b545dcc8634a8cac7a281a9eac > core/src/main/java/org/apache/oozie/action/hadoop/SqoopActionExecutor.java > 22e28746a9a39ae6c1e22326cc4f8f759d820b20 > core/src/main/java/org/apache/oozie/action/ssh/SshActionExecutor.java > 5fd30f7858c5c4c70dcbdb6df86904518d92f7f3 > core/src/main/java/org/apache/oozie/client/rest/BulkResponseImpl.java > fb021bd022d199f93fc5674843514abf45ae12a5 > core/src/main/java/org/apache/oozie/command/PurgeXCommand.java > 2ba1999ba7d5e892bd7e37d5fd8d1f926a84b48b > core/src/main/java/org/apache/oozie/command/XCommand.java > bdf13f65ea25e8e0f5125e2798568a2c03fffe81 > core/src/main/java/org/apache/oozie/command/wf/SubmitHttpXCommand.java > d2a2742ae418070a1cd0a889f14194224bc944a6 > core/src/main/java/org/apache/oozie/command/wf/SubmitMRXCommand.java > cc61d3de813c75c7f1cf4d405fc043253e3ca4ea > > core/src/main/java/org/apache/oozie/command/wf/SubmitScriptLanguageXCommand.java > 9d413059e99bc676feb63e02a2f704048eb4a355 > core/src/main/java/org/apache/oozie/command/wf/SubmitSqoopXCommand.java > 51b739e21c802e09f4110b740138f4ff5c341fe4 > > core/src/main/java/org/apache/oozie/coord/input/dependency/AbstractCoordInputDependency.java > ace120d10e3546201aa4145df56abf7933fb24b8 > > core/src/main/java/org/apache/oozie/coord/input/logic/CoordInputLogicEvaluatorPhaseOne.java > 52e03d9839f01e8fcbc9c0fdee179467b9ac5c98 > core/src/main/java/org/apache/oozie/dependency/HCatURIHandler.java > 4cc284ae52ac50cce36c251536f045804e351f7a > > core/src/main/java/org/apache/oozie/dependency/hcat/EhcacheHCatDependencyCache.java > 6f0abf6e094ed04158652191f2b8bb3b0cd32e90 > core/src/main/java/org/apache/oozie/service/CallableQueueService.java > a86a8d0889138cd1564ca9253e5b319ea52e55cc > core/src/main/java/org/apache/oozie/service/EventHandlerService.java > 22c6fb0965f45c5cf2322c251d4a8aa77d263458 > core/src/main/java/org/apache/oozie/service/HadoopAccessorService.java > 23a9d92bf56a625469ec247cfb9727972511b101 > core/src/main/java/org/apache/oozie/service/PurgeService.java > c2c966b2cd056b77ae52164cb3f40955e98ae69a > core/src/main/java/org/apache/oozie/service/Services.java > 829d5f5cd90c86e6cba9854dc0b4b7df570b8900 > core/src/main/java/org/apache/oozie/service/ShareLibService.java > b79bd37bb2b44348f220128334497d788dd922d4 > core/src/main/java/org/apache/oozie/servlet/BaseAdminServlet.java > d263567eab9fc9b8763296c35e0a904499eabc11 > core/src/main/java/org/apache/oozie/servlet/CallbackServlet.java > 612302173e0f485345558b0c96a8a75d2f43d238 > core/src/main/java/org/apache/oozie/servlet/JVMInfo.java > bf2b01db340a014d8831c5186188741f866e6559 > core/src/main/java/org/apache/oozie/servlet/V0AdminServlet.java > d4a098949534f417938a65c27e395c9ac1f71ca7 > core/src/main/java/org/apache/oozie/servlet/V1AdminServlet.java > fc3a6bc19d6a04e489c3f65c8248478a58540ede > core/src/main/java/org/apache/oozie/sla/listener/SLAEmailEventListener.java > d08521ca28d9ae4c8582c6ce3a8e6ca35a26f8dd > core/src/main/java/org/apache/oozie/store/OozieSchema.java > 23dd1e508b6c721a10c9fe828baa5cd0d95064b4 > core/src/main/java/org/apache/oozie/util/ClasspathUtils.java PRE-CREATION > core/src/main/java/org/apache/oozie/util/IOUtils.java > a6c2fdae049d1df936a0345f5ffc6609ea40a5c0 > core/src/main/java/org/apache/oozie/util/Instrumentation.java > 45219a9238c09ff290e94121aaec46a2c7ea27ac > core/src/main/java/org/apache/oozie/util/JobUtils.java > 63f88acd6fb91668baa6cd0a80b2d45435e7b213 > core/src/main/java/org/apache/oozie/util/db/SqlStatement.java > 83b455ebc2629fddccf44b61b1051f932e1d40a3 > core/src/main/resources/META-INF/persistence.xml > edda2d5e22856b0250a53bfde7c73fd96f85c6e9 > core/src/main/resources/oozie-default.xml > 03f428a47e34f2d07ea8fff755f29d222d6aeb9a > core/src/test/java/org/apache/oozie/QueryServlet.java PRE-CREATION > core/src/test/java/org/apache/oozie/action/hadoop/CredentialForTest.java > 06298916e797890731134370412f51f3456aa70c > core/src/test/java/org/apache/oozie/action/hadoop/InsertTestToken.java > 9da8fbe18923899489c71f40c99a01fe6522e143 > core/src/test/java/org/apache/oozie/action/hadoop/LauncherMainTester.java > 4baed6e42beccd2fdb55ab1e6fb150c0d8821a9c > core/src/test/java/org/apache/oozie/action/hadoop/MapperReducerForTest.java > 8f08ddd9fa077fc9526814fd25e7477850c51737 > > core/src/test/java/org/apache/oozie/action/hadoop/TestDistCpActionExecutor.java > e8a140f330062c5ce8324112aae83b3d0ae1f772 > core/src/test/java/org/apache/oozie/action/hadoop/TestFsActionExecutor.java > 09d723ac96ad8f06e3006a7ded3d9b7f8289bb45 > core/src/test/java/org/apache/oozie/action/hadoop/TestHCatCredentials.java > e6d43ca820330a5f00cc5d82e8cfb88f3a814fb4 > > core/src/test/java/org/apache/oozie/action/hadoop/TestJavaActionExecutor.java > 1c4b4296682865f96857c1038e0b26c4877b6dc8 > core/src/test/java/org/apache/oozie/action/hadoop/TestLauncher.java > aa938d01b7273d6db273908e5480b71613598135 > > core/src/test/java/org/apache/oozie/action/hadoop/TestLauncherAMCallbackNotifier.java > PRE-CREATION > > core/src/test/java/org/apache/oozie/action/hadoop/TestLauncherHCatURIHandler.java > 4288974b036b68b42d260d674aaaa0d345484123 > > core/src/test/java/org/apache/oozie/action/hadoop/TestMapReduceActionError.java > 4cda6151ca5bb0d9007f11bfe712de74b1a0da26 > core/src/test/java/org/apache/oozie/action/hadoop/TestOozieJobInfo.java > 5bc7d00ff6c6c2d29806633761cba4a940ce512a > > core/src/test/java/org/apache/oozie/action/hadoop/TestPrepareActionsDriver.java > df9e939cb236e8b65e7b3aa9ab683c33f5fa02b7 > > core/src/test/java/org/apache/oozie/action/hadoop/TestScriptLanguageActionExecutor.java > 0adc190d56ec163d454d64ae341b6a658ac14781 > > core/src/test/java/org/apache/oozie/action/hadoop/TestShellActionExecutor.java > 1531ed994740d8d509c5429f761f4aa2e83c3227 > core/src/test/java/org/apache/oozie/action/hadoop/TestShellMain.java > e757e542cb6256906f43a36f7d30c8e8b8aa04e2 > core/src/test/java/org/apache/oozie/client/TestOozieCLI.java > 564db2a5150d949e2e9274984c1d67acce6b5447 > core/src/test/java/org/apache/oozie/client/TestWorkflowXClient.java > 51ae9e87d060c9e276ca74b45b24a5f5ae65e722 > > core/src/test/java/org/apache/oozie/command/coord/TestCoordChangeXCommand.java > 8034bbe9e6caa1672a0018daf48d649c5e5d2410 > core/src/test/java/org/apache/oozie/command/wf/HangServlet.java > 3344cf97762c77f5660d94341e72df4243f76eb2 > core/src/test/java/org/apache/oozie/command/wf/TestActionCheckXCommand.java > 5898d1af79631a1b7e5021d9ca05685eab7225a5 > core/src/test/java/org/apache/oozie/command/wf/TestActionStartXCommand.java > ea90c087fc145650dfb77ac35a03ba1203ffb0f2 > core/src/test/java/org/apache/oozie/command/wf/TestSubmitHiveXCommand.java > 43edf5efad0932aa5089ac8a6f6cfcf9f120d966 > core/src/test/java/org/apache/oozie/command/wf/TestSubmitMRXCommand.java > 5bc5747786774766e7156cb241d5444fefe6d7cb > core/src/test/java/org/apache/oozie/command/wf/TestSubmitPigXCommand.java > 5a1de25c85129e0b9567d0fd045133bffc700c5d > core/src/test/java/org/apache/oozie/command/wf/TestSubmitSqoopXCommand.java > 49b5028bcaff62e752a9582f1ddb5fb2ec56433c > > core/src/test/java/org/apache/oozie/command/wf/TestWorkflowActionKillXCommand.java > 72f01148ea457085f293689eda30509a1ca694d6 > core/src/test/java/org/apache/oozie/coord/TestHCatELFunctions.java > e41df8719fa361adca5406ddf1da919f9e78016d > core/src/test/java/org/apache/oozie/dependency/TestHCatURIHandler.java > 6fd1a1aa5eab59c085551be8e52fa0d01c79c4da > core/src/test/java/org/apache/oozie/service/TestConfigurationService.java > 42ffdbeb41e5829cdf814cf13ada331973fc33bd > core/src/test/java/org/apache/oozie/service/TestHadoopAccessorService.java > bbca4794b693f865290adaa915d60019fc1218dd > core/src/test/java/org/apache/oozie/service/TestRecoveryService.java > 8fd0c2d5080b416470a8d886f69c7e3de8fa3ffc > core/src/test/java/org/apache/oozie/service/TestShareLibService.java > 2d31f9a86c25c15ee50bd420fb7300ee81a20835 > > core/src/test/java/org/apache/oozie/service/TestSparkConfigurationService.java > 1278efa0775c32c16cb38309ab8e92e08d4eb2ec > core/src/test/java/org/apache/oozie/servlet/TestAdminServlet.java > 8e3502c343744b7e70d2033643c9596c0c029778 > core/src/test/java/org/apache/oozie/servlet/TestV1AdminServlet.java > a3f3b9c28c0f34381930a7457b5b622695948742 > core/src/test/java/org/apache/oozie/test/MiniHCatServer.java > b2f7282a30bc8ed269d9c4208036421047647ef0 > core/src/test/java/org/apache/oozie/test/XDataTestCase.java > ea778bd19f272876f1f8d38614ecba47649526ef > core/src/test/java/org/apache/oozie/test/XFsTestCase.java > 1d399e4ce921af8cb2cb2e6375d425dd5f7780f7 > core/src/test/java/org/apache/oozie/test/XHCatTestCase.java > 58f4beab9e707a3d8542253df596a566e65eff3c > core/src/test/java/org/apache/oozie/test/XTestCase.java > e1d9068f3ae0ee2ee01eb1e8f6e7164fd3c865b8 > core/src/test/java/org/apache/oozie/util/TestClasspathUtils.java > PRE-CREATION > core/src/test/java/org/apache/oozie/util/TestIOUtils.java > 6fcdf5526927a3b8033c7a0c747b7480a5f199e7 > > core/src/test/java/org/apache/oozie/workflow/lite/TestLiteWorkflowAppParser.java > a3c7b142d08101e2bb03737871db939133bd3cd2 > distro/src/main/bin/addtowar.sh 399040936bde3d091d42557f6a64a0aee2b139e2 > docs/src/site/twiki/DG_CommandLineTool.twiki > 6a9e4b4bfd50954c399dd094c3fee82c491b6800 > docs/src/site/twiki/DG_HCatalogIntegration.twiki > 39df67c3f5c5df0bb0521f613a66862c1b0a0ed8 > docs/src/site/twiki/DG_QuickStart.twiki > 2b9dc3bc753e7bf712117a92b76cdf29d11446cc > docs/src/site/twiki/ENG_Building.twiki > dda829b7eb9c1683f5999e436dafaa531be0920a > docs/src/site/twiki/WebServicesAPI.twiki > a63a68cb27de05d03ad173caeb18f5b17e20867b > docs/src/site/twiki/WorkflowFunctionalSpec.twiki > 460f6e521cb8fe2e508ec7086081d49890efb037 > findbugs-filter.xml PRE-CREATION > hadooplibs/hadoop-auth-1/pom.xml 85e2298c25fc13bfc29ef8e0226d4eda2a95a073 > hadooplibs/hadoop-auth-2/pom.xml 7202b2e036bb49964435d089d9f9ff1e9237a7f7 > hadooplibs/hadoop-distcp-1/pom.xml bbc536b5901540e8f0835f75e185b7bb40e02e3c > hadooplibs/hadoop-distcp-2/pom.xml 2c21b12068ecc9782e2d12c4376ee16bfba16af0 > hadooplibs/hadoop-distcp-3/pom.xml 39cf9f26c71dc5a93bceb1f750de46002d2c7f80 > hadooplibs/hadoop-utils-1/pom.xml a53e9bca3024d924b7e9e79f2199d30b18506132 > > hadooplibs/hadoop-utils-1/src/main/java/org/apache/oozie/action/hadoop/LauncherMainHadoopUtils.java > c0a237777f44e4d0a9061fc468af98cec2b92aa9 > > hadooplibs/hadoop-utils-1/src/main/java/org/apache/oozie/hadoop/utils/HadoopShims.java > 799dffbd7dc04654e72fa8de484143732f725fa1 > hadooplibs/hadoop-utils-2/pom.xml 7c4a0a10a56a79ce0513bfa2f790ffbbc5eb960a > > hadooplibs/hadoop-utils-2/src/main/java/org/apache/oozie/action/hadoop/LauncherMainHadoopUtils.java > a0b7d62c9432614f33baa3631660e6cb7918cd94 > > hadooplibs/hadoop-utils-2/src/main/java/org/apache/oozie/hadoop/utils/HadoopShims.java > c21884c7f94dab78be4a6dea20b698476479dc17 > hadooplibs/hadoop-utils-3/pom.xml 2f36f8bea921ad5ff74663728b377352daf0b2ca > > hadooplibs/hadoop-utils-3/src/main/java/org/apache/oozie/action/hadoop/LauncherMainHadoopUtils.java > 0cf2e909283712f6e93653241f62ba601ae85706 > > hadooplibs/hadoop-utils-3/src/main/java/org/apache/oozie/hadoop/utils/HadoopShims.java > c21884c7f94dab78be4a6dea20b698476479dc17 > hadooplibs/pom.xml 06801cc6d8dcfe1fa21367c3bb26c3f8dcaf29ec > pom.xml 98a2359a3ca476a0516a9746da2c1e91857143fd > release-log.txt 4e7097b17a2ab1036135b27e9bdf3554fa2923ae > sharelib/distcp/pom.xml 1f3c0cc6da4e996045fcce39e0e6477df2589f63 > > sharelib/distcp/src/main/java/org/apache/oozie/action/hadoop/DistcpMain.java > fcaadefd215368565fb126ca92515792e1f1a09b > sharelib/hcatalog/pom.xml 6eb88ef85e2f8c9398df64908e7777f251c1dbfa > > sharelib/hcatalog/src/main/java/org/apache/oozie/action/hadoop/HCatLauncherURIHandler.java > 7edb40d9d7cba6ef0603de25c9cee55f39b75f3b > sharelib/hcatalog/src/main/java/org/apache/oozie/util/HCatURI.java > faeff2a7f5f24f1680df5e529bbb48f49c750e09 > sharelib/hcatalog/src/test/java/org/apache/oozie/util/TestHCatURI.java > ce690da986f3bbbab7f74e771b1fe9e32f047b27 > sharelib/hive/pom.xml 13312192b634be802b3bc52726770d5c7b4057e9 > sharelib/hive/src/main/java/org/apache/oozie/action/hadoop/HiveMain.java > bc8ab29c25405806f40232d32254ba2a7f5271e4 > > sharelib/hive/src/test/java/org/apache/oozie/action/hadoop/TestHiveActionExecutor.java > 12e1e91cf83a109d77b6a20b022dee851447525d > > sharelib/hive/src/test/java/org/apache/oozie/action/hadoop/TestHiveMain.java > 2ba0da7b1bc342d7d644a914763621940bd34532 > sharelib/hive2/pom.xml e81bfbe0a96a490b349a2660a0b00381d56785e1 > sharelib/hive2/src/main/java/org/apache/oozie/action/hadoop/Hive2Main.java > a3a07bdedfe311fbfb8ec2236d8a7d6db55e82d8 > > sharelib/hive2/src/test/java/org/apache/oozie/action/hadoop/TestHive2ActionExecutor.java > 4818bb6399a6c9d315af8fee7667db3691704840 > sharelib/oozie/pom.xml f3ea0716a6719c44916bb50255f5f31a873fb514 > > sharelib/oozie/src/main/java/org/apache/oozie/action/hadoop/AMRMCallBackHandler.java > PRE-CREATION > > sharelib/oozie/src/main/java/org/apache/oozie/action/hadoop/ActionUtils.java > PRE-CREATION > > sharelib/oozie/src/main/java/org/apache/oozie/action/hadoop/ErrorHolder.java > PRE-CREATION > > sharelib/oozie/src/main/java/org/apache/oozie/action/hadoop/HdfsOperations.java > PRE-CREATION > sharelib/oozie/src/main/java/org/apache/oozie/action/hadoop/JavaMain.java > 30d68e2a55dd2e6b695c27ec18e5e47a48eb9322 > sharelib/oozie/src/main/java/org/apache/oozie/action/hadoop/LauncherAM.java > PRE-CREATION > > sharelib/oozie/src/main/java/org/apache/oozie/action/hadoop/LauncherAMCallbackNotifier.java > PRE-CREATION > > sharelib/oozie/src/main/java/org/apache/oozie/action/hadoop/LauncherMain.java > 7ae48e168a310b4d55feda7cbce8b2d29c2ec505 > > sharelib/oozie/src/main/java/org/apache/oozie/action/hadoop/LauncherMapper.java > 8edebac1147d6e918c7bec921ef9ee94fb16e8e4 > > sharelib/oozie/src/main/java/org/apache/oozie/action/hadoop/LocalFsOperations.java > PRE-CREATION > > sharelib/oozie/src/main/java/org/apache/oozie/action/hadoop/MapReduceMain.java > d376057f010dc359b44c6d4fe69ec0493261f037 > > sharelib/oozie/src/main/java/org/apache/oozie/action/hadoop/PrepareActionsDriver.java > 21ae456b768fb1cb5334a9e23e6c6082240f8dff > > sharelib/oozie/src/main/java/org/apache/oozie/action/hadoop/PrepareActionsHandler.java > PRE-CREATION > sharelib/oozie/src/main/java/org/apache/oozie/action/hadoop/ShellMain.java > f109318d949c68d4738e65de5a63de7c950a7888 > > sharelib/oozie/src/test/java/org/apache/oozie/action/hadoop/LauncherAMTestMainClass.java > PRE-CREATION > > sharelib/oozie/src/test/java/org/apache/oozie/action/hadoop/TestHdfsOperations.java > PRE-CREATION > > sharelib/oozie/src/test/java/org/apache/oozie/action/hadoop/TestLauncherAM.java > PRE-CREATION > sharelib/pig/pom.xml 99148d73e19a42531275789e4079e11a916bbaeb > sharelib/pig/src/main/java/org/apache/oozie/action/hadoop/PigMain.java > ba393eee53e92d144159f83893d4baab00737a44 > > sharelib/pig/src/main/java/org/apache/oozie/action/hadoop/PigMainWithOldAPI.java > 14ab65e7d00c426036ced3e80400c80deea0e282 > > sharelib/pig/src/test/java/org/apache/oozie/action/hadoop/TestPigActionExecutor.java > 25092ce55d8407384837b07d6d58b0218d1de7ab > > sharelib/pig/src/test/java/org/apache/oozie/action/hadoop/TestPigMainWithOldAPI.java > e52e6fddd474da1bd3c4b03376b7b060df2ab3b5 > sharelib/spark/pom.xml abef24fe7f8a95f35347c2515385f9f582864559 > sharelib/spark/src/main/java/org/apache/oozie/action/hadoop/SparkMain.java > c24d95c88be0dbf6fe80241d887a70100a5e1b4a > > sharelib/spark/src/test/java/org/apache/oozie/action/hadoop/TestPyspark.java > 458baaa8b6f5bc4ec5dd8395d428a7e4215fb27c > > sharelib/spark/src/test/java/org/apache/oozie/action/hadoop/TestSparkActionExecutor.java > 8c77be0bdd7bf8cae07c4d4acd803df5730826e7 > sharelib/sqoop/pom.xml d5afa370b19ac3895e99c4bf594d3d32a4711d5b > sharelib/sqoop/src/main/java/org/apache/oozie/action/hadoop/SqoopMain.java > cb8f56e9b66de0eb2799e68bc56d0ee36d4ba317 > > sharelib/sqoop/src/test/java/org/apache/oozie/action/hadoop/TestSqoopActionExecutor.java > 3dfd606afb9a54791796cb3742998f35cec2f0ce > sharelib/streaming/pom.xml 4f732724846411f13bd0204cdc2bef198b44f0c6 > > sharelib/streaming/src/main/java/org/apache/oozie/action/hadoop/StreamingMain.java > 991bf7e849171cb7847fa6d64781ceb0782dae7c > > sharelib/streaming/src/test/java/org/apache/oozie/action/hadoop/TestMapReduceActionExecutor.java > 5f9f38eb2c30edd234b2a523e5ca6c5c2f2ae832 > tools/src/main/java/org/apache/oozie/tools/OozieSharelibCLI.java > 9aa4cb6bf47a632b87b187882a8e105c40f38daf > webapp/pom.xml 2c4dfc263f90c2167ff76aac1297ceb19cd32ae9 > > > Diff: https://reviews.apache.org/r/54705/diff/5/ > > > Testing > ------- > > Junit tests are passing. > Submitted jobs to a hadoop cluster successfully. > > > Thanks, > > Peter Cseh > >
