> On March 30, 2017, 1:39 a.m., Robert Kanter wrote: > > core/src/main/java/org/apache/oozie/util/TimestampedMessageParser.java > > Lines 194-214 (patched) > > <https://reviews.apache.org/r/43970/diff/5/?file=1650584#file1650584line195> > > > > This code is almost identical to the code above. Is there any way to > > combine them? Otherwise, it can be easy for these to diverge accidently in > > the future.
Actually, see my other comment about parseNextLine not being needed anymore. In that case, there's no duplication. - Robert ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43970/#review170509 ----------------------------------------------------------- On Feb. 27, 2017, 7:42 p.m., Satish Saley wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43970/ > ----------------------------------------------------------- > > (Updated Feb. 27, 2017, 7:42 p.m.) > > > Review request for oozie. > > > Bugs: https://issues.apache.org/jira/browse/OOZIE-2417 > > https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/OOZIE-2417 > > > Repository: oozie-git > > > Description > ------- > > This patch tries to minimize the parsing of same log line for multiple times > using different regex. > It also caches the log parts once we figure out what those are, thus avoiding > the re-parsing of log line to get log parts whenever needed. > > > Diffs > ----- > > core/src/main/java/org/apache/oozie/util/LogLine.java PRE-CREATION > > core/src/main/java/org/apache/oozie/util/SimpleTimestampedMessageParser.java > 78cb042 > core/src/main/java/org/apache/oozie/util/TimestampedMessageParser.java > a676f4d > core/src/main/java/org/apache/oozie/util/XLogFilter.java 3b49f77 > > > Diff: https://reviews.apache.org/r/43970/diff/5/ > > > Testing > ------- > > > Thanks, > > Satish Saley > >
