[
https://issues.apache.org/jira/browse/OOZIE-2827?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15952180#comment-15952180
]
Alonzo Zhou commented on OOZIE-2827:
------------------------------------
Thank you for your thorough review! [~pbacsko]
The 1st point your mentioned, namely, method with empty body, I have fixed it。
As for the 2nd and 3rd point, I'm going to explain in detail below:
*There exist THREE cases where WorkflowActionBean couldn't be obtained:*
1. workflow id is null, which, in my opinion, means workflow instance is not
created and this is expected situation.
2. action name has changed and WorkflowActionGetJPAExecutor couldn't retrieve
node info. As far as I know, WARNING is decent enough to take care of this. In
real situation, coordinator rarely update WorkflowAction name.
3. If there is an underlying database issue that caused JPAExecutorException,
and we should throw Exception consequencely.
*How we handle cases when workflowAction can't be retrieved:*
1. Should element be added into list? You know, there is actually no seq
number info in workflowActionBean, which means placeholder element is needed.
2. And yes indeed I agree that using null as placeholder is not that
reasonable. I think it is a better idea to use a empty WorkflowActionBean for
that. we can determine whether it is empty by determining whether action id is
empty.
I have just updated patch according to what're mentioned above. I'd be much
appreciated if you could continue to review my updated patch when you have
time. Thanks!
> More directly view of the coordinator’s history from perspective of workflow
> action.
> ------------------------------------------------------------------------------------
>
> Key: OOZIE-2827
> URL: https://issues.apache.org/jira/browse/OOZIE-2827
> Project: Oozie
> Issue Type: Improvement
> Reporter: Alonzo Zhou
> Attachments: OOZIE-2827-0001.patch, OOZIE-2827-0002.patch,
> OOZIE-2827-0003.patch, OOZIE-2827-0004.patch
>
>
> Background:
> When we monitor a coordinator job, statistics of historical workflow
> instances such as running time can be directly visualized.
> But, we lack the ability to monitor historical statistics of coordinator from
> perspective of workflow action.For example, running time of a coordinator
> action is longer than before, but we can't see the exact change tendency of a
> sepcific workflow action in it。
> Functional optimization:
> More detailed view of the coordinator’s history can be observed from
> perspective of workflow action.Furthermore, the trend of a workflow action
> can be shown directly on front-end graph.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
