----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57799/#review171047 -----------------------------------------------------------
docs/src/site/twiki/ENG_Custom_Authentication.twiki Line 35 (original), 35 (patched) <https://reviews.apache.org/r/57799/#comment243888> It's not clear what TheAuthenticatorConf is supposed to be used for. The code for it starting on line 55 doesn't seem to do anything other than wrap a hashmap... And ````conf```` is never used here. docs/src/site/twiki/ENG_Custom_Authentication.twiki Lines 40-41 (original), 40-41 (patched) <https://reviews.apache.org/r/57799/#comment243890> This is pretty vague. docs/src/site/twiki/ENG_Custom_Authentication.twiki Line 58 (original), 52 (patched) <https://reviews.apache.org/r/57799/#comment243889> The sentence structure is weird here, but I think it's trying to say: "The following shows an example of a singleton configuration class which can be used by an Authentictor class to set and get config properties which are required by the Authenticator." Even so, I'm not sure what this is for. docs/src/site/twiki/ENG_Custom_Authentication.twiki Line 90 (original), 84 (patched) <https://reviews.apache.org/r/57799/#comment243891> "... an Oozie client should..." - Robert Kanter On April 4, 2017, 12:39 p.m., Jan Hentschel wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57799/ > ----------------------------------------------------------- > > (Updated April 4, 2017, 12:39 p.m.) > > > Review request for oozie. > > > Bugs: OOZIE-2825 > https://issues.apache.org/jira/browse/OOZIE-2825 > > > Repository: oozie-git > > > Description > ------- > > Fixed the code sample in the custom authentication page in the documentation. > > > Diffs > ----- > > docs/src/site/twiki/ENG_Custom_Authentication.twiki 64334b6 > > > Diff: https://reviews.apache.org/r/57799/diff/2/ > > > Testing > ------- > > > Thanks, > > Jan Hentschel > >
