[
https://issues.apache.org/jira/browse/OOZIE-2844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15956691#comment-15956691
]
Hadoop QA commented on OOZIE-2844:
----------------------------------
Testing JIRA OOZIE-2844
Cleaning local git workspace
----------------------------
{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:green}+1 RAW_PATCH_ANALYSIS{color}
. {color:green}+1{color} the patch does not introduce any @author tags
. {color:green}+1{color} the patch does not introduce any tabs
. {color:green}+1{color} the patch does not introduce any trailing spaces
. {color:green}+1{color} the patch does not introduce any line longer than
132
. {color:green}+1{color} the patch does adds/modifies 1 testcase(s)
{color:green}+1 RAT{color}
. {color:green}+1{color} the patch does not seem to introduce new RAT
warnings
{color:green}+1 JAVADOC{color}
. {color:green}+1{color} the patch does not seem to introduce new Javadoc
warnings
{color:red}-1 COMPILE{color}
. {color:red}-1{color} HEAD does not compile
. {color:green}+1{color} patch compiles
. {color:green}+1{color} the patch does not seem to introduce new javac
warnings
{color:red}-1{color} There are [333] new bugs found below threshold in total
that must be fixed.
. {color:green}+1{color} There are no new bugs found in [client].
. {color:green}+1{color} There are no new bugs found in [sharelib/hive].
. {color:green}+1{color} There are no new bugs found in [sharelib/sqoop].
. {color:green}+1{color} There are no new bugs found in [sharelib/spark].
. {color:green}+1{color} There are no new bugs found in [sharelib/streaming].
. {color:green}+1{color} There are no new bugs found in [sharelib/hive2].
. {color:green}+1{color} There are no new bugs found in [sharelib/oozie].
. {color:green}+1{color} There are no new bugs found in [sharelib/hcatalog].
. {color:green}+1{color} There are no new bugs found in [sharelib/pig].
. {color:green}+1{color} There are no new bugs found in [sharelib/distcp].
. {color:green}+1{color} There are no new bugs found in [docs].
. {color:red}-1{color} There are [327] new bugs found below threshold in
[server] that must be fixed, listing only the first [5] ones.
. You can find the FindBugs diff here (look for the red and orange ones):
server/findbugs-new.html
. The top [5] most important FindBugs errors are:
. At BinaryBlob.java:[line 68]: org.apache.oozie.BinaryBlob.getBytes() may
expose internal representation by returning BinaryBlob.bytes
. org.apache.oozie.BinaryBlob.getRawBlob() may expose internal representation
by returning BinaryBlob.rawBlob: Another occurrence at BinaryBlob.java:[line 88]
. Another occurrence at BinaryBlob.java:[line 116]: At BinaryBlob.java:[line 99]
. At BinaryBlob.java:[line 43]: new org.apache.oozie.BinaryBlob(byte[],
boolean) may expose internal representation by storing an externally mutable
object into BinaryBlob.bytes
. At BinaryBlob.java:[line 47]: new org.apache.oozie.BinaryBlob(byte[],
boolean) may expose internal representation by storing an externally mutable
object into BinaryBlob.rawBlob
. {color:green}+1{color} There are no new bugs found in [core].
. {color:red}-1{color} There are [6] new bugs found below threshold in
[hadooplibs/hadoop-utils-2] that must be fixed, listing only the first [5] ones.
. You can find the FindBugs diff here (look for the red and orange ones):
hadooplibs/hadoop-utils-2/findbugs-new.html
. The top [5] most important FindBugs errors are:
. At DateList.java:[line 55]: Nullcheck of date at line 55 of value previously
dereferenced in org.apache.oozie.example.DateList.main(String[])
. Private method org.apache.oozie.example.DateList.formatDateUTC(Calendar) is
never called: Redundant null check at DateList.java:[line 62]
. org.apache.oozie.example.LocalOozieExample.execute(String[]) may fail to
clean up java.io.InputStream: At DateList.java:[line 97]
. Path continues at LocalOozieExample.java:[line 76]: Obligation to clean up
resource created at LocalOozieExample.java:[line 72] is not discharged
. Path continues at LocalOozieExample.java:[line 78]: Path continues at
LocalOozieExample.java:[line 77]
{color:green}+1 BACKWARDS_COMPATIBILITY{color}
. {color:green}+1{color} the patch does not change any JPA
Entity/Colum/Basic/Lob/Transient annotations
. {color:green}+1{color} the patch does not modify JPA files
{color:red}-1 TESTS{color} - patch does not compile, cannot run testcases
{color:green}+1 DISTRO{color}
. {color:green}+1{color} distro tarball builds with the patch
----------------------------
{color:red}*-1 Overall result, please check the reported -1(s)*{color}
The full output of the test-patch run is available at
. https://builds.apache.org/job/oozie-trunk-precommit-build/3776/
> Increase stability of Oozie actions when log4j.properties is missing or not
> readable
> ------------------------------------------------------------------------------------
>
> Key: OOZIE-2844
> URL: https://issues.apache.org/jira/browse/OOZIE-2844
> Project: Oozie
> Issue Type: Improvement
> Components: action
> Affects Versions: 4.3.0
> Reporter: Andras Piros
> Assignee: Andras Piros
> Fix For: 4.3.0
>
> Attachments: OOZIE-2844.001.patch, OOZIE-2844.002.patch,
> OOZIE-2844.003.patch
>
>
> In several Oozie actions we face the problem that if {{log4j.properties}} is
> not readable by current thread, or not present on the classpath, while taking
> an {{URL.openStream()}} call afterwards, an {{IOException}} is thrown and the
> action won't run.
> Such actions are:
> *
> [*{{DistcpMain}}*|https://github.com/apache/oozie/blob/master/sharelib/distcp/src/main/java/org/apache/oozie/action/hadoop/DistcpMain.java#L135]
> *
> [*{{HiveMain}}*|https://github.com/apache/oozie/blob/master/sharelib/hive/src/main/java/org/apache/oozie/action/hadoop/HiveMain.java#L146]
> *
> [*{{PigMain}}*|https://github.com/apache/oozie/blob/master/sharelib/pig/src/main/java/org/apache/oozie/action/hadoop/PigMain.java#L173]
> *
> [*{{PigMainWithOldApi}}*|https://github.com/apache/oozie/blob/master/sharelib/pig/src/main/java/org/apache/oozie/action/hadoop/PigMainWithOldAPI.java#L160]
> *
> [*{{SparkMain}}*|https://github.com/apache/oozie/blob/master/sharelib/spark/src/main/java/org/apache/oozie/action/hadoop/SparkMain.java#L430]
> *
> [*{{SqoopMain}}*|https://github.com/apache/oozie/blob/master/sharelib/sqoop/src/main/java/org/apache/oozie/action/hadoop/SqoopMain.java#L124]
> Extend
> [*{{LauncherMain.run()}}*|https://github.com/apache/oozie/blob/master/sharelib/oozie/src/main/java/org/apache/oozie/action/hadoop/LauncherMain.java#L62-L65]
> by a convenience method that loads Hadoop's {{log4j.properties}} in
> beforehand. In case {{URL.openStream()}} would throw {{IOException}} we
> resort to a call to a new file {{hadoop-default-log4j.properties}} on the
> classpath (packaged along w/ {{LauncherMain.class}}) that has the same
> contents as the {{log4j.properties}} that is not accessible / readable /
> present.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
