> On 四月 3, 2017, 10:23 a.m., Peter Bacsko wrote: > > core/src/main/java/org/apache/oozie/command/coord/CoordWfActionInfoXCommand.java > > Lines 81 (patched) > > <https://reviews.apache.org/r/57870/diff/4/?file=1682907#file1682907line81> > > > > Are we sure that the default, uninitialized instance is good enough? > > > > So let's say we store the empty bean as a placeholder. How will that be > > returned to the user? > > > > As I can see, status will be PREP, wfId is null, id is null, everything > > else is pretty much null. > > > > Is this sufficient for us? Won't that be misleading?
hi, i added a class CoordinatorWfActionBean as an element in the returned list, which includes a WorkflowActionBean, an int that corresponds to the coordinatorAction serial number, and a string to explain why the WorkflowActionBean is null. The packaging looks a bit more robustness and friendly. could you review it for me ? thanks. - Alonzo ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57870/#review170838 ----------------------------------------------------------- On 四月 6, 2017, 2:34 p.m., Alonzo Zhou wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57870/ > ----------------------------------------------------------- > > (Updated 四月 6, 2017, 2:34 p.m.) > > > Review request for oozie. > > > Repository: oozie-git > > > Description > ------- > > More detailed view of the coordinator’s history can be observed from > perspective of workflow action. > > > Diffs > ----- > > client/src/main/java/org/apache/oozie/client/CoordinatorWfAction.java > PRE-CREATION > client/src/main/java/org/apache/oozie/client/rest/JsonTags.java ca168e0 > client/src/main/java/org/apache/oozie/client/rest/RestConstants.java > 8ddb1f8 > core/src/main/java/org/apache/oozie/CoordinatorEngine.java 2f9f822 > core/src/main/java/org/apache/oozie/CoordinatorWfActionBean.java > PRE-CREATION > core/src/main/java/org/apache/oozie/ErrorCode.java b03ad06 > > core/src/main/java/org/apache/oozie/command/coord/CoordWfActionInfoXCommand.java > PRE-CREATION > > core/src/main/java/org/apache/oozie/executor/jpa/WorkflowActionGetJPAExecutor.java > 0b7f50d > core/src/main/java/org/apache/oozie/servlet/BaseJobServlet.java 03acbc1 > core/src/main/java/org/apache/oozie/servlet/V2JobServlet.java 6c30f5d > core/src/test/java/org/apache/oozie/client/TestOozieCLI.java 564db2a > > core/src/test/java/org/apache/oozie/command/coord/TestCoordWfActionInfoXCommand.java > PRE-CREATION > > core/src/test/java/org/apache/oozie/servlet/MockCoordinatorEngineService.java > 4fc8653 > core/src/test/java/org/apache/oozie/servlet/TestV2JobServlet.java fb203a6 > > > Diff: https://reviews.apache.org/r/57870/diff/5/ > > > Testing > ------- > > > Thanks, > > Alonzo Zhou > >
