----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58365/#review171691 -----------------------------------------------------------
core/src/main/java/org/apache/oozie/command/coord/CoordChangeXCommand.java Lines 439-442 (original), 439-442 (patched) <https://reviews.apache.org/r/58365/#comment244707> Would be nice to have a `TRACE` log both in the `if` and in the `else` branch. core/src/test/java/org/apache/oozie/command/coord/TestCoordChangeXCommand.java Lines 62 (patched) <https://reviews.apache.org/r/58365/#comment244713> Why not use `java.util.concurrent.TimeUnit.HOURS.toMillis(1)`? core/src/test/java/org/apache/oozie/command/coord/TestCoordChangeXCommand.java Line 541 (original), 542 (patched) <https://reviews.apache.org/r/58365/#comment244720> Why not use `java.util.concurrent.TimeUnit.HOURS.toMillis(4)`? core/src/test/java/org/apache/oozie/command/coord/TestCoordChangeXCommand.java Line 627 (original), 628 (patched) <https://reviews.apache.org/r/58365/#comment244721> Why not use `java.util.concurrent.TimeUnit.HOURS.toMillis(3)`? core/src/test/java/org/apache/oozie/command/coord/TestCoordChangeXCommand.java Line 732 (original), 733 (patched) <https://reviews.apache.org/r/58365/#comment244722> Why not use `java.util.concurrent.TimeUnit.HOURS.toMillis(2)`? core/src/test/java/org/apache/oozie/command/coord/TestCoordChangeXCommand.java Line 766 (original), 767 (patched) <https://reviews.apache.org/r/58365/#comment244723> Why not use `java.util.concurrent.TimeUnit.HOURS.toMillis(5)`? core/src/test/java/org/apache/oozie/command/coord/TestCoordChangeXCommand.java Line 811 (original), 812 (patched) <https://reviews.apache.org/r/58365/#comment244724> Why not use `java.util.concurrent.TimeUnit.HOURS.toMillis(5)`? core/src/test/java/org/apache/oozie/command/coord/TestCoordChangeXCommand.java Line 840 (original), 841 (patched) <https://reviews.apache.org/r/58365/#comment244725> Why not use `java.util.concurrent.TimeUnit.HOURS.toMillis(5)`? core/src/test/java/org/apache/oozie/command/coord/TestCoordChangeXCommand.java Line 869 (original), 870 (patched) <https://reviews.apache.org/r/58365/#comment244726> Why not use `java.util.concurrent.TimeUnit.HOURS.toMillis(4)`? core/src/test/java/org/apache/oozie/command/coord/TestCoordChangeXCommand.java Line 889 (original), 890 (patched) <https://reviews.apache.org/r/58365/#comment244727> Why not use `java.util.concurrent.TimeUnit.HOURS.toMillis(4)`? core/src/test/java/org/apache/oozie/command/coord/TestCoordChangeXCommand.java Lines 909 (patched) <https://reviews.apache.org/r/58365/#comment244728> Please rename to a test method name that expresses both the prerequisites and the expected end state of the test case, like `testWhenJobIsKilledNoActionIsCreated()`. core/src/test/java/org/apache/oozie/command/coord/TestCoordChangeXCommand.java Lines 911-912 (patched) <https://reviews.apache.org/r/58365/#comment244729> Why not use `java.util.concurrent.TimeUnit.HOURS.toMillis(4)`? - András Piros On April 11, 2017, 6:58 p.m., Purshotam Shah wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58365/ > ----------------------------------------------------------- > > (Updated April 11, 2017, 6:58 p.m.) > > > Review request for oozie. > > > Bugs: OOZIE-2862 > https://issues.apache.org/jira/browse/OOZIE-2862 > > > Repository: oozie-git > > > Description > ------- > > Coord change command doesn't change job to running if job was killed without > creating any actions > > > Diffs > ----- > > core/src/main/java/org/apache/oozie/command/coord/CoordChangeXCommand.java > e65b74fc > > core/src/test/java/org/apache/oozie/command/coord/TestCoordChangeXCommand.java > 8034bbe9 > > > Diff: https://reviews.apache.org/r/58365/diff/1/ > > > Testing > ------- > > > Thanks, > > Purshotam Shah > >
