> On March 24, 2017, 12:24 p.m., Peter Bacsko wrote: > > core/src/main/java/org/apache/oozie/BaseLocalOozieClient.java > > Lines 457 (patched) > > <https://reviews.apache.org/r/54383/diff/6/?file=1597608#file1597608line457> > > > > Extract cases to constants. > > > > Optional: if it's not too much work, pls also take care of replacing > > the other occurrences.
The patch is already big, so it would be better to not touch other functionality. > On March 24, 2017, 12:24 p.m., Peter Bacsko wrote: > > core/src/main/java/org/apache/oozie/LocalOozieClientBundle.java > > Lines 79 (patched) > > <https://reviews.apache.org/r/54383/diff/6/?file=1597610#file1597610line79> > > > > Non-typesafe cast. Do we even need to cast here at all? This is because of super-type vs sub-type. Same as other places. - Abhishek ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54383/#review169999 ----------------------------------------------------------- On Jan. 5, 2017, 5:34 p.m., Abhishek Bafna wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54383/ > ----------------------------------------------------------- > > (Updated Jan. 5, 2017, 5:34 p.m.) > > > Review request for oozie. > > > Bugs: OOZIE-2751 > https://issues.apache.org/jira/browse/OOZIE-2751 > > > Repository: oozie-git > > > Description > ------- > > LocalOozieClient is missing methods from OozieClient > > > Diffs > ----- > > client/src/main/java/org/apache/oozie/client/OozieClient.java 12c80cb > core/src/main/java/org/apache/oozie/BaseEngine.java 50df897 > core/src/main/java/org/apache/oozie/BaseLocalOozieClient.java PRE-CREATION > core/src/main/java/org/apache/oozie/LocalOozieClient.java f734f76 > core/src/main/java/org/apache/oozie/LocalOozieClientBundle.java > PRE-CREATION > core/src/main/java/org/apache/oozie/LocalOozieClientCoord.java 32b0cd0 > core/src/main/java/org/apache/oozie/OozieJsonFactory.java PRE-CREATION > core/src/main/java/org/apache/oozie/servlet/V0JobsServlet.java 2c79ef0 > core/src/main/java/org/apache/oozie/servlet/V1JobsServlet.java 80c8ec4 > core/src/test/java/org/apache/oozie/TestLocalOozieClientCoord.java 4decd52 > > > Diff: https://reviews.apache.org/r/54383/diff/6/ > > > Testing > ------- > > > Thanks, > > Abhishek Bafna > >
