[
https://issues.apache.org/jira/browse/OOZIE-2873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15991880#comment-15991880
]
Hadoop QA commented on OOZIE-2873:
----------------------------------
Testing JIRA OOZIE-2873
Cleaning local git workspace
----------------------------
{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:green}+1 RAW_PATCH_ANALYSIS{color}
. {color:green}+1{color} the patch does not introduce any @author tags
. {color:green}+1{color} the patch does not introduce any tabs
. {color:green}+1{color} the patch does not introduce any trailing spaces
. {color:green}+1{color} the patch does not introduce any line longer than
132
. {color:green}+1{color} the patch does adds/modifies 6 testcase(s)
{color:green}+1 RAT{color}
. {color:green}+1{color} the patch does not seem to introduce new RAT
warnings
{color:green}+1 JAVADOC{color}
. {color:green}+1{color} the patch does not seem to introduce new Javadoc
warnings
{color:green}+1 COMPILE{color}
. {color:green}+1{color} HEAD compiles
. {color:green}+1{color} patch compiles
. {color:green}+1{color} the patch does not seem to introduce new javac
warnings
{color:green}+1{color} There are no new bugs found in total.
. {color:green}+1{color} There are no new bugs found in [client].
. {color:green}+1{color} There are no new bugs found in [sharelib/hive].
. {color:green}+1{color} There are no new bugs found in [sharelib/sqoop].
. {color:green}+1{color} There are no new bugs found in [sharelib/spark].
. {color:green}+1{color} There are no new bugs found in [sharelib/streaming].
. {color:green}+1{color} There are no new bugs found in [sharelib/hive2].
. {color:green}+1{color} There are no new bugs found in [sharelib/oozie].
. {color:green}+1{color} There are no new bugs found in [sharelib/hcatalog].
. {color:green}+1{color} There are no new bugs found in [sharelib/pig].
. {color:green}+1{color} There are no new bugs found in [sharelib/distcp].
. {color:green}+1{color} There are no new bugs found in [docs].
. {color:green}+1{color} There are no new bugs found in [server].
. {color:green}+1{color} There are no new bugs found in [core].
. {color:green}+1{color} There are no new bugs found in
[hadooplibs/hadoop-utils-2].
. {color:green}+1{color} There are no new bugs found in [examples].
. {color:green}+1{color} There are no new bugs found in [tools].
{color:green}+1 BACKWARDS_COMPATIBILITY{color}
. {color:green}+1{color} the patch does not change any JPA
Entity/Colum/Basic/Lob/Transient annotations
. {color:green}+1{color} the patch does not modify JPA files
{color:green}+1 TESTS{color}
. Tests run: 1934
. Tests rerun: 7
. Tests failed at first run: org.apache.oozie.command.TestXCommand,
{color:green}+1 DISTRO{color}
. {color:green}+1{color} distro tarball builds with the patch
----------------------------
{color:green}*+1 Overall result, good!, no -1s*{color}
The full output of the test-patch run is available at
. https://builds.apache.org/job/oozie-trunk-precommit-build/3797/
> Check El Functions before submitting the coordinator
> ----------------------------------------------------
>
> Key: OOZIE-2873
> URL: https://issues.apache.org/jira/browse/OOZIE-2873
> Project: Oozie
> Issue Type: Bug
> Reporter: Satish Subhashrao Saley
> Assignee: Satish Subhashrao Saley
> Priority: Minor
> Attachments: OOZIE-2873-1.patch
>
>
> Oozie doesn't check for el functions while submitting the coordinator job.
> Later on the coordinator action(s) can remain in WAITING state if there user
> has messed up the el functions.
> For Example.
> {code}
> <?xml version="1.0" encoding="UTF-8"?>
> <coordinator-app xmlns="uri:oozie:coordinator:0.4" name="my_coord"
> frequency="${coord:hours(1)}" start="${startTime}" end="${endTime}"
> timezone="UTC">
> <controls>
> <concurrency>1</concurrency>
> <execution>FIFO</execution>
> </controls>
> <datasets>
> <dataset name="my_dataset" frequency="${coord:hours(1)}"
> initial-instance="${initInstanceTime}" timezone="UTC">
>
> <uri-template>hcat://${HCAT_SERVER}/${HCAT_DB_NAME}/${TABLE_NAME}/dt=${YEAR}${MONTH}${DAY};hr=${HOUR}</uri-template>
> </dataset>
> </datasets>
> <input-events>
> <data-in name="my_dataset_name" dataset="my_dataset">
> <instance>${coord:current(0)}</instance>
> </data-in>
>
> </input-events>
> <action>
> <workflow>
> <app-path>${oozieAppWorkflowPath}/my_workflow.xml</app-path>
> <configuration>
> <property>
> <name>yyyymmdd</name>
> <value>${coord:formatTime(coord:nominalTime(),
> 'DAY')}</value>
> </property>
> <property>
> <name>hh</name>
>
> <value>${coord:formatTime(coord:nominalTime(),'HH')}</value>
> </property>
> </configuration>
> </workflow>
> </action>
> </coordinator-app>
> {code}
> After Oozie finds out the dependency.
> {code}
> 2017-04-25 16:51:53,503 DEBUG DependencyChecker:526 [pool-11-thread-66] -
> SERVER[localhost] USER[-] GROUP[-] TOKEN[-] APP[-] JOB[0100010100101-saley-C]
> ACTION[0100010100101-saley-C@1] Dependency
> [hcat://localhost:9098/my_database/my_table/dt=20170411;hr=02] is available
> {code}
> The issue is with el function
> {code}
> 2017-04-25 16:51:53,506 ERROR CoordPushDependencyCheckXCommand:517
> [pool-11-thread-66] - SERVER[localhost] USER[-] GROUP[-] TOKEN[-] APP[-]
> JOB[0100010100101-saley-C] ACTION[0100010100101-saley-C@1] XException,
> org.apache.oozie.command.CommandException: E1021: Coord Action Input Check
> Error: E1021: Coord Action Input Check Error: Unable to evaluate
> :${coord:formatTime(coord:nominalTime(), 'DAY')}:
> <configuration>
> <property>
> <name>yyyymmdd</name>
> <value>${coord:formatTime(coord:nominalTime(),
> 'DAY')}</value>
> </property>
> {code}
> The coord action remained in WAITING state.
> Solution:
> We should error out at the time of job submission. Currently users are
> supposed to run dry run on the coordinator before actually running it. But
> everybody wants to run directly. We should run dry run by default to catch
> such errors. While working the fix, I have found some buggy test cases which
> would have been caught if we run dry run first. Fixing those cases as well.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
