----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59635/#review176307 -----------------------------------------------------------
sharelib/spark/src/main/java/org/apache/oozie/action/hadoop/SparkArgsBuilder.java Lines 35 (patched) <https://reviews.apache.org/r/59635/#comment249708> Is it legitimate to call this a builder? I think it's better to rename it sth like SparkArgsUtil and build() could be called createFromMainArgs(). sharelib/spark/src/main/java/org/apache/oozie/action/hadoop/SparkArgsBuilder.java Lines 86-89 (patched) <https://reviews.apache.org/r/59635/#comment249709> All string literals could be constants, no? sharelib/spark/src/main/java/org/apache/oozie/action/hadoop/SparkArgsBuilder.java Lines 232 (patched) <https://reviews.apache.org/r/59635/#comment249710> const - Peter Bacsko On máj. 30, 2017, 8:50 de, András Piros wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59635/ > ----------------------------------------------------------- > > (Updated máj. 30, 2017, 8:50 de) > > > Review request for oozie. > > > Repository: oozie-git > > > Description > ------- > > OOZIE-2923 Improve Spark options parsing > > > Diffs > ----- > > > sharelib/spark/src/main/java/org/apache/oozie/action/hadoop/SparkArgsBuilder.java > PRE-CREATION > sharelib/spark/src/main/java/org/apache/oozie/action/hadoop/SparkMain.java > 68f7a607344ac8b3c11ab08220f27139433a998e > > sharelib/spark/src/main/java/org/apache/oozie/action/hadoop/SparkOptionsSplitter.java > PRE-CREATION > > sharelib/spark/src/test/java/org/apache/oozie/action/hadoop/TestSparkArgsBuilder.java > PRE-CREATION > > sharelib/spark/src/test/java/org/apache/oozie/action/hadoop/TestSparkMain.java > 5f6a0cdcde21287580f6b7037594669b508d24ef > > sharelib/spark/src/test/java/org/apache/oozie/action/hadoop/TestSparkOptionsSplitter.java > 31f53acca24d1dd645e32a37b58643b7a0a3cacd > > > Diff: https://reviews.apache.org/r/59635/diff/1/ > > > Testing > ------- > > Please see the JUnit tests `TestSparkMain`, `TestSparkOptionsSplitter`, and > `TestSparkArgsBuilder` for test cases. > > > Thanks, > > András Piros > >
