> On 六月 12, 2017, 7:44 a.m., András Piros wrote: > >
This is my first time to use ReviewBoard; I not sure how to update a diff correctly: ``` fatal: git cat-file: could not get object info Line undefined: undefined ``` so just add diff file ... > On 六月 12, 2017, 7:44 a.m., András Piros wrote: > > core/src/main/java/org/apache/oozie/command/coord/CoordSubmitXCommand.java > > Lines 869-872 (patched) > > <https://reviews.apache.org/r/59906/diff/1/?file=1744467#file1744467line869> > > > > This is quite suspicious here, to catch any and all `Exception` > > instances... can you be please much more specific? I don't think this is a problem; **CoordELFunctions.evalAndWrap**(evalNofuncs, tagElem.getText().trim()) throws Exception when content have el functions; Use **evalNofuncs** for *resolveSLAContent* just resolve the variables in conf, don't need to resolve el fuctions; example: > coordinator.xml define SLA like this ```xml <sla:info> <sla:nominal-time>${nominal_time}</sla:nominal-time> <sla:should-end>${ 1 * HOURS}</sla:should-end> <sla:notification-msg>Notifying User for ${coord:nominalTime()} ${coord:actualTime()} </sla:notification-msg> </sla:info> ``` el function like ${coord:nominalTime()} which defined in <sla:notification-msg> will not be resolved in function resolveSLAContent, so we need to cath Exception; - Wen ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59906/#review177591 ----------------------------------------------------------- On 六月 8, 2017, 4:01 a.m., Wen Chi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59906/ > ----------------------------------------------------------- > > (Updated 六月 8, 2017, 4:01 a.m.) > > > Review request for oozie and András Piros. > > > Bugs: OOZIE-2929 > https://issues.apache.org/jira/browse/OOZIE-2929 > > > Repository: oozie-git > > > Description > ------- > > 1. coordinator.xml define SLA like this > ```xml > <sla:info> > <sla:nominal-time>${nominal_time}</sla:nominal-time> > <sla:should-end>${ 1 * HOURS}</sla:should-end> > <sla:max-duration>${1 * MINUTES}</sla:max-duration> > </sla:info> > ``` > 2. In job.properties define: **nominal_time=${coord:nominalTime()}** > 3. Then coordinator will run failed > > "Coord Job Materialization Error: Could not parse [${coord:nominalTime()}] > > using [yyyy-MM-dd'T'HH:mm+0800] mask"; > > > Diffs > ----- > > core/src/main/java/org/apache/oozie/command/coord/CoordSubmitXCommand.java > 969336d2 > > core/src/test/java/org/apache/oozie/command/coord/TestCoordSubmitXCommand.java > dcc97ad0 > > > Diff: https://reviews.apache.org/r/59906/diff/1/ > > > Testing > ------- > > > Thanks, > > Wen Chi > >
