[
https://issues.apache.org/jira/browse/OOZIE-2867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16048532#comment-16048532
]
Robert Kanter commented on OOZIE-2867:
--------------------------------------
# On the unit test, I wasn't thinking - you're right. I think this can be done
but it's really messy. Instead, you could make {{THREE_LETTER_ID_PATTERN}}
package private and label it {{\@VisibleForTesting}} and just have the unit
test use it directly. It would be nice to simply call the method, but I think
this is the best compromise.
# I don't think we need the {{seleniumhq}} or {{com.opera}} artifacts, right?
# The nested if statement can be merged into one if statement:
{code:java}
if (m.matches() && !tzId.equalsIgnoreCase("UTC") &&
!tzId.equalsIgnoreCase("GMT")) {
...
{code}
> Timezone handling for Coordinators: emphasize "Continent/City" format
> ---------------------------------------------------------------------
>
> Key: OOZIE-2867
> URL: https://issues.apache.org/jira/browse/OOZIE-2867
> Project: Oozie
> Issue Type: Sub-task
> Components: coordinator
> Affects Versions: 4.3.0
> Reporter: Andras Piros
> Assignee: Artem Ervits
> Fix For: 5.0.0
>
> Attachments: OOZIE-2867-0.patch, OOZIE-2867-1.patch,
> OOZIE-2867-2.patch, OOZIE-2867-3.patch, OOZIE-2867-4.patch
>
>
> It seems that some time zone abbreviations like {{BST}} for British Summer
> Time silently just do not get accepted correctly by Oozie and the underlying
> JVM.
> It would be great to:
> * emphasize in the Coordinator Functional Specification that it's best to
> only use time zone format {{Continent/City}}, like {{Europe/London}}, or
> {{America/Los_Angeles}}, instead of other formats like {{PDT}}, {{PST}}, or
> {{BST}}
> * if the timezone is not recognized by Oozie, it's best to emit a {{WARN}}
> log and suppose {{UTC}} instead of silently ignoring the unknown specified
> timezone
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
