[
https://issues.apache.org/jira/browse/OOZIE-2974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16066765#comment-16066765
]
Hadoop QA commented on OOZIE-2974:
----------------------------------
Testing JIRA OOZIE-2974
Cleaning local git workspace
----------------------------
{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:green}+1 RAW_PATCH_ANALYSIS{color}
. {color:green}+1{color} the patch does not introduce any @author tags
. {color:green}+1{color} the patch does not introduce any tabs
. {color:green}+1{color} the patch does not introduce any trailing spaces
. {color:green}+1{color} the patch does not introduce any line longer than
132
. {color:green}+1{color} the patch does adds/modifies 1 testcase(s)
{color:green}+1 RAT{color}
. {color:green}+1{color} the patch does not seem to introduce new RAT
warnings
{color:green}+1 JAVADOC{color}
. {color:green}+1{color} the patch does not seem to introduce new Javadoc
warnings
. {color:red}WARNING{color}: the current HEAD has 1 Javadoc warning(s)
{color:green}+1 COMPILE{color}
. {color:green}+1{color} HEAD compiles
. {color:green}+1{color} patch compiles
. {color:green}+1{color} the patch does not seem to introduce new javac
warnings
{color:green}+1{color} There are no new bugs found in total.
{color:green}+1 BACKWARDS_COMPATIBILITY{color}
. {color:green}+1{color} the patch does not change any JPA
Entity/Colum/Basic/Lob/Transient annotations
. {color:green}+1{color} the patch does not modify JPA files
{color:green}+1 TESTS{color}
. Tests run: 1968
. Tests rerun: 79
. Tests failed at first run:
org.apache.oozie.action.hadoop.TestJavaActionExecutor,org.apache.oozie.jms.TestJMSJobEventListener,org.apache.oozie.action.hadoop.TestLauncherAM,
{color:green}+1 DISTRO{color}
. {color:green}+1{color} distro tarball builds with the patch
----------------------------
{color:green}*+1 Overall result, good!, no -1s*{color}
{color:red}. There is at least one warning, please check{color}
The full output of the test-patch run is available at
. https://builds.apache.org/job/oozie-trunk-precommit-build/3932/
> Change TestLiteWorkflowAppParser so that it works with Hadoop 3
> ---------------------------------------------------------------
>
> Key: OOZIE-2974
> URL: https://issues.apache.org/jira/browse/OOZIE-2974
> Project: Oozie
> Issue Type: Bug
> Reporter: Attila Sasvari
> Assignee: Attila Sasvari
> Attachments: OOZIE-2974-01.patch, OOZIE-2974-02.patch
>
>
> {{TestLiteWorkflowAppParser}} uses a
> [cleanupXML|https://github.com/apache/oozie/blob/branch-4.3/core/src/test/java/org/apache/oozie/workflow/lite/TestLiteWorkflowAppParser.java#L54]
> function to remove certain elements from a generated configuration XML when
> comparing with an expected value
> ([testParserGlobal()|https://github.com/apache/oozie/blob/branch-4.3/core/src/test/java/org/apache/oozie/workflow/lite/TestLiteWorkflowAppParser.java#L139]
> ):
> {code}
> private String cleanupXml(String xml) {
> xml = xml.replaceAll(" xmlns=?(\"|\')(\"|\')", "");
> xml = xml.replaceAll("\\s*<source>.*</source>", ""); // remove the
> <source> added by Hadoop 2
> return xml;
> }
> {code}
> [HADOOP-14216|https://issues.apache.org/jira/browse/HADOOP-14216] introduced
> a new "final" tag in the configuration that is set when hadoop 3 alpha 3 is
> used. See
> https://github.com/apache/hadoop/blob/branch-3.0.0-alpha3/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/conf/Configuration.java#L2952
> If we run the the test {{TestLiteWorkflowAppParser#testParserGlobal}}, it
> currently fails with:
> {noformat}
> Failed tests:
> testParserGlobal(org.apache.oozie.workflow.lite.TestLiteWorkflowAppParser):
> null expected:<...(..)
> {noformat}
> generated config that is returned by {{app.getNode("d").getConf()}} is as
> follows:
> {noformat}
> <map-reducexmlns="uri:oozie:workflow:0.4">
> <prepare>
> <deletepath="/tmp"/>
> <mkdirpath="/tmp"/>
> </prepare>
> <streaming>
> <mapper>/mycat.sh</mapper>
> <reducer>/mywc.sh</reducer>
> </streaming>
> <file>/tmp</file>
> <archive>/tmp</archive>
> <name-node>bar</name-node>
> <job-tracker>${foo}</job-tracker>
> <configuration>
> <property>
> <name>b</name>
> <value>B</value>
> <final>false</final>
> </property>
> <property>
> <name>a</name>
> <value>A</value>
> <final>false</final>
> </property>
> </configuration>
> </map-reduce>
> {noformat}
> Tests pass, if we remove the {{final}} element. For example we can the
> following to {{cleanupXml()}}
> {code}
> xml = xml.replaceAll("\\s*<final>.*</final>", ""); // remove the <final>
> added by Hadoop 3
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
