[ 
https://issues.apache.org/jira/browse/OOZIE-2371?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Daniel Becker updated OOZIE-2371:
---------------------------------
    Attachment: OOZIE-2371-001.patch

Hi!

I've added some documentation for workflow action state transitions.
However, there are some things that I'm not sure about, any help would be 
appreciated.

I'm not sure what the state USER_RETRY means. It would be logical if the action 
entered this state when a user manually retries the action, for example after 
START_MANUAL, but from the code it seems that this state is entered 
automatically in the ActionXCommand#handleUserRetry method, which is called 
from ActionXCommand#handleError, for example when running the test 
TestWorkflowActionRetryInfoXCommand#testRetryConsoleUrl.

Another thing is what final states are accessible from END_RETRY and 
END_MANUAL. In the test TestActionErrors#testEndNonTransient, the action 
transitions from END_MANUAL to OK at the end, but this is a 'test' action and 
the ActionExecutor is a ForTestingActionExecutor, which is not a "real", 
used-in-production ActionExecutor. The executor calls setEndData on the context 
which calls setEndData on the WorkflowActionBean instance that sets the status.
I decided to include the transition in the documentation because other 
ActionExecutors' end methods do mainly the same thing (for example 
JavaActionExecutor), that is, set the action status according to the 
externalStatus string.
For the END_RETRY state, I wasn't able to find an instance of transition to a 
final state.

Thanks a lot,
Daniel

> Add docs for state transitions for WF Action states
> ---------------------------------------------------
>
>                 Key: OOZIE-2371
>                 URL: https://issues.apache.org/jira/browse/OOZIE-2371
>             Project: Oozie
>          Issue Type: Sub-task
>          Components: docs
>            Reporter: Robert Kanter
>            Assignee: Daniel Becker
>            Priority: Blocker
>             Fix For: 5.0.0
>
>         Attachments: OOZIE-2371-001.patch
>
>
> We have a list of Workflow Job state transitions here:
> http://oozie.apache.org/docs/4.2.0/WorkflowFunctionalSpec.html#a9_Workflow_Jobs_Lifecycle
> A list of Coordinator Job state transitions here:
> http://oozie.apache.org/docs/4.2.0/CoordinatorFunctionalSpec.html#a6.1.2._Coordinator_Job
> And a list of Coordinator Action state transitions here:
> http://oozie.apache.org/docs/4.2.0/CoordinatorFunctionalSpec.html#a6.1.3.2._Coordinator_Action_Status
> We don't have anything similar for Workflow Actions.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to