----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60544/#review180082 -----------------------------------------------------------
core/pom.xml Lines 285 (patched) <https://reviews.apache.org/r/60544/#comment255089> We can't ship mysql-connector-java because it's GPL. https://mvnrepository.com/artifact/mysql/mysql-connector-java/5.1.34 core/src/main/java/org/apache/oozie/service/JPAService.java Lines 74 (patched) <https://reviews.apache.org/r/60544/#comment255090> Cool - I never new about this underscore feature. Makes it more readable. http://docs.oracle.com/javase/7/docs/technotes/guides/language/underscores-literals.html core/src/main/java/org/apache/oozie/store/WorkflowStore.java Lines 43 (patched) <https://reviews.apache.org/r/60544/#comment255092> This change seems unnecessary core/src/main/java/org/apache/oozie/store/WorkflowStore.java Lines 807 (patched) <https://reviews.apache.org/r/60544/#comment255091> This change seems unnecessary core/src/main/java/org/apache/oozie/util/db/BasicDataSourceWrapper.java Lines 33 (patched) <https://reviews.apache.org/r/60544/#comment255093> {@link BasicDataSource#createConnectionFactory} core/src/main/java/org/apache/oozie/util/db/BasicDataSourceWrapper.java Lines 36-39 (patched) <https://reviews.apache.org/r/60544/#comment255094> I'm not a big fan of having to do this, but it seems like this was fixed in 1.4.1, but the latest is 1.4.0 from 2010... which is unfotunate. I guess we have no choice :( Can you add a note here about why we have to fix the bug this way? core/src/main/java/org/apache/oozie/util/db/RetryAttemptState.java Lines 35-36 (patched) <https://reviews.apache.org/r/60544/#comment255095> Thank you for handling this. Hadoop does not, sometimes resulting in really long retries. core/src/main/resources/oozie-default.xml Line 1495 (original), 1495 (patched) <https://reviews.apache.org/r/60544/#comment255096> Is there a reason not to make oozie.service.JPAService.connection.data.source set to org.apache.oozie.util.db.BasicDataSourceWrapper by default? core/src/main/resources/oozie-default.xml Lines 1496 (patched) <https://reviews.apache.org/r/60544/#comment255097> oozie.service.JPAService.jdbc.driver definately does work because it's set to Derby by default and we clearly can change it to other databases. Why say this doesn't have a real effect? core/src/main/resources/oozie-log4j.properties Lines 62 (patched) <https://reviews.apache.org/r/60544/#comment255098> Do we want this by default? - Robert Kanter On July 6, 2017, 5:36 p.m., András Piros wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60544/ > ----------------------------------------------------------- > > (Updated July 6, 2017, 5:36 p.m.) > > > Review request for oozie, Attila Sasvari, Peter Cseh, Peter Bacsko, and > Robert Kanter. > > > Repository: oozie-git > > > Description > ------- > > https://issues.apache.org/jira/browse/OOZIE-2854 > > > Diffs > ----- > > core/pom.xml acddf349a89cf09a7fc4f384ebcaec56dfd0ab48 > > core/src/main/java/org/apache/oozie/executor/jpa/JsonBeanPersisterExecutor.java > PRE-CREATION > core/src/main/java/org/apache/oozie/executor/jpa/QueryExecutor.java > 8d94c23e40d1281864db40e141b200ca207a6324 > core/src/main/java/org/apache/oozie/service/JPAService.java > 028381d3b72bcc3b8c2cd27cacb3e0ac6d48d146 > core/src/main/java/org/apache/oozie/sla/SLASummaryBean.java > cfe1522a4b1f89085eb29e7f1281c2abd631bdc2 > core/src/main/java/org/apache/oozie/store/WorkflowStore.java > c565e74893b863caef6c93015cfe38fe520d04ec > core/src/main/java/org/apache/oozie/util/db/BasicDataSourceWrapper.java > PRE-CREATION > core/src/main/java/org/apache/oozie/util/db/DatabaseRetryPredicate.java > PRE-CREATION > core/src/main/java/org/apache/oozie/util/db/FailingConnectionWrapper.java > PRE-CREATION > core/src/main/java/org/apache/oozie/util/db/FailingHSQLDBDriverWrapper.java > PRE-CREATION > core/src/main/java/org/apache/oozie/util/db/FailingMySQLDriverWrapper.java > PRE-CREATION > core/src/main/java/org/apache/oozie/util/db/OperationRetryHandler.java > PRE-CREATION > > core/src/main/java/org/apache/oozie/util/db/PersistenceExceptionSubclassFilterRetryPredicate.java > PRE-CREATION > core/src/main/java/org/apache/oozie/util/db/RetryAttemptState.java > PRE-CREATION > core/src/main/java/org/apache/oozie/util/db/RuntimeExceptionInjector.java > PRE-CREATION > core/src/main/resources/META-INF/persistence.xml > bad9278597fcd4f93b4cc482afae8af14beaa922 > core/src/main/resources/oozie-default.xml > 5629a897b4a1834554a1a5f7a21984ea857ed133 > core/src/main/resources/oozie-log4j.properties > c065f3cd4c5a3df1308b69d7c16e8fcfa8796efc > core/src/test/java/org/apache/oozie/command/SkipCommitFaultInjection.java > core/src/test/java/org/apache/oozie/test/XTestCase.java > 161927ac8f1132b3080d2924844826fcc7b807a5 > > core/src/test/java/org/apache/oozie/util/db/TestOozieDmlStatementPredicate.java > PRE-CREATION > core/src/test/java/org/apache/oozie/util/db/TestOperationRetryHandler.java > PRE-CREATION > > core/src/test/java/org/apache/oozie/util/db/TestPersistenceExceptionSubclassFilterRetryPredicate.java > PRE-CREATION > core/src/test/java/org/apache/oozie/util/db/TestRetryAttemptState.java > PRE-CREATION > docs/src/site/twiki/AG_Install.twiki > 2125442c273661d54f3566cbe41ead822c1f7baa > minitest/pom.xml 9515284bb5f32c279a93161c10e6571680e4f9fc > > minitest/src/test/java/org/apache/oozie/test/TestParallelJPAOperationRetries.java > PRE-CREATION > minitest/src/test/java/org/apache/oozie/test/TestWorkflowRetries.java > PRE-CREATION > minitest/src/test/java/org/apache/oozie/test/WorkflowTest.java > 2845f0af6efb9ef75fdbfcb326115c62e6fb3bdd > minitest/src/test/resources/hsqldb-oozie-site.xml > fa5fe9c3185e973e8247d7bf10b126119d9c02c9 > minitest/src/test/resources/oozie-log4j.properties > c142d725140930bfa89cd2b163d0768a4c3a750a > minitest/src/test/resources/parallel-fs-and-shell.xml PRE-CREATION > minitest/src/test/resources/wf-test.xml > 20c4946862039a65c76ed7f49991345e90a694de > pom.xml 16c5137d44d7db891da46f80adb51c85e4c1b214 > > > Diff: https://reviews.apache.org/r/60544/diff/7/ > > > Testing > ------- > > Tests covered in code: > > Unit tests > ========== > > * testing the retry handler, the retry predicate filter, and parallel calls > to JPA `EntityManager` (mostly Oozie database reads and writes) when > injecting failures > > Integration tests > ================= > > * using the `MiniOozieTestCase` framework > * fixing it so that also asynchronous workflow applications (the ones that > use `CallableQueueService`) can be run > * following workflow scenarios: > * a very simple one consisting only of a `<start/>` and an `<end/>` node > * a more sophisticated one consisting of multiple synchronous `<fs/>` nodes > and a `<decision/>` node > * the ultimate one consisting of a `<decision/>` node, and two branches of an > `<fs/>` and an asynchronous `<shell/>` nodes > > Test cases run: > ``` > mvn clean test > -Dtest=TestOperationRetryHandler,TestPersistenceExceptionSubclassFilterRetryPredicate,TestParallelJPAOperationRetries,TestWorkflow,TestWorkflowRetries,TestJPAService,TestRetryAttemptState > ``` > > Functional and stress tests performed on a 4-node MySQL cluster. MySQL daemon > has been stopped / killed / restarted several times. Also firewall rules have > been modified temporarily to simulate network outages. > > > Thanks, > > András Piros > >
