[
https://issues.apache.org/jira/browse/OOZIE-3004?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16097110#comment-16097110
]
Hadoop QA commented on OOZIE-3004:
----------------------------------
Testing JIRA OOZIE-3004
Cleaning local git workspace
----------------------------
{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:green}+1 RAW_PATCH_ANALYSIS{color}
. {color:green}+1{color} the patch does not introduce any @author tags
. {color:green}+1{color} the patch does not introduce any tabs
. {color:green}+1{color} the patch does not introduce any trailing spaces
. {color:green}+1{color} the patch does not introduce any line longer than
132
. {color:green}+1{color} the patch does adds/modifies 1 testcase(s)
{color:green}+1 RAT{color}
. {color:green}+1{color} the patch does not seem to introduce new RAT
warnings
{color:green}+1 JAVADOC{color}
. {color:green}+1{color} the patch does not seem to introduce new Javadoc
warnings
. {color:red}WARNING{color}: the current HEAD has 1 Javadoc warning(s)
{color:green}+1 COMPILE{color}
. {color:green}+1{color} HEAD compiles
. {color:green}+1{color} patch compiles
. {color:green}+1{color} the patch does not seem to introduce new javac
warnings
{color:green}+1{color} There are no new bugs found in total.
{color:green}+1 BACKWARDS_COMPATIBILITY{color}
. {color:green}+1{color} the patch does not change any JPA
Entity/Colum/Basic/Lob/Transient annotations
. {color:green}+1{color} the patch does not modify JPA files
{color:green}+1 TESTS{color}
. Tests run: 976
. Tests rerun: 22
. Tests failed at first run: org.apache.oozie.action.hadoop.TestLauncherAM,
{color:green}+1 DISTRO{color}
. {color:green}+1{color} distro tarball builds with the patch
----------------------------
{color:green}*+1 Overall result, good!, no -1s*{color}
{color:red}. There is at least one warning, please check{color}
The full output of the test-patch run is available at
. https://builds.apache.org/job/oozie-trunk-precommit-build/3992/
> Forked action retry info is not working
> ---------------------------------------
>
> Key: OOZIE-3004
> URL: https://issues.apache.org/jira/browse/OOZIE-3004
> Project: Oozie
> Issue Type: Bug
> Reporter: Purshotam Shah
> Assignee: Purshotam Shah
> Attachments: OOZIE-3004-V1.patch, OOZIE-3004-V2.patch,
> screenshot-1.png
>
>
> UI shows N/A for start time and console URL
> We do parallel job submission for forked actions, and each job submission
> needs to update workflow instance.
> To avoid data race, ForkedActionStartXCommand write workflow instance to a
> temporary map.
> {code:title=ForkedActionExecutorContext.java}
> private Map<String, String> contextVariableMap = new HashMap<String,
> String>();
> public ForkedActionExecutorContext(WorkflowJobBean workflow,
> WorkflowActionBean action, boolean isRetry,
> boolean isUserRetry) {
> super(workflow, action, isRetry, isUserRetry);
> }
> public void setVar(String name, String value) {
> if (value != null) {
> contextVariableMap.remove(name);
> }
> else {
> contextVariableMap.put(name, value);
> }
> }
> {code}
> And when forked submission completes, the temporary map is written to the
> workflow instance.
> {code:title=SignalXCommand.java}
> List<Future<ActionExecutorContext>> futures =
> Services.get().get(CallableQueueService.class)
> .invokeAll(tasks);
> for (Future<ActionExecutorContext> result : futures) {
> if (result == null) {
> submitJobByQueuing = true;
> continue;
> }
> ActionExecutorContext context = result.get();
> Map<String, String> contextVariableMap =
> ((ForkedActionExecutorContext) context).getContextMap();
> LOG.debug("contextVariableMap size of action " +
> context.getAction().getId() + " is " + contextVariableMap.size());
> for (String key : contextVariableMap.keySet()) {
> context.setVarToWorkflow(key,
> contextVariableMap.get(key));
> }
> {code}
> The logic for writing to the temporary map is incorrect. It should be
> {code}
> public void setVar(String name, String value) {
> if (value == null) {
> contextVariableMap.remove(name);
> }
> else {
> contextVariableMap.put(name, value);
> }
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
