[
https://issues.apache.org/jira/browse/OOZIE-2984?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16098323#comment-16098323
]
Peter Bacsko commented on OOZIE-2984:
-------------------------------------
Can we have some explanation in the patch? I found it hard to understand what
certain methods do. Eg. what's {{unquoteWholeSentenceOnly()}} ? Plus, we won't
remember this in a couple of months' time.
I'm also against the complex regexps defined in the patch. If we ever have to
modify those, we'll be in trouble. Can't this be done differently? At the very
least, we can give some examples to demonstrate what a given regexp matches.
> Parse spark-defaults.conf values with spaces without needing the quotes
> -----------------------------------------------------------------------
>
> Key: OOZIE-2984
> URL: https://issues.apache.org/jira/browse/OOZIE-2984
> Project: Oozie
> Issue Type: Bug
> Affects Versions: 4.3.0
> Reporter: Fahd Siddiqui
> Assignee: Andras Piros
> Fix For: 5.0.0
>
> Attachments: OOZIE-2984.001.patch
>
>
> Oozie requires multiple java opts to be enclosed in quotes. For example:
> {code}
> spark.driver.extraJavaOptions="-Xmn2703m -XX:SurvivorRatio=2
> -XX:ParallelGCThreads=20"
> {code}
> However the above breaks spark-shell.
> {code}
> $ ./spark2-shell
> Invalid initial young generation size: -Xmn2212m -XX:SurvivorRatio=2
> -XX:ParallelGCThreads=20
> Error: Could not create the Java Virtual Machine.
> Error: A fatal exception has occurred. Program will exit.
> {code}
> To fix spark-shell, we have to remove the quotes, which errors out Oozie:
> {code}
> Error: Unrecognized option '-XX:SurvivorRatio=2'
> ...
> --conf
> spark.executor.extraJavaOptions=-Xmn2703m
> -Dlog4j.configuration=spark-log4j.properties
> -XX:SurvivorRatio=2
> {code}
> Oozie should be able to parse spark-defaults.conf values with spaces without
> needing the quotes.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
