> On Aug. 10, 2017, 12:21 p.m., Peter Bacsko wrote: > > sharelib/oozie/src/main/java/org/apache/oozie/action/hadoop/LauncherMain.java > > Lines 463 (patched) > > <https://reviews.apache.org/r/61460/diff/1/?file=1790565#file1790565line471> > > > > Is the package private visibility intentional?
We're using these from subclasses in the same package. I can make them protected so other Mains can use them in the future. - Peter ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61460/#review182576 ----------------------------------------------------------- On Aug. 7, 2017, 2:51 p.m., Peter Cseh wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61460/ > ----------------------------------------------------------- > > (Updated Aug. 7, 2017, 2:51 p.m.) > > > Review request for oozie and Attila Sasvari. > > > Bugs: OOZIE-2858 > https://issues.apache.org/jira/browse/OOZIE-2858 > > > Repository: oozie-git > > > Description > ------- > > OOZIE-2858 > HiveMain, ShellMain and SparkMain should not overwrite properties and config > files locally > > > Diffs > ----- > > > sharelib/distcp/src/main/java/org/apache/oozie/action/hadoop/DistcpMain.java > d17d5beb76754655720a0e29079daf676c507841 > sharelib/hive/src/main/java/org/apache/oozie/action/hadoop/HiveMain.java > fb3fabf027a1dda537d2bd86d574abaf95a685db > > sharelib/oozie/src/main/java/org/apache/oozie/action/hadoop/LauncherMain.java > f1f52c6e876fae56c90979baef3d31a0f5ba2396 > > sharelib/oozie/src/main/java/org/apache/oozie/action/hadoop/MapReduceMain.java > 77aaa62e23185e6df053f01fd1c4db1f2e972f6b > > sharelib/oozie/src/main/java/org/apache/oozie/action/hadoop/PasswordMasker.java > 6a73bf9b8b1d0c5cbb008594c75c9e779298a29d > sharelib/pig/src/main/java/org/apache/oozie/action/hadoop/PigMain.java > 13ee04f4482471b61ee363f9cb98f04436c9e580 > sharelib/spark/src/main/java/org/apache/oozie/action/hadoop/SparkMain.java > 8aa8343cfcfa136aedef0bf9d53fb4a11800e07c > sharelib/sqoop/src/main/java/org/apache/oozie/action/hadoop/SqoopMain.java > e889ef9f857e8417353f28ccb8870f9d843a9d33 > > > Diff: https://reviews.apache.org/r/61460/diff/1/ > > > Testing > ------- > > > Thanks, > > Peter Cseh > >
