[
https://issues.apache.org/jira/browse/OOZIE-3031?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Purshotam Shah updated OOZIE-3031:
----------------------------------
Description:
{code:title=CoordActionInputCheckXCommand.java}
else if (!isTimeout(currentTime)) {
if (!status) {
long addtionalDelay = isChangeInDependency ? 0
:
ConfigurationService.getInt(CONF_COORD_INPUT_CHECK_REQUEUE_INTERVAL_ADDITIONAL_DELAY)
* 1000L;
queue(new
CoordActionInputCheckXCommand(coordAction.getId(), coordAction.getJobId()),
addtionalDelay +
getCoordInputCheckRequeueInterval());
}
updateCoordAction(coordAction, isChangeInDependency);
}
else {
if (!nonExistListStr.isEmpty() && isPushDependenciesMet) {
queue(new CoordActionTimeOutXCommand(coordAction,
coordJob.getUser(), coordJob.getAppName()));
}
else {
// Let CoordPushDependencyCheckXCommand queue the timeout
queue(new
CoordPushDependencyCheckXCommand(coordAction.getId()));
}
updateCoordAction(coordAction, isChangeInDependency);
}
}
{code}
{{!nonExistList Str.isEmpty()}} check is unnecessary, once the action has
passed the timeout, it should be marked as timedout.
was:
{code}
else if (!isTimeout(currentTime)) {
if (!status) {
long addtionalDelay = isChangeInDependency ? 0
:
ConfigurationService.getInt(CONF_COORD_INPUT_CHECK_REQUEUE_INTERVAL_ADDITIONAL_DELAY)
* 1000L;
queue(new
CoordActionInputCheckXCommand(coordAction.getId(), coordAction.getJobId()),
addtionalDelay +
getCoordInputCheckRequeueInterval());
}
updateCoordAction(coordAction, isChangeInDependency);
}
else {
if (!nonExistListStr.isEmpty() && isPushDependenciesMet) {
queue(new CoordActionTimeOutXCommand(coordAction,
coordJob.getUser(), coordJob.getAppName()));
}
else {
// Let CoordPushDependencyCheckXCommand queue the timeout
queue(new
CoordPushDependencyCheckXCommand(coordAction.getId()));
}
updateCoordAction(coordAction, isChangeInDependency);
}
}
{code}
{{!nonExistList Str.isEmpty()}} check is unnecessary, once the action has
passed the timeout, it should be marked as timedout.
> Coord job with only unresolved dependencies doesn't timeout
> -----------------------------------------------------------
>
> Key: OOZIE-3031
> URL: https://issues.apache.org/jira/browse/OOZIE-3031
> Project: Oozie
> Issue Type: Bug
> Reporter: Purshotam Shah
> Assignee: Purshotam Shah
> Priority: Critical
>
> {code:title=CoordActionInputCheckXCommand.java}
> else if (!isTimeout(currentTime)) {
> if (!status) {
> long addtionalDelay = isChangeInDependency ? 0
> :
> ConfigurationService.getInt(CONF_COORD_INPUT_CHECK_REQUEUE_INTERVAL_ADDITIONAL_DELAY)
> * 1000L;
> queue(new
> CoordActionInputCheckXCommand(coordAction.getId(), coordAction.getJobId()),
> addtionalDelay +
> getCoordInputCheckRequeueInterval());
> }
> updateCoordAction(coordAction, isChangeInDependency);
> }
> else {
> if (!nonExistListStr.isEmpty() && isPushDependenciesMet) {
> queue(new CoordActionTimeOutXCommand(coordAction,
> coordJob.getUser(), coordJob.getAppName()));
> }
> else {
> // Let CoordPushDependencyCheckXCommand queue the timeout
> queue(new
> CoordPushDependencyCheckXCommand(coordAction.getId()));
> }
> updateCoordAction(coordAction, isChangeInDependency);
> }
> }
> {code}
> {{!nonExistList Str.isEmpty()}} check is unnecessary, once the action has
> passed the timeout, it should be marked as timedout.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
