[ https://issues.apache.org/jira/browse/OOZIE-2858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16128770#comment-16128770 ]
Hadoop QA commented on OOZIE-2858: ---------------------------------- Testing JIRA OOZIE-2858 Cleaning local git workspace ---------------------------- {color:green}+1 PATCH_APPLIES{color} {color:green}+1 CLEAN{color} {color:green}+1 RAW_PATCH_ANALYSIS{color} . {color:green}+1{color} the patch does not introduce any @author tags . {color:green}+1{color} the patch does not introduce any tabs . {color:green}+1{color} the patch does not introduce any trailing spaces . {color:green}+1{color} the patch does not introduce any line longer than 132 . {color:green}+1{color} the patch does adds/modifies 1 testcase(s) {color:green}+1 RAT{color} . {color:green}+1{color} the patch does not seem to introduce new RAT warnings {color:green}+1 JAVADOC{color} . {color:green}+1{color} the patch does not seem to introduce new Javadoc warnings . {color:red}WARNING{color}: the current HEAD has 77 Javadoc warning(s) {color:green}+1 COMPILE{color} . {color:green}+1{color} HEAD compiles . {color:green}+1{color} patch compiles . {color:green}+1{color} the patch does not seem to introduce new javac warnings {color:red}-1{color} There are [2] new bugs found below threshold in total that must be fixed. . {color:green}+1{color} There are no new bugs found in [client]. . {color:green}+1{color} There are no new bugs found in [sharelib/hive]. . {color:green}+1{color} There are no new bugs found in [sharelib/sqoop]. . {color:green}+1{color} There are no new bugs found in [sharelib/spark]. . {color:green}+1{color} There are no new bugs found in [sharelib/streaming]. . {color:green}+1{color} There are no new bugs found in [sharelib/hive2]. . {color:red}-1{color} There are [2] new bugs found below threshold in [sharelib/oozie] that must be fixed. . You can find the FindBugs diff here (look for the red and orange ones): sharelib/oozie/findbugs-new.html . The most important FindBugs errors are: . At LauncherMain.java:[line 471]: File(...) reads a file whose location might be specified by user input . At LauncherMain.java:[line 461]: File(...) reads a file whose location might be specified by user input . {color:green}+1{color} There are no new bugs found in [sharelib/hcatalog]. . {color:green}+1{color} There are no new bugs found in [sharelib/pig]. . {color:green}+1{color} There are no new bugs found in [sharelib/distcp]. . {color:green}+1{color} There are no new bugs found in [docs]. . {color:green}+1{color} There are no new bugs found in [server]. . {color:green}+1{color} There are no new bugs found in [core]. . {color:green}+1{color} There are no new bugs found in [examples]. . {color:green}+1{color} There are no new bugs found in [tools]. {color:green}+1 BACKWARDS_COMPATIBILITY{color} . {color:green}+1{color} the patch does not change any JPA Entity/Colum/Basic/Lob/Transient annotations . {color:green}+1{color} the patch does not modify JPA files {color:green}+1 TESTS{color} . Tests run: 2012 . Tests rerun: 15 . Tests failed at first run: org.apache.oozie.jms.TestJMSJobEventListener, {color:green}+1 DISTRO{color} . {color:green}+1{color} distro tarball builds with the patch ---------------------------- {color:red}*-1 Overall result, please check the reported -1(s)*{color} {color:red}. There is at least one warning, please check{color} The full output of the test-patch run is available at . https://builds.apache.org/job/oozie-trunk-precommit-build/4040/ > HiveMain, ShellMain and SparkMain should not overwrite properties and config > files locally > ------------------------------------------------------------------------------------------ > > Key: OOZIE-2858 > URL: https://issues.apache.org/jira/browse/OOZIE-2858 > Project: Oozie > Issue Type: Bug > Reporter: Peter Cseh > Assignee: Peter Cseh > Attachments: OOZIE-2858-001.patch, OOZIE-2858-002.patch, > OOZIE-2858-003.patch > > > We're generating files on the fly in many of our *Main classes. > These are usually log4j.properties and hive-site.xml files (there may be > others, but these are the ones I managed to find). > We should check if these files are there in advance and don't overwrite them > if they are present. We could log a warning in this case or merge the > contents of the files with the things we want to write into it. There is an > example for this in PigMain and log4j.properties. -- This message was sent by Atlassian JIRA (v6.4.14#64029)