----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61560/#review183516 -----------------------------------------------------------
core/src/main/java/org/apache/oozie/action/hadoop/CredentialsProviderFactory.java Lines 81 (patched) <https://reviews.apache.org/r/61560/#comment259524> Is the current time necessary? I think kind and service should be enough (IIRC that's what we use today somewhere). We shouldn't ever need to different tokens with the same kind and service as far as I can tell. core/src/main/java/org/apache/oozie/action/hadoop/HCatCredentialHelper.java Line 66 (original), 65 (patched) <https://reviews.apache.org/r/61560/#comment259526> Have we verified that HCat/HMS is okay with changing the alias? I don't know if maybe they were doing something funny with it. core/src/main/java/org/apache/oozie/action/hadoop/Hive2Credentials.java Line 82 (original), 81 (patched) <https://reviews.apache.org/r/61560/#comment259527> Have we verified that HS2 is okay with changing the alias? I don't know if maybe they were doing something funny with it. sharelib/oozie/src/main/java/org/apache/oozie/action/hadoop/LauncherAM.java Lines 141 (patched) <https://reviews.apache.org/r/61560/#comment259525> Probably need a space " " between these? - Robert Kanter On Aug. 10, 2017, 5:21 p.m., Peter Cseh wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61560/ > ----------------------------------------------------------- > > (Updated Aug. 10, 2017, 5:21 p.m.) > > > Review request for oozie, Attila Sasvari, Peter Bacsko, Robert Kanter, and > Rohini Palaniswamy. > > > Bugs: OOZIE-2909 > https://issues.apache.org/jira/browse/OOZIE-2909 > > > Repository: oozie-git > > > Description > ------- > > Changing UGI calls and cleaning up things around requesting tokens. > > > Diffs > ----- > > > core/src/main/java/org/apache/oozie/action/hadoop/CredentialsProviderFactory.java > 5ca8d3e80942840a5bba51a06694350929044042 > core/src/main/java/org/apache/oozie/action/hadoop/HCatCredentialHelper.java > 9804c7b673a899cd9c778850c9a64731cc642fb3 > core/src/main/java/org/apache/oozie/action/hadoop/HbaseCredentials.java > 4add5f14cb20ab77c755b81eff939335c0c5fddc > core/src/main/java/org/apache/oozie/action/hadoop/Hive2Credentials.java > 0b495f75842b0033a3337ef6728a334bf5651770 > core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java > dc17950418ada9b4848ed5597702a29e7124ab38 > core/src/main/java/org/apache/oozie/service/HadoopAccessorService.java > b507c79d44aa2095caf532a5f4d19d20c1a30630 > sharelib/oozie/src/main/java/org/apache/oozie/action/hadoop/LauncherAM.java > 6a98d6ef3a09a7a75272f3f0f9a9c2fc5472e76d > > sharelib/oozie/src/test/java/org/apache/oozie/action/hadoop/TestLauncherAM.java > 37af3dd9ed43f4504ff3909484237e2d05665c6c > > > Diff: https://reviews.apache.org/r/61560/diff/1/ > > > Testing > ------- > > We're running tests on a Kerberized cluster with these changes. > > > Thanks, > > Peter Cseh > >
