[ https://issues.apache.org/jira/browse/OOZIE-2687?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16162306#comment-16162306 ]
Hadoop QA commented on OOZIE-2687: ---------------------------------- Testing JIRA OOZIE-2687 Cleaning local git workspace ---------------------------- {color:green}+1 PATCH_APPLIES{color} {color:green}+1 CLEAN{color} {color:red}-1 RAW_PATCH_ANALYSIS{color} . {color:green}+1{color} the patch does not introduce any @author tags . {color:green}+1{color} the patch does not introduce any tabs . {color:green}+1{color} the patch does not introduce any trailing spaces . {color:red}-1{color} the patch contains 6 line(s) longer than 132 characters . {color:green}+1{color} the patch does adds/modifies 9 testcase(s) {color:green}+1 RAT{color} . {color:green}+1{color} the patch does not seem to introduce new RAT warnings {color:green}+1 JAVADOC{color} . {color:green}+1{color} the patch does not seem to introduce new Javadoc warnings . {color:red}WARNING{color}: the current HEAD has 77 Javadoc warning(s) {color:red}-1 COMPILE{color} . {color:green}+1{color} HEAD compiles . {color:green}+1{color} patch compiles . {color:red}-1{color} the patch seems to introduce 1 new javac warning(s) {color:red}-1{color} There are [2] new bugs found below threshold in total that must be fixed. . {color:green}+1{color} There are no new bugs found in [server]. . {color:green}+1{color} There are no new bugs found in [client]. . {color:red}-1{color} There are [2] new bugs found below threshold in [core] that must be fixed. . You can find the FindBugs diff here (look for the red and orange ones): core/findbugs-new.html . The most important FindBugs errors are: . At JavaActionExecutor.java:[line 879]: Dead store to jobName in org.apache.oozie.action.hadoop.JavaActionExecutor.createLauncherConf(FileSystem, ActionExecutor$Context, WorkflowAction, Element, Configuration) . At Input.java:[line 103]: Found reliance on default encoding in org.apache.oozie.util.schema.Input.getStringData(): new String(byte[]) . {color:green}+1{color} There are no new bugs found in [docs]. . {color:green}+1{color} There are no new bugs found in [tools]. . {color:green}+1{color} There are no new bugs found in [examples]. . {color:green}+1{color} There are no new bugs found in [sharelib/streaming]. . {color:green}+1{color} There are no new bugs found in [sharelib/sqoop]. . {color:green}+1{color} There are no new bugs found in [sharelib/distcp]. . {color:green}+1{color} There are no new bugs found in [sharelib/oozie]. . {color:green}+1{color} There are no new bugs found in [sharelib/hcatalog]. . {color:green}+1{color} There are no new bugs found in [sharelib/hive]. . {color:green}+1{color} There are no new bugs found in [sharelib/hive2]. . {color:green}+1{color} There are no new bugs found in [sharelib/pig]. . {color:green}+1{color} There are no new bugs found in [sharelib/spark]. {color:green}+1 BACKWARDS_COMPATIBILITY{color} . {color:green}+1{color} the patch does not change any JPA Entity/Colum/Basic/Lob/Transient annotations . {color:green}+1{color} the patch does not modify JPA files {color:green}+1 TESTS{color} . Tests run: 2029 . Tests rerun: 66 . Tests failed at first run: org.apache.oozie.action.hadoop.TestJavaActionExecutor,org.apache.oozie.jms.TestJMSJobEventListener, {color:green}+1 DISTRO{color} . {color:green}+1{color} distro tarball builds with the patch ---------------------------- {color:red}*-1 Overall result, please check the reported -1(s)*{color} {color:red}. There is at least one warning, please check{color} The full output of the test-patch run is available at . https://builds.apache.org/job/PreCommit-OOZIE-Build/11/ > Create XML schema for launcher configurations > --------------------------------------------- > > Key: OOZIE-2687 > URL: https://issues.apache.org/jira/browse/OOZIE-2687 > Project: Oozie > Issue Type: Sub-task > Affects Versions: 5.0.0 > Reporter: Peter Cseh > Assignee: Attila Sasvari > Priority: Critical > Attachments: OOZIE-2687-001.patch, OOZIE-2687-002.patch, > OOZIE-2687-003.patch, OOZIE-2687-008.patch, OOZIE-2687-009.patch > > > It was possible to manipulate the MapperLauncher's environment through > properties like: > # mapreduce.map.memory.mb > # mapreduce.map.cpu.vcores > # mapred.child.env > # mapred.child.java.opts > # mapred.job.queue.name - ability to set launcher queue > E.g. We were using mapred.child.env to pass SPARK_HOME to the LauncherMapper > and make PySpark work. > Fixing OOZIE-2596 added a hack. We should decide how we support or break > compatibility and how we allow the manipulation of the Launcher environment. > Verify if the new launcher section in global applies to actions in > sub-workflows as well. It did not use to work before and was only fixed in > OOZIE-2030. It would be good to have that testcase > (TestSubWorkflowActionExecutor. testParentGlobalConf) updated with the new > launcher section as well. -- This message was sent by Atlassian JIRA (v6.4.14#64029)