> On Sept. 11, 2017, 11:36 p.m., Robert Kanter wrote: > > client/src/main/resources/oozie-workflow-1.0.xsd > > Line 234 (original), 234 (patched) > > <https://reviews.apache.org/r/61529/diff/8-9/?file=1818281#file1818281line234> > > > > Should we think about moving the Java, MR, Pig, etc actions out of the > > workflow XSD and into their own XSDs to be more consistent with the other > > action types? The 1.0 XSD schemas is a good opportunity. > > > > The downside would be backwards compatibility where you can't simply > > update your workflow schema version on an existing workflow like you > > typically could in the past - you'd also have to add the xmlns string for > > these actions. > > > > I think it would be okay to force people to add the xmlns. No other > > changes should be needed so it's pretty minimal. Plus, Oozie still accepts > > the 0.x schemas, so you don't *have* to upgrade the schemas to 1.0 anyway. > > > > Attila, Geza, what do you think? > > Attila Sasvari wrote: > For this purpose I created > https://issues.apache.org/jira/browse/OOZIE-3033 (this patch is already quite > big).
As this is a breaking change I'd rather fix this in a later jira. I think we can get away using 1.0 as a version and doing big changes like that in follow-up steps. - Peter ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61529/#review185128 ----------------------------------------------------------- On Sept. 13, 2017, 1:45 p.m., Attila Sasvari wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61529/ > ----------------------------------------------------------- > > (Updated Sept. 13, 2017, 1:45 p.m.) > > > Review request for oozie and Peter Cseh. > > > Repository: oozie-git > > > Description > ------- > > New workflow xsd to allow changing launcher configuration (e.g. setting java > system properties) > > > Diffs > ----- > > client/src/main/resources/hive-action-1.0.xsd PRE-CREATION > client/src/main/resources/hive2-action-1.0.xsd PRE-CREATION > client/src/main/resources/oozie-common-1.0.xsd PRE-CREATION > client/src/main/resources/oozie-workflow-1.0.xsd PRE-CREATION > client/src/main/resources/shell-action-1.0.xsd PRE-CREATION > client/src/main/resources/spark-action-1.0.xsd PRE-CREATION > client/src/main/resources/sqoop-action-1.0.xsd PRE-CREATION > core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java > 49fd4b8560b21aef725c3268f0ec0e7f46a46ee9 > core/src/main/java/org/apache/oozie/action/hadoop/SqoopActionExecutor.java > 8fdc50cce15271c13b20d1aaab2ffb95cb8fa711 > core/src/main/java/org/apache/oozie/action/ssh/SshActionExecutor.java > 7e3348550e2ef44ae4bd6c5a7a417052bf9c108a > core/src/main/java/org/apache/oozie/jms/MessageReceiver.java > 47bfd2bcf9b53eed0882c51cdb5c530e0f6ccfe7 > core/src/main/java/org/apache/oozie/service/LiteWorkflowStoreService.java > ffc29af2f834da6d0890ea7215c5a62fd7cd693e > core/src/main/java/org/apache/oozie/service/SchemaService.java > 137e2c0b4840c6d3858683db1aa38f54bd55be92 > core/src/main/java/org/apache/oozie/util/WritableUtils.java > aa027e37ba23d4f481698e0bcd93c26c763a0b1f > core/src/main/java/org/apache/oozie/util/schema/Input.java PRE-CREATION > core/src/main/java/org/apache/oozie/util/schema/ResourceResolver.java > PRE-CREATION > > core/src/main/java/org/apache/oozie/workflow/lite/LauncherConfigHandler.java > PRE-CREATION > > core/src/main/java/org/apache/oozie/workflow/lite/LiteWorkflowAppParser.java > a74e5c759fe3e336e7e98c61b8f5ac52efa4100c > core/src/main/java/org/apache/oozie/workflow/lite/LiteWorkflowLib.java > 23df0867e5984c518e8424d79365997bec28f619 > core/src/main/resources/oozie-default.xml > 0d174b5069aff36ca3a9d48722c5bba69623a046 > > core/src/test/java/org/apache/oozie/action/hadoop/ActionExecutorTestCase.java > d74160a09ee237f4067e00ded526e7ec94528a6b > core/src/test/java/org/apache/oozie/action/hadoop/LauncherMainTester.java > 6cee7a8948ca7f2c7aaf44d4f172d18a1308a482 > > core/src/test/java/org/apache/oozie/action/hadoop/TestJavaActionExecutor.java > d1d78fd527a425b076edd7bb23ba56ebdba62664 > core/src/test/java/org/apache/oozie/service/TestSchemaService.java > 88a10dbead32879334c3953a90a411a3a18fc0b3 > core/src/test/java/org/apache/oozie/util/TestMetricsInstrumentation.java > a882c82b25154338f89e8a90f831b6f0300fbfe7 > > core/src/test/java/org/apache/oozie/workflow/lite/TestLiteWorkflowAppParser.java > 21332404bea79fe0a3cea045d57b3e52a1f15cae > core/src/test/resources/wf-schema-global-launcherconf-override.xml > PRE-CREATION > core/src/test/resources/wf-schema-global-launcherconf.xml PRE-CREATION > pom.xml db18f30814b9b6a73ba872c2cd7946692d0b876b > sharelib/oozie/src/main/java/org/apache/oozie/action/hadoop/LauncherAM.java > 6a98d6ef3a09a7a75272f3f0f9a9c2fc5472e76d > sharelib/pig/src/test/java/org/apache/oozie/action/hadoop/UDFTester.java > ff999ff2cd4875fbf3ad5e1a7eacf9972e848630 > > > Diff: https://reviews.apache.org/r/61529/diff/11/ > > > Testing > ------- > > - TestJavaActionExecutor, TestLiteWorkflowAppParser tests passed > - java-main example on pseudo hadoop succeeded, modified workflow xml so that > verbose class loading information is printed out of stdout of the launcher job > > > Thanks, > > Attila Sasvari > >
