> On Sept. 23, 2017, 1:18 p.m., Peter Bacsko wrote: > > tools/src/main/java/org/apache/oozie/tools/OozieDiagBundleCollector.java > > Lines 250 (patched) > > <https://reviews.apache.org/r/62459/diff/3/?file=1832850#file1832850line250> > > > > Do we need Integer instead of int?
Findbugs found an issue about boxing/unboxing that is why it returns an Integer. > On Sept. 23, 2017, 1:18 p.m., Peter Bacsko wrote: > > tools/src/main/java/org/apache/oozie/tools/OozieDiagBundleCollector.java > > Lines 258 (patched) > > <https://reviews.apache.org/r/62459/diff/3/?file=1832850#file1832850line258> > > > > Do we need Integer instead of int? See my reply above - Attila ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62459/#review186052 ----------------------------------------------------------- On Sept. 22, 2017, 12:50 p.m., Attila Sasvari wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62459/ > ----------------------------------------------------------- > > (Updated Sept. 22, 2017, 12:50 p.m.) > > > Review request for oozie. > > > Repository: oozie-git > > > Description > ------- > > A diagnostic tool that collects a bunch of job and other information from > Oozie in a zip file. > > > Diffs > ----- > > docs/src/site/twiki/DG_CommandLineTool.twiki > d4047671876dcc3279a2ec379bc1d003f5e6f1aa > pom.xml efccc346932514ada578a3462eb3c3cfe519a323 > tools/pom.xml 7306a14e7b237977be00f8fe28e34573540fd508 > tools/src/main/bin/oozie-diag-bundle-collector.sh PRE-CREATION > tools/src/main/java/org/apache/oozie/tools/OozieDiagBundleCollector.java > PRE-CREATION > > tools/src/test/java/org/apache/oozie/tools/TestOozieDiagBundleCollector.java > PRE-CREATION > > > Diff: https://reviews.apache.org/r/62459/diff/3/ > > > Testing > ------- > > - new unit tests: TestOozieDiagBundleCollector > - started Oozie with a pseudo hadoop cluster, submitted a couple workflows, > and executed the following commands: > -- ``bin/oozie-diag-bundle-collector.sh`` (usage info printed), > -- ``bin/oozie-diag-bundle-collector.sh -numworkflows 2000 -oozie > http://localhost:11000/oozie -output /tmp``, > -- ``bin/oozie-diag-bundle-collector.sh -jobs > 0000001-170918144116149-oozie-asas-W -oozie http://localhost:11000/oozie > -output .`` (verified zip the tool generated). > > > Thanks, > > Attila Sasvari > >
