[
https://issues.apache.org/jira/browse/OOZIE-3072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16187967#comment-16187967
]
Peter Bacsko commented on OOZIE-3072:
-------------------------------------
{noformat}
+ assertEquals("MapReduce's default value changed", "4",
conf.get("mapreduce.map.maxattempts"));
+ ae.setupActionConf(conf, context, actionXml, new
Path(context.getWorkflow().getAppPath()));
+ assertEquals("action.bar", conf.get("action.foo"));
+ assertEquals("action.barbar",
conf.get("oozie.launcher.action.foofoo"));
+ assertEquals("Maxattempts should've been overwritten", "1",
+ conf.get("mapreduce.map.maxattempts"));
{noformat}
1. First message says "value changed", but isn't that what you're expecting
here?
2. You can use {{conf.getInt()}} (not that it really matters)
3. Assertion message is missing for the next two {{assertEquals()}} calls
4. Minor: you verify maxAttempts twice, perhaps a little bit more consistent
assertion messages would be better
> oozie.service.HadoopAccessorService.action.configurations should
> overwrite default values set in Hadoop's configuration files
> ------------------------------------------------------------------------------------------------------------------------------
>
> Key: OOZIE-3072
> URL: https://issues.apache.org/jira/browse/OOZIE-3072
> Project: Oozie
> Issue Type: Bug
> Reporter: Peter Cseh
> Assignee: Peter Cseh
> Attachments: OOZIE-3072.001.patch
>
>
> When Oozie process the files defined in
> oozie.service.HadoopAccessorService.action.configurations it uses
> Configuration.injectDefauts(). This prevents overwriting things defined
> inside any of the configuration files Oozie is providing default values from
> (like yarn-site.xml, mapred-site.xml)
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
