----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62459/#review187223 -----------------------------------------------------------
docs/src/site/twiki/DG_CommandLineTool.twiki Lines 1989 (patched) <https://reviews.apache.org/r/62459/#comment264151> Shouldn't this "Done" show up on the previous line like the rest of them? tools/src/main/java/org/apache/oozie/tools/diag/AppInfoCollector.java Lines 173-174 (patched) <https://reviews.apache.org/r/62459/#comment264153> ````LogAggregationUtils```` is marked ````@Private```` so we shouldn't be using it. Hadoop can change things incompatibly here. tools/src/main/java/org/apache/oozie/tools/diag/AppInfoCollector.java Lines 180 (patched) <https://reviews.apache.org/r/62459/#comment264152> ````var20```` is a funny name for a variable :) tools/src/main/java/org/apache/oozie/tools/diag/AppInfoCollector.java Lines 241 (patched) <https://reviews.apache.org/r/62459/#comment264155> ````storeOozieLauncherLog```` should be called per Action, not per Job. Launcher logs are an Action-level concept. Here, you're just picking the first action's external id to use for the job, which may not even exist (e.g. the first action is a decision node or an hdfs node. tools/src/main/java/org/apache/oozie/tools/diag/AppInfoCollector.java Lines 242 (patched) <https://reviews.apache.org/r/62459/#comment264154> We should get this from the ````WorkflowJob````. The log reading code computes a path based on the user who ran the job, which is likely to be different from the user running this tool. - Robert Kanter On Oct. 4, 2017, 2:18 p.m., Attila Sasvari wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62459/ > ----------------------------------------------------------- > > (Updated Oct. 4, 2017, 2:18 p.m.) > > > Review request for oozie. > > > Repository: oozie-git > > > Description > ------- > > A diagnostic tool that collects a bunch of job and other information from > Oozie in a zip file. > > > Diffs > ----- > > docs/src/site/twiki/DG_CommandLineTool.twiki > d4047671876dcc3279a2ec379bc1d003f5e6f1aa > pom.xml 0b94484da1c97618e9168cea0ebbfff7f70f723c > tools/pom.xml 7306a14e7b237977be00f8fe28e34573540fd508 > tools/src/main/bin/oozie-diag-bundle-collector.sh PRE-CREATION > tools/src/main/java/org/apache/oozie/tools/diag/AppInfoCollector.java > PRE-CREATION > tools/src/main/java/org/apache/oozie/tools/diag/ArgParser.java PRE-CREATION > > tools/src/main/java/org/apache/oozie/tools/diag/DiagBundleCollectorDriver.java > PRE-CREATION > tools/src/main/java/org/apache/oozie/tools/diag/DiagBundleCompressor.java > PRE-CREATION > tools/src/main/java/org/apache/oozie/tools/diag/DiagBundleEntryWriter.java > PRE-CREATION > tools/src/main/java/org/apache/oozie/tools/diag/DiagOozieClient.java > PRE-CREATION > tools/src/main/java/org/apache/oozie/tools/diag/MetricsCollector.java > PRE-CREATION > tools/src/main/java/org/apache/oozie/tools/diag/ServerInfoCollector.java > PRE-CREATION > tools/src/test/java/org/apache/oozie/tools/diag/TestAppInfoCollector.java > PRE-CREATION > tools/src/test/java/org/apache/oozie/tools/diag/TestArgParser.java > PRE-CREATION > tools/src/test/java/org/apache/oozie/tools/diag/TestMetricsCollector.java > PRE-CREATION > > tools/src/test/java/org/apache/oozie/tools/diag/TestServerInfoCollector.java > PRE-CREATION > > > Diff: https://reviews.apache.org/r/62459/diff/10/ > > > Testing > ------- > > - new unit tests: TestOozieDiagBundleCollector > - started Oozie with a pseudo hadoop cluster, submitted a couple workflows, > and executed the following commands: > -- ``bin/oozie-diag-bundle-collector.sh`` (usage info printed), > -- ``bin/oozie-diag-bundle-collector.sh -numworkflows 2000 -oozie > http://localhost:11000/oozie -output /tmp``, > -- ``bin/oozie-diag-bundle-collector.sh -jobs > 0000001-170918144116149-oozie-asas-W -oozie http://localhost:11000/oozie > -output .`` (verified zip the tool generated). > > > Thanks, > > Attila Sasvari > >
