----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53775/#review190154 -----------------------------------------------------------
core/src/main/java/org/apache/oozie/command/coord/CoordMaterializeTransitionXCommand.java Lines 537-559 (patched) <https://reviews.apache.org/r/53775/#comment267400> Would extract to `DaylightOffsetCalculator` and create separate unit test cases. core/src/main/java/org/apache/oozie/command/coord/CoordMaterializeTransitionXCommand.java Lines 538 (patched) <https://reviews.apache.org/r/53775/#comment267399> What if both `start` and `end` are in daylight saving time? In that case, we don't need to change IMO, even if there were an even number of daylight changes in between. core/src/main/java/org/apache/oozie/command/coord/CoordMaterializeTransitionXCommand.java Lines 597-600 (patched) <https://reviews.apache.org/r/53775/#comment267401> Extract method `setStartAndEndTimesToDaylight()`. core/src/test/java/org/apache/oozie/command/coord/TestCoordMaterializeTransitionXCommand.java Line 336 (original), 336 (patched) <https://reviews.apache.org/r/53775/#comment267403> `TimeUnit.HOURS.toSeconds(4)` core/src/test/java/org/apache/oozie/command/coord/TestCoordMaterializeTransitionXCommand.java Line 341 (original), 341 (patched) <https://reviews.apache.org/r/53775/#comment267404> Extract `3` to a well-named local variable. core/src/test/java/org/apache/oozie/command/coord/TestCoordMaterializeTransitionXCommand.java Line 347 (original), 347 (patched) <https://reviews.apache.org/r/53775/#comment267405> Extract `3` to a well-named local variable. core/src/test/java/org/apache/oozie/command/coord/TestCoordMaterializeTransitionXCommand.java Line 372 (original), 372 (patched) <https://reviews.apache.org/r/53775/#comment267453> Extract `5` to a well-named local variable. core/src/test/java/org/apache/oozie/command/coord/TestCoordMaterializeTransitionXCommand.java Lines 636-657 (patched) <https://reviews.apache.org/r/53775/#comment267455> Extract method. core/src/test/java/org/apache/oozie/command/coord/TestCoordMaterializeTransitionXCommand.java Lines 639 (patched) <https://reviews.apache.org/r/53775/#comment267458> Extract method. core/src/test/java/org/apache/oozie/command/coord/TestCoordMaterializeTransitionXCommand.java Lines 648 (patched) <https://reviews.apache.org/r/53775/#comment267459> `TimeUnit.HOURS.toSeconds(1)` core/src/test/java/org/apache/oozie/command/coord/TestCoordMaterializeTransitionXCommand.java Line 634 (original), 659-678 (patched) <https://reviews.apache.org/r/53775/#comment267456> Extract method. core/src/test/java/org/apache/oozie/command/coord/TestCoordMaterializeTransitionXCommand.java Lines 661 (patched) <https://reviews.apache.org/r/53775/#comment267457> Extract method. core/src/test/java/org/apache/oozie/command/coord/TestCoordMaterializeTransitionXCommand.java Lines 670 (patched) <https://reviews.apache.org/r/53775/#comment267460> `TimeUnit.HOURS.toSeconds(1)` core/src/test/java/org/apache/oozie/command/coord/TestCoordMaterializeTransitionXCommand.java Line 941 (original), 985 (patched) <https://reviews.apache.org/r/53775/#comment267454> An explaining Javadoc why we substract would be extremely useful. - András Piros On Nov. 22, 2016, 1:02 a.m., Satish Saley wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53775/ > ----------------------------------------------------------- > > (Updated Nov. 22, 2016, 1:02 a.m.) > > > Review request for oozie. > > > Bugs: OOZIE-2726 > https://issues.apache.org/jira/browse/OOZIE-2726 > > > Repository: oozie-git > > > Description > ------- > > [OOZIE-2726] Flaky test due to daylight saving changes > > > Diffs > ----- > > > core/src/test/java/org/apache/oozie/command/coord/TestCoordMaterializeTransitionXCommand.java > 29e7ca1 > > > Diff: https://reviews.apache.org/r/53775/diff/3/ > > > Testing > ------- > > Tested locally > > > Thanks, > > Satish Saley > >
