[ 
https://issues.apache.org/jira/browse/OOZIE-3114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16248657#comment-16248657
 ] 

Peter Cseh commented on OOZIE-3114:
-----------------------------------

Thanks for the patch! 
It's good to get rid of these warnings.
Some nits:
# In LauncherAMCallbackNotifier.notifyURLOnce - it would be better to say "true 
in case URL is notified successfully"
# can you check what is the content of the returned lists in OozieClient?

> fix for warning: no @return
> ---------------------------
>
>                 Key: OOZIE-3114
>                 URL: https://issues.apache.org/jira/browse/OOZIE-3114
>             Project: Oozie
>          Issue Type: Sub-task
>    Affects Versions: 4.3.0
>         Environment: mvn: 3.5.2
> jdk: 1.8.0.144
> git: cb8f582b4756789f7a7869b6cc5e27f8783886d8
>            Reporter: Artem Ervits
>            Assignee: Artem Ervits
>            Priority: Trivial
>             Fix For: 5.0.0b1
>
>         Attachments: OOZIE-3114-3.patch, OOZIE-3114.patch
>
>
> there are a few instances of warning "warning: no @return"
> {noformat}
> [WARNING] 
> /Users/aervits/NetBeansProjects/OOZIE/oozie/client/src/main/java/org/apache/oozie/client/OozieClient.java:972:
>  warning: no @return
> [WARNING] 
> /Users/aervits/NetBeansProjects/OOZIE/oozie/client/src/main/java/org/apache/oozie/client/OozieClient.java:1820:
>  warning: no @return
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to