----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63837/#review191066 -----------------------------------------------------------
docs/src/site/twiki/DG_SparkActionExtension.twiki Lines 113-116 (patched) <https://reviews.apache.org/r/63837/#comment268663> Nit: I'd invert the order as the overall Hadoop documentation experience dictates: more important / overriding feature first. sharelib/spark/src/main/java/org/apache/oozie/action/hadoop/SparkArgsExtractor.java Lines 337 (patched) <https://reviews.apache.org/r/63837/#comment268651> Typo: `mergeAndAddPropertiesFile()` sharelib/spark/src/main/java/org/apache/oozie/action/hadoop/SparkArgsExtractor.java Lines 342-343 (patched) <https://reviews.apache.org/r/63837/#comment268652> `final boolean persisted` sharelib/spark/src/main/java/org/apache/oozie/action/hadoop/SparkArgsExtractor.java Lines 357 (patched) <https://reviews.apache.org/r/63837/#comment268653> Nit: `return` statement just at the end of `try`, before `catch`. sharelib/spark/src/main/java/org/apache/oozie/action/hadoop/SparkArgsExtractor.java Lines 378-382 (patched) <https://reviews.apache.org/r/63837/#comment268656> Extract method sharelib/spark/src/main/java/org/apache/oozie/action/hadoop/SparkArgsExtractor.java Lines 381 (patched) <https://reviews.apache.org/r/63837/#comment268654> Typo: `Could not...` sharelib/spark/src/main/java/org/apache/oozie/action/hadoop/SparkArgsExtractor.java Lines 387-392 (patched) <https://reviews.apache.org/r/63837/#comment268657> Extract method sharelib/spark/src/main/java/org/apache/oozie/action/hadoop/SparkArgsExtractor.java Lines 390 (patched) <https://reviews.apache.org/r/63837/#comment268655> Typo: `Could not...` sharelib/spark/src/test/java/org/apache/oozie/action/hadoop/TestSparkActionExecutor.java Line 107 (original), 104 (patched) <https://reviews.apache.org/r/63837/#comment268658> When modified, please set it back to a runnable test method: `public void testXXXX()` sharelib/spark/src/test/java/org/apache/oozie/action/hadoop/TestSparkArgsExtractor.java Lines 264 (patched) <https://reviews.apache.org/r/63837/#comment268662> Wow, that's an exhaustive one :) and I can understand how the code works by only looking at the test! sharelib/spark/src/test/java/org/apache/oozie/action/hadoop/TestSparkArgsExtractor.java Lines 323 (patched) <https://reviews.apache.org/r/63837/#comment268660> Nit: ` = new FileWriter(...)` - András Piros On Nov. 15, 2017, 2:55 p.m., Peter Cseh wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63837/ > ----------------------------------------------------------- > > (Updated Nov. 15, 2017, 2:55 p.m.) > > > Review request for oozie. > > > Bugs: OOZIE-3112 > https://issues.apache.org/jira/browse/OOZIE-3112 > > > Repository: oozie-git > > > Description > ------- > > SparkConfigurationService injects the config values as --conf to SparkSubmit. > This will overwrite propties provided in the --properies-file option which is > not the expected behavior. > > > Diffs > ----- > > core/src/main/java/org/apache/oozie/action/hadoop/SparkActionExecutor.java > 80d64ec80e683ea571748c2df976cf6bd22063cd > docs/src/site/twiki/DG_SparkActionExtension.twiki > 45b60b86bee4cfe2de2d374f03b602ddacdc5e65 > > sharelib/spark/src/main/java/org/apache/oozie/action/hadoop/SparkArgsExtractor.java > 052950fa36a0b40f8629ce91c1d135062a6571a9 > > sharelib/spark/src/test/java/org/apache/oozie/action/hadoop/TestSparkActionExecutor.java > d97f1f06b5832b1f09fab30b08ecff31db3221f6 > > sharelib/spark/src/test/java/org/apache/oozie/action/hadoop/TestSparkArgsExtractor.java > 574bf240304379d5d26af8a3e5c079d4ad707b7b > > > Diff: https://reviews.apache.org/r/63837/diff/3/ > > > Testing > ------- > > > Thanks, > > Peter Cseh > >
