[
https://issues.apache.org/jira/browse/OOZIE-3131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16255581#comment-16255581
]
Peter Bacsko commented on OOZIE-3131:
-------------------------------------
Good idea - JAE is huge. YARN-specific code should be factored out to somewhere
else.
My suggestions:
1. Introduce an interface sth like {{ApplicationSubmitter}}
2. Move YARN-specific stuff to another class called {{YARNApplicationSubmitter}}
3. Create a factory like {{ApplicationSubmitterFactory}} which by default
returns {{YARNApplicationSubmitter}}.
> Cut out the creation of AppSubmissionContext from JavaActionExecutor
> --------------------------------------------------------------------
>
> Key: OOZIE-3131
> URL: https://issues.apache.org/jira/browse/OOZIE-3131
> Project: Oozie
> Issue Type: Sub-task
> Reporter: Peter Cseh
>
> JavaActionExecutor is huge and a lot of it is createAppSubmissionContext and
> it's child-functions. This could be pulled out to a AppContextFactory or
> something similar, which could increase testability of this area greatly as
> we could write assertions against the AppContext itself. Right now it's
> nearly impossible to assert what's going inside the AppContext.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)