[ 
https://issues.apache.org/jira/browse/OOZIE-3139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16279670#comment-16279670
 ] 

Abhishek Bafna commented on OOZIE-3139:
---------------------------------------

[~dionusos] Looks good to me. +1.
Can we also include the below scenario. Thanks.


{code}
<workflow-app xmlns="uri:oozie:workflow:0.5" name="test-wf">
    <start to="f1"/>

    <action name="f1">
        <fs>
            <mkdir path='/tmp'/>
        </fs>
        <ok to="f1a1"/>
        <error to="f1a1"/>
    </action>

    <action name="f1a1">
        <fs>
            <mkdir path='/tmp'/>
        </fs>
        <ok to="f1a2"/>
        <error to="f1a3"/>
    </action>

    <action name="f1a2">
        <fs>
            <mkdir path='/tmp'/>
        </fs>
        <ok to="z"/>
        <error to="b"/>
    </action>

    <action name="f1a3">
        <fs>
            <mkdir path='/tmp'/>
        </fs>
        <ok to="b"/>
        <error to="b"/>
    </action>

    <kill name="b">
        <message>kill</message>
    </kill>
    <end name="z"/>
</workflow-app>
{code}


> Oozie validates workflow incorrectly
> ------------------------------------
>
>                 Key: OOZIE-3139
>                 URL: https://issues.apache.org/jira/browse/OOZIE-3139
>             Project: Oozie
>          Issue Type: Bug
>          Components: core
>    Affects Versions: 4.3.0
>            Reporter: Denes Bodo
>            Assignee: Denes Bodo
>            Priority: Critical
>         Attachments: OOZIE-3139.001.patch, OOZIE-3139.002.patch, 
> exception.log, workflow.pdf
>
>
> We found that after OOZIE-1978 the attached workflow becomes invalid. Aa we 
> found out the following line brings the problem: 
> https://github.com/apache/oozie/commit/8e9b9042b3270dc5ff975c44a5c977fcc41250e4#diff-a38ae78886b7c3afb711d32cfb4dbbbdR267
>  . The parameter "okPath" changed from okPath to true.
> The following workflow is problematic:
> {noformat}
> <workflow-app xmlns="uri:oozie:workflow:0.4" name="shell-fork-wf">
>     <start to="fork"/>
>     <fork name="fork">
>         <path start="FA"/>
>         <path start="FB"/>
>     </fork>
>     <action name="FA">
>         <shell xmlns="uri:oozie:shell-action:0.2">
>             <job-tracker>${jobTracker}</job-tracker>
>             <name-node>${nameNode}</name-node>
>             <exec>${myscript}</exec>
>             <file>${myscriptPath}</file>
>             <capture-output/>
>         </shell>
>         <ok to="join"/>
>         <error to="D"/>
>     </action>
>     <action name="FB">
>         <shell xmlns="uri:oozie:shell-action:0.2">
>             <job-tracker>${jobTracker}</job-tracker>
>             <name-node>${nameNode}</name-node>
>             <exec>${myscript}</exec>
>             <file>${myscriptPath}</file>
>             <capture-output/>            
>         </shell>
>         <ok to="join"/>
>         <error to="D"/>
>     </action>
>     <join name="join" to="C" />
>     <action name="C">
>         <shell xmlns="uri:oozie:shell-action:0.2">
>             <job-tracker>${jobTracker}</job-tracker>
>             <name-node>${nameNode}</name-node>
>             <exec>${myscript}</exec>
>             <file>${myscriptPath}</file>
>             <capture-output/>
>         </shell>
>         <ok to="end"/>
>         <error to="D"/>
>     </action>
>     <action name="D">
>         <shell xmlns="uri:oozie:shell-action:0.2">
>             <job-tracker>${jobTracker}</job-tracker>
>             <name-node>${nameNode}</name-node>
>             <exec>${myscript}</exec>
>             <file>${myscriptPath}</file>
>             <capture-output/>
>         </shell>
>         <ok to="E"/>
>         <error to="fail"/>
>     </action>
>     <action name="E">
>         <shell xmlns="uri:oozie:shell-action:0.2">
>             <job-tracker>${jobTracker}</job-tracker>
>             <name-node>${nameNode}</name-node>
>             <exec>${myscript}</exec>
>             <file>${myscriptPath}</file>
>             <capture-output/>
>         </shell>
>         <ok to="fail"/>
>         <error to="fail"/>
>     </action>                                                                 
>                                                
>     <kill name="fail">
>         <message>Shell action failed, error 
> message[${wf:errorMessage(wf:lastErrorNode())}]</message>
>     </kill>
>     <end name="end"/>
> </workflow-app>
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to