[ 
https://issues.apache.org/jira/browse/OOZIE-3085?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16305364#comment-16305364
 ] 

Attila Sasvari commented on OOZIE-3085:
---------------------------------------

[~kmarton] thanks for the new patch, I left some more comments on ReviewBoard. 
Can you try it out on a real cluster? 

[~gezapeti], [~andras.piros]: this JIRA's summary and description feels quite 
general / not focused. The patch uploaded here is mainly focusing on logging 
action _starting_ and _ending_ (not killing). I would either rename it to 
express we are only dealing with logging in start() and end() methods or create 
subtasks. For example, in the SubworkflowActionExecutor there are more things 
that could be interesting to log (e.g. killing a subworkflow action). What do 
you think? At the same time, can you also have a look at the patch? You might 
see something I missed.

> Improve logging in ActionExecutors
> ----------------------------------
>
>                 Key: OOZIE-3085
>                 URL: https://issues.apache.org/jira/browse/OOZIE-3085
>             Project: Oozie
>          Issue Type: Bug
>          Components: core
>    Affects Versions: 4.3.0
>            Reporter: Peter Cseh
>            Assignee: Julia Kinga Marton
>              Labels: newbie
>             Fix For: 5.0.0
>
>         Attachments: OOZIE-3085-001.patch, OOZIE-3085-002.patch, 
> OOZIE-3085-003.patch
>
>
> Decision, ForkJoin, Email and FS ActionExecutors are producing no or very 
> little logs on info level. This makes it hard to gather usage information and 
> help with troubleshooting in the case of any issues. Please improve logging 
> in these classes.
> Several subtasks can be separated out from this one



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to