----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65385/#review196444 -----------------------------------------------------------
tools/src/main/java/org/apache/oozie/tools/OozieDBCLI.java Line 64 (original), 64 (patched) <https://reviews.apache.org/r/65385/#comment276097> It looks like we started using DB version 3 in Oozie 4.1. Instead of ````DB_VERSION_PRE_5_0````, let's rename this to ````DB_VERSION_FOR_4_1````. Also, why are these two not ````private````? tools/src/main/java/org/apache/oozie/tools/OozieDBCLI.java Lines 750 (patched) <https://reviews.apache.org/r/65385/#comment276100> Shouldn't we write the statements to a file in this case? - Robert Kanter On Jan. 29, 2018, 3:04 p.m., Attila Sasvari wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65385/ > ----------------------------------------------------------- > > (Updated Jan. 29, 2018, 3:04 p.m.) > > > Review request for oozie. > > > Repository: oozie-git > > > Description > ------- > > Add indices to speed up SELECT operations. > > > Index user_name column > > for purge service OOZIE-1803: > CREATE INDEX "OOZIEDB"."BUNDLE_JOBS_END_TIME_IDX" ON "BUNDLE_JOBS" > ("END_TIME"); > CREATE INDEX "OOZIEDB"."COORD_JOBS_END_TIME_IDX" ON "COORD_JOBS" ("END_TIME"); > CREATE INDEX "OOZIEDB"."WF_JOBS_END_TIME_IDX" ON "WF_JOBS" ("END_TIME"); > CREATE INDEX "OOZIEDB"."COORD_ACTIONS_JOB_ID_IDX" ON "COORD_ACTIONS" > ("JOB_ID"); > CREATE INDEX "OOZIEDB"."COORD_JOBS_BUNDLE_ID_IDX" ON "COORD_JOBS" > ("BUNDLE_ID"); > CREATE INDEX "OOZIEDB"."WF_ACTIONS_WF_ID_IDX" ON "WF_ACTIONS" ("WF_ID"); > CREATE INDEX "OOZIEDB"."WF_JOBS_PARENT_ID_IDX" ON "WF_JOBS" ("PARENT_ID"); > CREATE INDEX "OOZIEDB"."BUNDLE_ACTIONS_BUNDLE_ID_IDX" ON "BUNDLE_ACTIONS" > ("BUNDLE_ID"); > > Composite indices to speed up operations on the web UI > > > Diffs > ----- > > core/src/main/java/org/apache/oozie/BundleJobBean.java > b42f12841c2f9cb6d508cd2ac2f393e6407d1cf0 > core/src/main/java/org/apache/oozie/CoordinatorJobBean.java > 99c7d3c474d9e1e22e2f5a927c03d71b9292b663 > core/src/main/java/org/apache/oozie/WorkflowJobBean.java > cd9a6df42e552a0607606a244b81978747d89b41 > tools/src/main/java/org/apache/oozie/tools/OozieDBCLI.java > a8b2234966c967f9ad9d722628bd486012b14bd3 > > > Diff: https://reviews.apache.org/r/65385/diff/2/ > > > Testing > ------- > > > Thanks, > > Attila Sasvari > >
