-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65481/
-----------------------------------------------------------
(Updated Feb. 19, 2018, 2:14 p.m.)
Review request for oozie, András Piros and Attila Sasvari.
Repository: oozie-git
Description
-------
Upon SLACalculatorMemory.addRegistration, Oozie puts an entry into an in-memory
concurrent hashmap ("slaMap"), and later persists it in the Oozie database.
However, if there is a failure during the database operation, a
JPAExecutorException is thrown, and the entry is not removed from the SLA map.
It may introduce inconsistency between the Oozie database and the SLA map.
To prevent this, a rollback mechanism (with proper logging) should be
implemented. It would also make sense to do more sanity/consistency check in
the Oozie server.
Diffs (updated)
-----
core/src/main/java/org/apache/oozie/sla/SLACalculatorMemory.java ef019e73
core/src/main/java/org/apache/oozie/util/db/AlwaysFailingHSQLDriverMapper.java
PRE-CREATION
core/src/main/java/org/apache/oozie/util/db/FailingConnectionWrapper.java
0e310253
core/src/main/java/org/apache/oozie/util/db/FailingDBHelperForTest.java
PRE-CREATION
core/src/main/java/org/apache/oozie/util/db/FailingHSQLDBDriverWrapper.java
fe9f08b1
core/src/main/java/org/apache/oozie/util/db/FailingMySQLDriverWrapper.java
f0e2b181
core/src/test/java/org/apache/oozie/sla/TestSLACalculatorMemory.java ee906f45
Diff: https://reviews.apache.org/r/65481/diff/4/
Changes: https://reviews.apache.org/r/65481/diff/3-4/
Testing
-------
Thanks,
Kinga Marton
