[
https://issues.apache.org/jira/browse/OOZIE-3176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16395596#comment-16395596
]
Attila Sasvari commented on OOZIE-3176:
---------------------------------------
[~alishap] thanks for looking into this. Unfortunately, applying the patch
results in
[failure|https://builds.apache.org/job/PreCommit-OOZIE-Build/416/artifact/test-patch/reports/DISTRO.out]
when running {{bin/mkdistro.sh -DskipTests -Puber -DtargetJavaVersion=1.8
-DjavaVersion=1.8}} It should be definitely fixed.
Note: There is only one error in the {{core}} module that breaks checkstyle. It
would be enough to fix header in
{{core/src/main/java/org/apache/oozie/executor/jpa/WorkflowJobsBasicInfoFromParentId.java
}}so that {{mvn clean install -DskipTests}} does not fail with error:
{code:java}
/root/ooziepipe/core/src/main/java/org/apache/oozie/executor/jpa/WorkflowJobsBasicInfoFromParentId.java:10:
Line does not match expected header line of ' *
http://www.apache.org/licenses/LICENSE-2.0'.
{code}
I would probably only fix this. At the same time, I agree having 0 checkstyle
warning is a good thing.
Anyway, If a changeset is large (like the patch uploaded, which is over 300
KB), it is recommended to file a [ReviewBoard|https://reviews.apache.org/]
request (adding {{oozie}} to the review groups) and link it to this JIRA .
Other remarks:
- I know that [How to
contribute|https://cwiki.apache.org/confluence/display/OOZIE/How+To+Contribute]
does not describe a coding style. However, I generally prefer to break a line
before a non-assignment operator. It is also recommended by [Google's Java
style
guide|https://google.github.io/styleguide/javaguide.html#s4.5-line-wrapping]
and [Oracle's code
conventions|http://www.oracle.com/technetwork/java/javase/documentation/codeconventions-136091.html#248]
.
So instead of
{code:java}
LiteWorkflowApp app = new LiteWorkflowApp("name", definition, new
StartNodeDef(LiteWorkflowStoreService.
LiteControlNodeHandler.class, "foo"));
{code}
use
{code:java}
LiteWorkflowApp app = new LiteWorkflowApp("name", definition, new
StartNodeDef(LiteWorkflowStoreService
.LiteControlNodeHandler.class, "foo"));
{code}
or
{code:java}
LiteWorkflowApp app = new LiteWorkflowApp("name", definition, new StartNodeDef(
LiteWorkflowStoreService.LiteControlNodeHandler.class, "foo"));
{code}
- When breaking long comments into multiple lines, I would prefer using {{/**/}}
> Oozie-core fails with checkstyle errors.
> ----------------------------------------
>
> Key: OOZIE-3176
> URL: https://issues.apache.org/jira/browse/OOZIE-3176
> Project: Oozie
> Issue Type: Bug
> Components: core
> Affects Versions: 5.0.0b1
> Environment: # uname -a
> Linux in-ibmibm283.persistent.co.in 3.10.0-229.14.1.el7.x86_64 #1 SMP Tue Aug
> 25 11:21:22 EDT 2015 x86_64 x86_64 x86_64 GNU/Linux
> Reporter: Alisha Prabhu
> Assignee: Alisha Prabhu
> Priority: Minor
> Attachments: Checkstyle-erros.txt, OOZIE-3176-001.patch
>
>
> There are multiple checkstyle violations in the Oozie-core module.
> Maven command used is mvn clean install -DskipTests
> I have attached the Checkstyle-errors.txt file, that has the errors occurred
> while building.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
