> On March 26, 2018, 12:21 p.m., Peter Cseh wrote: > > core/src/main/java/org/apache/oozie/command/coord/DaylightOffsetCalculator.java > > Lines 54-58 (patched) > > <https://reviews.apache.org/r/66262/diff/2/?file=1986973#file1986973line54> > > > > Isn't this handled in getDSTOffset as part of returning 0 there? I > > don't think the performance would require this additional logic, but it > > makes things a bit confusing
Refactored method, and updated class and method level Javadoc as well as unit test cases to have a better understanding what's going on here. - András ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66262/#review199958 ----------------------------------------------------------- On March 24, 2018, 11:53 a.m., András Piros wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66262/ > ----------------------------------------------------------- > > (Updated March 24, 2018, 11:53 a.m.) > > > Review request for oozie, Peter Cseh and Satish Saley. > > > Repository: oozie-git > > > Description > ------- > > [OOZIE-2726] Flaky test due to daylight saving changes. Review request #2. > > Based on the [diff#2](https://reviews.apache.org/r/53775/diff/2#index_header) > of the [review request #1](https://reviews.apache.org/r/53775). > > > Diffs > ----- > > > core/src/main/java/org/apache/oozie/command/coord/CoordMaterializeTransitionXCommand.java > 2b9125387b4e356e408e112c55af7bb3f1c39d3e > > core/src/main/java/org/apache/oozie/command/coord/DaylightOffsetCalculator.java > PRE-CREATION > > core/src/test/java/org/apache/oozie/command/coord/TestCoordMaterializeTransitionXCommand.java > 61bbbfe3d1dde89b875c30c75e875efc9227f05d > > core/src/test/java/org/apache/oozie/command/coord/TestDaylightOffsetCalculator.java > PRE-CREATION > > > Diff: https://reviews.apache.org/r/66262/diff/2/ > > > Testing > ------- > > `TestCoordMaterializeTransitionXCommand`, `TestDaylightOffsetCalculator` > > > Thanks, > > András Piros > >
