----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66610/#review201175 -----------------------------------------------------------
I made minor comments in the code. Overall I think the code formatter was a bit too aggressive and I would use cleaner code, like more classes should be introducesd which have "isAllowed(...)" method instead of multiple switch statement. Otherwise I like it. :) core/src/main/java/org/apache/oozie/service/AuthorizationService.java Line 28 (original), 28 (patched) <https://reviews.apache.org/r/66610/#comment282206> Please do not merge imports with * core/src/main/java/org/apache/oozie/service/AuthorizationService.java Lines 98-101 (patched) <https://reviews.apache.org/r/66610/#comment282207> Please cleanup empty lines core/src/main/java/org/apache/oozie/service/AuthorizationService.java Line 119 (original), 134 (patched) <https://reviews.apache.org/r/66610/#comment282208> Please use spaces instead of tab core/src/main/java/org/apache/oozie/service/AuthorizationService.java Line 208 (original), 242 (patched) <https://reviews.apache.org/r/66610/#comment282211> Please use spaces instead of tab core/src/test/java/org/apache/oozie/test/XDataTestCase.java Line 782 (original), 788 (patched) <https://reviews.apache.org/r/66610/#comment282209> Please use spaces instead of tab core/src/test/java/org/apache/oozie/test/XDataTestCase.java Line 783 (original), 789 (patched) <https://reviews.apache.org/r/66610/#comment282210> Please use spaces instead of tab - Denes Bodo On April 13, 2018, 5:03 p.m., Peter Orova wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66610/ > ----------------------------------------------------------- > > (Updated April 13, 2018, 5:03 p.m.) > > > Review request for oozie, András Piros and Peter Cseh. > > > Repository: oozie-git > > > Description > ------- > > OOZIE-3196 Authorization: restrict world readability by user > > > Diffs > ----- > > core/src/main/java/org/apache/oozie/service/AuthorizationService.java > 33fd9c3c4 > core/src/main/java/org/apache/oozie/servlet/BaseAdminServlet.java 85610eb51 > core/src/main/java/org/apache/oozie/servlet/BaseJobServlet.java e1bd3cf61 > core/src/main/java/org/apache/oozie/servlet/SLAServlet.java 8fad98be9 > core/src/main/java/org/apache/oozie/servlet/V1JobsServlet.java c1ca65fd2 > core/src/main/java/org/apache/oozie/util/db/FailingConnectionWrapper.java > 0e3102530 > core/src/main/java/org/apache/oozie/workflow/lite/LiteWorkflowApp.java > 5e6dc7a78 > core/src/test/java/org/apache/oozie/event/TestEventGeneration.java > 59d04200b > core/src/test/java/org/apache/oozie/service/TestAuthorizationService.java > 8df0904d2 > core/src/test/java/org/apache/oozie/test/XDataTestCase.java a8fe70372 > > > Diff: https://reviews.apache.org/r/66610/diff/1/ > > > Testing > ------- > > -TestAuthorizationService updated with Unit tests > -Manual testing done on kerberized cluster > > > Thanks, > > Peter Orova > >
