> On May 30, 2017, 11:08 a.m., András Piros wrote: > > core/src/main/java/org/apache/oozie/action/hadoop/GitActionExecutor.java > > Lines 53 (patched) > > <https://reviews.apache.org/r/59620/diff/1/?file=1734063#file1734063line53> > > > > `oozie.git.source.uri` would be better. > > Clay B. wrote: > Thanks! I for some reason thought there was a pattern > `oozie.<action>.<tree>` but I can not seem to find that anymore and your > suggestion makes things much less redundant.
Since the action here is `git` I think it's OK this way - and it even integrates w/ the existing pattern. - András ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59620/#review176291 ----------------------------------------------------------- On July 7, 2017, 1:27 a.m., Clay B. wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59620/ > ----------------------------------------------------------- > > (Updated July 7, 2017, 1:27 a.m.) > > > Review request for oozie and András Piros. > > > Bugs: OOZIE-2877 > https://issues.apache.org/jira/browse/OOZIE-2877 > > > Repository: oozie-git > > > Description > ------- > > OOZIE-2877 - Oozie Git Action > > > Diffs > ----- > > client/src/main/java/org/apache/oozie/cli/OozieCLI.java 4adf1a8 > client/src/main/resources/git-action-0.1.xsd PRE-CREATION > core/src/main/java/org/apache/oozie/action/hadoop/GitActionExecutor.java > PRE-CREATION > core/src/main/resources/oozie-default.xml 5629a89 > docs/src/site/twiki/WorkflowFunctionalSpec.twiki 6bd3e5a > pom.xml 16c5137 > sharelib/git/pom.xml PRE-CREATION > sharelib/git/src/main/java/org/apache/oozie/action/hadoop/GitMain.java > PRE-CREATION > > sharelib/git/src/test/java/org/apache/oozie/action/hadoop/TestGitActionExecutor.java > PRE-CREATION > > sharelib/git/src/test/java/org/apache/oozie/action/hadoop/TestGitMainGetKey.java > PRE-CREATION > > sharelib/git/src/test/java/org/apache/oozie/action/hadoop/TestIntegrationGitActionExecutor.java > PRE-CREATION > sharelib/pom.xml d794246 > src/main/assemblies/sharelib.xml 07dc69c > webapp/pom.xml ee6341c > > > Diff: https://reviews.apache.org/r/59620/diff/2/ > > > Testing > ------- > > Tested using unit and integration tests. Still need to: > * Test on a cluster > * Test with an authenticated SSH hosted Git repo > > Sumitted a request to the JGit community as their branch pulling code seems > to have an > [issue](https://dev.eclipse.org/mhonarc/lists/jgit-dev/msg03343.html). > > > File Attachments > ---------------- > > 0001-OOZIE-2877-Oozie-Git-Action.patch > > https://reviews.apache.org/media/uploaded/files/2017/05/29/24f90a78-3dc1-49fe-bf29-5927a3cd5e72__0001-OOZIE-2877-Oozie-Git-Action.patch > Patch > > https://reviews.apache.org/media/uploaded/files/2017/05/29/dd23dd72-67e0-456f-9b52-e566d8d17d16__0001-OOZIE-2877-Oozie-Git-Action.patch > > > Thanks, > > Clay B. > >
