[ https://issues.apache.org/jira/browse/OOZIE-2877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16458664#comment-16458664 ]
Hadoop QA commented on OOZIE-2877: ---------------------------------- Testing JIRA OOZIE-2877 Cleaning local git workspace ---------------------------- {color:green}+1 PATCH_APPLIES{color} {color:green}+1 CLEAN{color} {color:red}-1 RAW_PATCH_ANALYSIS{color} . {color:green}+1{color} the patch does not introduce any @author tags . {color:green}+1{color} the patch does not introduce any tabs . {color:red}-1{color} the patch contains 4 line(s) with trailing spaces . {color:green}+1{color} the patch does not introduce any line longer than 132 . {color:green}+1{color} the patch adds/modifies 3 testcase(s) {color:green}+1 RAT{color} . {color:green}+1{color} the patch does not seem to introduce new RAT warnings {color:green}+1 JAVADOC{color} . {color:green}+1{color} the patch does not seem to introduce new Javadoc warnings {color:green}+1 COMPILE{color} . {color:green}+1{color} HEAD compiles . {color:green}+1{color} patch compiles . {color:green}+1{color} the patch does not seem to introduce new javac warnings {color:red}-1{color} There are [5] new bugs found below threshold in total that must be fixed. . {color:green}+1{color} There are no new bugs found in [docs]. . {color:green}+1{color} There are no new bugs found in [examples]. . {color:green}+1{color} There are no new bugs found in [tools]. . {color:green}+1{color} There are no new bugs found in [core]. . {color:green}+1{color} There are no new bugs found in [server]. . {color:green}+1{color} There are no new bugs found in [client]. . {color:green}+1{color} There are no new bugs found in [sharelib/distcp]. . {color:green}+1{color} There are no new bugs found in [sharelib/oozie]. . {color:green}+1{color} There are no new bugs found in [sharelib/hcatalog]. . {color:green}+1{color} There are no new bugs found in [sharelib/streaming]. . {color:red}-1{color} There are [5] new bugs found below threshold in [sharelib/git] that must be fixed. . You can find the FindBugs diff here (look for the red and orange ones): sharelib/git/findbugs-new.html . The most important FindBugs errors are: . Dereferenced at GitMain.java:[line 243]: Possible null pointer dereference in org.apache.oozie.action.hadoop.GitMain.cloneRepoToFS(Path, URI, String, File) due to return value of called method . java/io/File.<init>(Ljava/lang/String;)V reads a file whose location might be specified by user input: Known null at GitMain.java:[line 243] . At GitMain.java:[line 223]: At GitMain.java:[line 229] . java/io/File.<init>(Ljava/lang/String;)V reads a file whose location might be specified by user input: At GitMain.java:[line 229] . At GitMain.java:[line 241]: At GitMain.java:[line 241] . {color:green}+1{color} There are no new bugs found in [sharelib/hive]. . {color:green}+1{color} There are no new bugs found in [sharelib/sqoop]. . {color:green}+1{color} There are no new bugs found in [sharelib/spark]. . {color:green}+1{color} There are no new bugs found in [sharelib/hive2]. . {color:green}+1{color} There are no new bugs found in [sharelib/pig]. . {color:green}+1{color} There are no new bugs found in [webapp]. {color:green}+1 BACKWARDS_COMPATIBILITY{color} . {color:green}+1{color} the patch does not change any JPA Entity/Colum/Basic/Lob/Transient annotations . {color:green}+1{color} the patch does not modify JPA files {color:red}-1 TESTS{color} . Tests run: 2115 . Tests failed: 18 . Tests errors: 12 . The patch failed the following testcases: testPartitionDependency(org.apache.oozie.service.TestPartitionDependencyManagerEhcache) testCoordActionRecoveryServiceForWaitingRegisterPartition(org.apache.oozie.service.TestRecoveryService) testCoordinatorActionSelectors(org.apache.oozie.jms.TestJMSJobEventListener) testCoordinatorActionSelectorsNegative(org.apache.oozie.jms.TestJMSJobEventListener) testWorkflowJobSelectors(org.apache.oozie.jms.TestJMSJobEventListener) testOnCoordinatorJobSuccessEvent(org.apache.oozie.jms.TestJMSJobEventListener) testOnWorkflowJobSuspendEvent(org.apache.oozie.jms.TestJMSJobEventListener) testWorkflowJobSelectorsAnd(org.apache.oozie.jms.TestJMSJobEventListener) testOnCoordinatorJobFailureEvent(org.apache.oozie.jms.TestJMSJobEventListener) testConnectionDrop(org.apache.oozie.jms.TestJMSJobEventListener) testWorkflowJobSelectorsNegative(org.apache.oozie.jms.TestJMSJobEventListener) testWorkflowJobSelectorsOr(org.apache.oozie.jms.TestJMSJobEventListener) testOnWorkflowJobSuccessEvent(org.apache.oozie.jms.TestJMSJobEventListener) testOnCoordinatorActionWaitingEvent(org.apache.oozie.jms.TestJMSJobEventListener) testOnWorkflowJobFailureEvent(org.apache.oozie.jms.TestJMSJobEventListener) testOnCoordinatorActionStartEvent(org.apache.oozie.jms.TestJMSJobEventListener) testOnWorkflowJobStartedEvent(org.apache.oozie.jms.TestJMSJobEventListener) testValid(org.apache.oozie.cli.TestValidation) . Tests failing with errors: testDropEventTypeMessage(org.apache.oozie.jms.TestHCatMessageHandler) testCacheUpdateByMessage(org.apache.oozie.jms.TestHCatMessageHandler) testOnSLADurationMetEvent(org.apache.oozie.jms.TestJMSSLAEventListener) testOnSLAStartMetEvent(org.apache.oozie.jms.TestJMSSLAEventListener) testSLAJobSelectorsNegative(org.apache.oozie.jms.TestJMSSLAEventListener) testOnSLAEndMetEvent(org.apache.oozie.jms.TestJMSSLAEventListener) testOnSLAStartMissEvent(org.apache.oozie.jms.TestJMSSLAEventListener) testSLAJobSelectors(org.apache.oozie.jms.TestJMSSLAEventListener) testOnSLAEndMissEvent(org.apache.oozie.jms.TestJMSSLAEventListener) testOnSLADurationMissEvent(org.apache.oozie.jms.TestJMSSLAEventListener) testConnectionRetry(org.apache.oozie.service.TestJMSAccessorService) testThreadLocalSession(org.apache.oozie.jms.TestDefaultConnectionContext) . {color:orange}Tests failed at first run:{color} TestJavaActionExecutor#testCredentialsSkip TestCoordActionInputCheckXCommandNonUTC>TestCoordActionInputCheckXCommand#testNone TestOozieDBCLI#testOozieDBCLI . For the complete list of flaky tests, see TEST-SUMMARY-FULL files. {color:green}+1 DISTRO{color} . {color:green}+1{color} distro tarball builds with the patch ---------------------------- {color:red}*-1 Overall result, please check the reported -1(s)*{color} The full output of the test-patch run is available at . https://builds.apache.org/job/PreCommit-OOZIE-Build/497/ > Oozie Git Action > ---------------- > > Key: OOZIE-2877 > URL: https://issues.apache.org/jira/browse/OOZIE-2877 > Project: Oozie > Issue Type: Sub-task > Components: action > Reporter: Clay B. > Assignee: Clay B. > Priority: Major > Labels: action > Fix For: trunk > > Attachments: 0001-OOZIE-2877-Oozie-Git-Action.patch, > 0002-OOZIE-2877-Oozie-Git-Action.patch, > 0003-OOZIE-2877-Oozie-Git-Action.patch, > 0004-OOZIE-2877-Oozie-Git-Action.patch, > 0005-OOZIE-2877-Oozie-Git-Action.patch, > 0006-OOZIE-2877-Oozie-Git-Action.patch, > 0007-OOZIE-2877-Oozie-Git-Action.patch, > 0008-OOZIE-2877-Oozie-Git-Action.patch, > 0009-OOZIE-2877-Oozie-Git-Action.patch, OOZIE-2877.010.patch > > > To aide in deploying ASCII artifacts to clusters, let's provide a tie-in for > a source-code management system. Git would be my preferred choice. > Ideally, this could handle a user's key material e.g. for an ssh key to pull > down from a secured repository. This would free users from handling their own > key staging and clean-up on YARN nodes and only require them to store the key > secured in HDFS. -- This message was sent by Atlassian JIRA (v7.6.3#76005)