[ https://issues.apache.org/jira/browse/OOZIE-2494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16461119#comment-16461119 ]
Hadoop QA commented on OOZIE-2494: ---------------------------------- Testing JIRA OOZIE-2494 Cleaning local git workspace ---------------------------- {color:green}+1 PATCH_APPLIES{color} {color:green}+1 CLEAN{color} {color:red}-1 RAW_PATCH_ANALYSIS{color} . {color:green}+1{color} the patch does not introduce any @author tags . {color:green}+1{color} the patch does not introduce any tabs . {color:green}+1{color} the patch does not introduce any trailing spaces . {color:red}-1{color} the patch contains 12 line(s) longer than 132 characters . {color:green}+1{color} the patch adds/modifies 1 testcase(s) {color:green}+1 RAT{color} . {color:green}+1{color} the patch does not seem to introduce new RAT warnings {color:green}+1 JAVADOC{color} . {color:green}+1{color} the patch does not seem to introduce new Javadoc warnings {color:green}+1 COMPILE{color} . {color:green}+1{color} HEAD compiles . {color:green}+1{color} patch compiles . {color:green}+1{color} the patch does not seem to introduce new javac warnings {color:green}+1{color} There are no new bugs found in total. . {color:green}+1{color} There are no new bugs found in [examples]. . {color:green}+1{color} There are no new bugs found in [webapp]. . {color:green}+1{color} There are no new bugs found in [core]. . {color:green}+1{color} There are no new bugs found in [tools]. . {color:green}+1{color} There are no new bugs found in [server]. . {color:green}+1{color} There are no new bugs found in [docs]. . {color:green}+1{color} There are no new bugs found in [sharelib/hive2]. . {color:green}+1{color} There are no new bugs found in [sharelib/pig]. . {color:green}+1{color} There are no new bugs found in [sharelib/streaming]. . {color:green}+1{color} There are no new bugs found in [sharelib/hive]. . {color:green}+1{color} There are no new bugs found in [sharelib/hcatalog]. . {color:green}+1{color} There are no new bugs found in [sharelib/sqoop]. . {color:green}+1{color} There are no new bugs found in [sharelib/oozie]. . {color:green}+1{color} There are no new bugs found in [sharelib/distcp]. . {color:green}+1{color} There are no new bugs found in [sharelib/spark]. . {color:green}+1{color} There are no new bugs found in [client]. {color:green}+1 BACKWARDS_COMPATIBILITY{color} . {color:green}+1{color} the patch does not change any JPA Entity/Colum/Basic/Lob/Transient annotations . {color:green}+1{color} the patch does not modify JPA files {color:red}-1 TESTS{color} . Tests run: 2125 . Tests failed: 1 . Tests errors: 1 . The patch failed the following testcases: testCoordActionRecoveryServiceForWaitingRegisterPartition(org.apache.oozie.service.TestRecoveryService) . Tests failing with errors: testConnectionRetry(org.apache.oozie.service.TestJMSAccessorService) . {color:orange}Tests failed at first run:{color} TestJavaActionExecutor#testCredentialsSkip TestOozieDBCLI#testOozieDBCLI . For the complete list of flaky tests, see TEST-SUMMARY-FULL files. {color:green}+1 DISTRO{color} . {color:green}+1{color} distro tarball builds with the patch ---------------------------- {color:red}*-1 Overall result, please check the reported -1(s)*{color} The full output of the test-patch run is available at . https://builds.apache.org/job/PreCommit-OOZIE-Build/502/ > Cron syntax not handling DST properly > ------------------------------------- > > Key: OOZIE-2494 > URL: https://issues.apache.org/jira/browse/OOZIE-2494 > Project: Oozie > Issue Type: Bug > Components: coordinator > Affects Versions: 4.2.0, 5.0.0 > Reporter: Dennis Pallett > Assignee: Julia Kinga Marton > Priority: Blocker > Attachments: CoordinatorFunctionalSpec.html, CronExpressionPOC.java, > OOZIE-2494-001.patch, OOZIE-2494-002.patch, OOZIE-2494-003.patch, > OOZIE-2494-004.patch, OOZIE-2494-005.patch, OOZIE-2494-006.patch, > OOZIE-2494-007.patch, OOZIE-2494-008.patch, OOZIE-2494-009.patch, > OOZIE-2494-010.patch, testActionMaterWithDST3.patch > > > When specifying a coordinator frequency, you can also specify a "timezone". > While the frequency is always calculated in UTC, the timezone’s DST rules are > still applied. We can see this in the following two Coordinators, which ran > across the DST shift (March 13 2016 at 2am) for the America/Los_Angeles > timezone. The "el-UTC" job has "UTC" as the timezone, while the "el-LA" job > has “America/Los_Angeles” as the timezone. Both jobs have a frequency of > {{$\{coord:days(1)\}}}. > {noformat} > Job Name : el-UTC > Start Time : 2016-03-13 01:10 GMT | 2016-03-12 17:10 PST > --------------------------------------------------------- > ID Nominal Time (UTC) Nominal Time (LA) > @1 2016-03-13 01:10 GMT 2016-03-12 17:10 PST > @2 2016-03-14 01:10 GMT 2016-03-13 18:10 PDT > {noformat} > {noformat} > Job Name : el-LA > Start Time : 2016-03-13 01:10 GMT | 2016-03-12 17:10 PST > --------------------------------------------------------- > ID Nominal Time (UTC) Nominal Time (LA) > @1 2016-03-13 01:10 GMT 2016-03-12 17:10 PST > @2 2016-03-14 00:10 GMT 2016-03-13 17:10 PDT > {noformat} > As you can see, @2’s nominal time is adjusted to an hour earlier in the > "el-LA" job, but not in the "el-UTC" job. > However, when running a similar set of jobs, but using cron syntax [({{10 1 > 1/1 * *}}|http://crontab.guru/#10_1_1/1_*_*], which indicates 1:10 every day > of every month), this isn’t the case: > {noformat} > Job Name : cron-UTC > Start Time : 2016-03-13 01:08 GMT | 2016-03-12 17:08 PST > --------------------------------------------------------- > ID Nominal Time (UTC) Nominal Time (LA) > @1 2016-03-13 01:10 GMT 2016-03-12 17:10 PST > @2 2016-03-14 01:10 GMT 2016-03-13 18:10 PDT > {noformat} > {noformat} > Job Name : cron-LA > Start Time : 2016-03-13 01:08 GMT | 2016-03-12 17:08 PST > --------------------------------------------------------- > ID Nominal Time (UTC) Nominal Time (LA) > @1 2016-03-13 01:10 GMT 2016-03-12 17:10 PST > @2 2016-03-14 01:10 GMT 2016-03-13 18:10 PDT > {noformat} > As you can see, @2’s nominal time are the same in both the "cron-UTC" and > "cron-LA" jobs. The "cron-LA" job should have the same nominal time as the > "el-LA" job from earlier. -- This message was sent by Atlassian JIRA (v7.6.3#76005)