----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60039/#review202432 -----------------------------------------------------------
examples/src/main/java/org/apache/oozie/example/DateList.java Line 50 (original), 50 (patched) <https://reviews.apache.org/r/60039/#comment284242> Please mind indentation. examples/src/main/java/org/apache/oozie/example/DateList.java Line 62 (original), 62 (patched) <https://reviews.apache.org/r/60039/#comment284245> Since `Repeatable#getOccurrenceTime()` can deliver `null`, I'd let the original condition here. `do {...} while (true);` seems too dangerous to me. examples/src/main/java/org/apache/oozie/example/DateList.java Line 69 (original), 69 (patched) <https://reviews.apache.org/r/60039/#comment284243> Please mind indentation. examples/src/main/java/org/apache/oozie/example/DateList.java Line 72 (original), 71-72 (patched) <https://reviews.apache.org/r/60039/#comment284244> Please mind indentation. examples/src/main/java/org/apache/oozie/example/Repeatable.java Line 168 (original), 168-170 (patched) <https://reviews.apache.org/r/60039/#comment284246> Would set `this.baseline` here to a new `Date` instance. examples/src/main/java/org/apache/oozie/example/Repeatable.java Line 172 (original), 176 (patched) <https://reviews.apache.org/r/60039/#comment284247> Would modify only in `getBaseline()`. In case input parameter `baseline = null` we'd get an `Exception` here. - András Piros On June 13, 2017, 8:40 a.m., Jan Hentschel wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60039/ > ----------------------------------------------------------- > > (Updated June 13, 2017, 8:40 a.m.) > > > Review request for oozie. > > > Bugs: OOZIE-2942 > https://issues.apache.org/jira/browse/OOZIE-2942 > > > Repository: oozie-git > > > Description > ------- > > Fixed the Findbugs warning in the **oozie-examples** module. > > > Diffs > ----- > > examples/src/main/java/org/apache/oozie/example/DateList.java 7e574cbe > examples/src/main/java/org/apache/oozie/example/LocalOozieExample.java > c9f5697c > examples/src/main/java/org/apache/oozie/example/Repeatable.java ee863251 > > > Diff: https://reviews.apache.org/r/60039/diff/2/ > > > Testing > ------- > > > Thanks, > > Jan Hentschel > >
