> On May 3, 2018, 3:33 p.m., András Piros wrote: > > tools/src/main/java/org/apache/oozie/tools/OozieSharelibCLI.java > > Lines 224-235 (patched) > > <https://reviews.apache.org/r/66930/diff/1/?file=2016229#file2016229line224> > > > > Please extract to another `static final class`, and add integration > > tests that use `XTestCase` to check copying real data onto `MiniDFSCluster`.
TestOozieSharelibCLI:testOozieSharelibCLICreateConcurrent() is testing if the files are copied in concurrent mode. > On May 3, 2018, 3:33 p.m., András Piros wrote: > > tools/src/main/java/org/apache/oozie/tools/OozieSharelibCLI.java > > Lines 322 (patched) > > <https://reviews.apache.org/r/66930/diff/1/?file=2016229#file2016229line323> > > > > I'm just wondering whether in case any errors we should 1) rollback the > > stuff we halfway managed to copy 2) die after this `System.err.println()` > > call. 1. The possibility of a "partial sharelib update" is handled with OOZIE-2629. 2. In case of an Exception the exit status will be 1. This is handled at the end of the run() method. > On May 3, 2018, 3:33 p.m., András Piros wrote: > > tools/src/main/java/org/apache/oozie/tools/OozieSharelibCLI.java > > Lines 349-351 (patched) > > <https://reviews.apache.org/r/66930/diff/1/?file=2016229#file2016229line350> > > > > I'm just wondering whether in case any errors we should 1) rollback the > > stuff we halfway managed to copy 2) die after this `System.err.println()` > > call. 1. The possibility of a "partial sharelib update" is handled with OOZIE-2629. 2. In case of an Exception the exit status will be 1. This is handled at the end of the run() method. - Kinga ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66930/#review202354 ----------------------------------------------------------- On May 10, 2018, 7:59 a.m., Kinga Marton wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66930/ > ----------------------------------------------------------- > > (Updated May 10, 2018, 7:59 a.m.) > > > Review request for oozie, András Piros and Peter Cseh. > > > Repository: oozie-git > > > Description > ------- > > On a busy Hadoop cluster it can happen that users cannot install properly > Oozie ShareLib. > > > Diffs > ----- > > tools/src/main/java/org/apache/oozie/tools/OozieSharelibCLI.java dce1c559 > tools/src/test/java/org/apache/oozie/tools/TestBlockSizeCalculator.java > PRE-CREATION > > > Diff: https://reviews.apache.org/r/66930/diff/2/ > > > Testing > ------- > > Tested manually > > > Thanks, > > Kinga Marton > >
