> On April 20, 2018, 4:10 p.m., András Piros wrote: > > core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java > > Lines 1987-1996 (patched) > > <https://reviews.apache.org/r/66656/diff/1/?file=2004099#file2004099line1989> > > > > Please extract to a separate Java class, e.g. `SharelibExcluder`, that > > would be tested separately. `JavaActionExecutor` is way too heavy by now.
Extracted to separate class, however testing is still in TestShareLibService > On April 20, 2018, 4:10 p.m., András Piros wrote: > > core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java > > Lines 1989 (patched) > > <https://reviews.apache.org/r/66656/diff/1/?file=2004099#file2004099line1991> > > > > I +1 Rohini's opinion on having as exclusion basis the full path of the > > actual JAR here, not only parent directory name and file name. > > > > Imagine following for `actionLibPath`: > > > > * `pig/lib/jackson*.jar` > > * `hbase/lib/jackson*.jar` > > * `oozie/jackson*.jar` > > > > As a user I want following distinct use cases: > > > > * exclude `pig/lib/jackson*.jar` only > > * exclude `pig/lib/jackson*.jar` and `hbase/lib/jackson*.jar` > > * exclude everything which is `jackson*.jar`, independent of location Filtering for the full path, but relativized to the currently active share lib root, thus the root folder cannot be excluded. e.g.: /user/oozie/share/lib/lib123456/pig/lib/jackson-1.2.jar -> pig/lib/jackson-1.2.jar - Mate ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66656/#review201632 ----------------------------------------------------------- On May 16, 2018, 3:37 p.m., Mate Juhasz wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66656/ > ----------------------------------------------------------- > > (Updated May 16, 2018, 3:37 p.m.) > > > Review request for oozie, András Piros and Denes Bodo. > > > Bugs: OOZIE-1624 > https://issues.apache.org/jira/browse/OOZIE-1624 > > > Repository: oozie-git > > > Description > ------- > > OOZIE-1624 Exclusion pattern for sharelib. > > > Diffs > ----- > > core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java > 0ba3cbf9 > core/src/main/java/org/apache/oozie/action/hadoop/ShareLibExcluder.java > PRE-CREATION > core/src/main/java/org/apache/oozie/service/ShareLibService.java a901567d > core/src/test/java/org/apache/oozie/service/TestShareLibService.java > d2441661 > > > Diff: https://reviews.apache.org/r/66656/diff/2/ > > > Testing > ------- > > Tested on a cluster > > > Thanks, > > Mate Juhasz > >
